From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id C2CCF2A5E for ; Wed, 22 Feb 2017 11:10:10 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id v77so7154736wmv.0 for ; Wed, 22 Feb 2017 02:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=A15KW5QlGTX+5fNIQ03tkxjL6SUKmyb9S1QD67V3l9c=; b=fzx5JQQGA7qTP3dTnwIn2PwS1OxxzUSFklrt1SefQUCmqGDpBaf4Cf11afJ/VNNdD1 BP/hczStOjpGzu9x68wU0wjLBpZyCdVIAQXnl1aa+GvpK1nyoFKprNcUkpVVMeRwekQ8 hwi5PbD7rjuCwuceFyBMI+8WfjeMNsYKKj83Mvsg1CejA/2fzDYcl5rf0EcbY6A8EFHz seKASU9x2ekgHMn99b4Hy6Mdj2wZz+EtIvIiI733BIWiwtTUMB9MiYqBY4JgHydyruTn ibiFf+7vyso/Fuu9S1KlyCMtrheMo4mb0RDD/eKAt5WolXReTEL2OONOrTWU8HtvK0Xh SXxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=A15KW5QlGTX+5fNIQ03tkxjL6SUKmyb9S1QD67V3l9c=; b=jm9Zv3HbC1pAX48EeoEpggIwolf6y1hEskJ4/YvKipjHytYdi0eUUK5cLatwNWUSMT CxoEgu+NRm6aQbDN6lMa3PNsOm3pFlC/ItZ0EGah+RzHf6Y6Eincb6+yuhOFaLnR681P yKfMNoiY36dmafqevDh8Nhh1iCkxYmeEqWAElmi5dq7WsimGw5Rf8Ut7gbLGzh5KYcl4 PRfeUlXUetNRyjGIUIfQu3dkbcBA3sfRsJhyrCc9Rx7mXREPB6fMmCihSWxK1Mm011nv rAmjDIoeNOFJ8Qs0EanCpsGWtCeGpwj7hWKAxVaL8F5aUsNCCM7jh2YH2nvajVHmC6mY IU7Q== X-Gm-Message-State: AMke39nIhqtgjHuu8IK3hUIcQZXRbxNCdlYVdz4Pk57eXPQ3BK/wyLA9pfz1pgOPO8anwXsl X-Received: by 10.28.102.67 with SMTP id a64mr1693177wmc.140.1487758210011; Wed, 22 Feb 2017 02:10:10 -0800 (PST) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id t30sm1084692wra.52.2017.02.22.02.10.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 Feb 2017 02:10:09 -0800 (PST) Date: Wed, 22 Feb 2017 11:10:01 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Vasily Philipov Cc: dev@dpdk.org, Adrien Mazarguil Message-ID: <20170222101001.GJ23344@autoinstall.dev.6wind.com> References: <74798f347a5b1fad28037b713ad83048c227a2ca.1487685098.git.vasilyf@mellanox.com> <7dfd4feed27ce41c118b402f0f93c4332ff05ba2.1487685098.git.vasilyf@mellanox.com> <20170222083742.GI23344@autoinstall.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170222083742.GI23344@autoinstall.dev.6wind.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx4: support basic flow items and actions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2017 10:10:10 -0000 On Wed, Feb 22, 2017 at 09:37:42AM +0100, Nélio Laranjeiro wrote: > On Tue, Feb 21, 2017 at 02:07:03PM +0000, Vasily Philipov wrote: > > Adding support for the next items: eth, vlan, ipv4, udp, tcp and for the > > next actions: queue, drop > > > > Signed-off-by: Vasily Philipov > > --- > > drivers/net/mlx4/Makefile | 3 +- > > drivers/net/mlx4/mlx4.c | 60 ++- > > drivers/net/mlx4/mlx4.h | 3 + > > drivers/net/mlx4/mlx4_flow.c | 1053 ++++++++++++++++++++++++++++++++++++++++++ > > drivers/net/mlx4/mlx4_flow.h | 104 +++++ > > 5 files changed, 1220 insertions(+), 3 deletions(-) > > create mode 100644 drivers/net/mlx4/mlx4_flow.c > > create mode 100644 drivers/net/mlx4/mlx4_flow.h > > >[...] > > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > > index 82ccac8..cc2ebfa 100644 > > --- a/drivers/net/mlx4/mlx4.c > > +++ b/drivers/net/mlx4/mlx4.c > > @@ -3985,8 +3989,9 @@ struct txq_mp2mr_mbuf_check_data { > > return -ret; > > } while ((--r) && ((rxq = (*priv->rxqs)[++i]), i)); > > priv_dev_interrupt_handler_install(priv, dev); > > + err = mlx4_priv_flow_start(priv); > > priv_unlock(priv); > > - return 0; > > + return -err; >[...] Hi Vasily, There is an issue in this mlx4_dev_start() when flows cannot be re-applied (like in mlx5 [1][2]). Can you fix it in a v2 please? Thanks, [1] http://dpdk.org/ml/archives/dev/2017-February/058111.html [2] http://dpdk.org/dev/patchwork/patch/20664/ -- Nélio Laranjeiro 6WIND