From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f50.google.com (mail-pg0-f50.google.com [74.125.83.50]) by dpdk.org (Postfix) with ESMTP id 31A662BAA for ; Fri, 24 Feb 2017 07:55:16 +0100 (CET) Received: by mail-pg0-f50.google.com with SMTP id z128so7760466pgb.0 for ; Thu, 23 Feb 2017 22:55:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5etwk5mH8feeJQssvlDq7vxHElTSG8mnKMPxLgEN8TQ=; b=c3tgTRYEu3edBwsHqoXigngvPHKBcuPPRU3VCMuQm8KLYzYYjAligB8Tuuk1/2ZPVA XxbzU/p75QyEy4XSr6gSxjFO+ihtP3yuqgqYneXD3posic9FFTVXbIG3Mj2x3mgynaoG za3ZhUAB1xcnm68UN8Vz4UgpMulnOo1CaoYDRXj2AA3cyyED+dbC558nC+NRqjlDv6TH zome+4GVZHWWZeBaeJgD/7uUtWaGJdk/SR2juq3LNaHNZMeJb/aVzSjUzL0E8VVlRwb0 GX06EwpjfETIiQskdz9RmyPqLHeiGhjB6vs6wKiHSH4plE0aOgoVylapjVfs+6OpF/a0 c6+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5etwk5mH8feeJQssvlDq7vxHElTSG8mnKMPxLgEN8TQ=; b=pdxcXDkiviH33Z9GtPTtRvbgKi7soeAl/47u0PgNcZOTsmf5beEuS9SNNlWNWgE4de nfNTozlUJUvtocD+ioPU/Oneu0T3TgiL32b7sInYQ/UIt4OwgqrVDjNQsHsM1zoOEtcL wgky70EjkKwUyRZl8RHs2kECznMZJ+IpRmCXNgYLv6kptCbItveUAcOs8fMAVuRhyZes eN3PAyJzn5lPhecC0WYgP7q0EdVtzbLiC5lr+IUN7aDnmsX1aIxAwxUtEXGpGNBFh7+V Zw5JbDcYIsjUxJOJptNpOuqYiCZ892AgSvnWT4CiE0pZPunk27KXlzfjB6lBqnvOo52h Dzlw== X-Gm-Message-State: AMke39kU1e53HCukxt8hkUlv2kep4Pgzj9layMcS5Ns+GcHz5NiUWh/gu6XENQPsXmvTyw== X-Received: by 10.98.16.14 with SMTP id y14mr1569977pfi.63.1487919315348; Thu, 23 Feb 2017 22:55:15 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id u78sm13113464pfa.101.2017.02.23.22.55.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Feb 2017 22:55:15 -0800 (PST) Date: Thu, 23 Feb 2017 22:55:07 -0800 From: Stephen Hemminger To: Wenzhuo Lu Cc: dev@dpdk.org Message-ID: <20170223225507.69ee0e47@xeon-e3> In-Reply-To: <1487906675-54260-1-git-send-email-wenzhuo.lu@intel.com> References: <1487906675-54260-1-git-send-email-wenzhuo.lu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 06:55:16 -0000 On Fri, 24 Feb 2017 11:24:27 +0800 Wenzhuo Lu wrote: > This patch set enables several QoS features on i40e. > 1, VF max bandwidth setting. > 2, TC min bandwidth setting on a VF. > 3, TC max bandwidth setting on a VF. > 4, TC TX scheduling mode setting. > As there're no new interface between PF and VF defined, all the settings > for VF are done on PF. PF acts as a controller for the VFs. > > Wenzhuo Lu (8): > net/i40e: set VF max bandwidth from PF > net/i40e: allocate VF TC bandwidth from PF > net/i40e: set VF TC max bandwidth from PF > net/i40e: set TC strict priority mode > app/testpmd: set VF TX max bandwidth > app/testpmd: set VF TC TX min bandwidth > app/testpmd: set VF TC TX max bandwidth > app/testpmd: set TC strict link priority mode > > app/test-pmd/cmdline.c | 343 +++++++++++++++++++++ > doc/guides/nics/i40e.rst | 21 ++ > doc/guides/rel_notes/release_17_05.rst | 20 ++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 28 ++ > drivers/net/i40e/i40e_ethdev.c | 449 ++++++++++++++++++++++++++++ > drivers/net/i40e/i40e_ethdev.h | 1 + > drivers/net/i40e/rte_pmd_i40e.h | 86 ++++++ > drivers/net/i40e/rte_pmd_i40e_version.map | 10 + > 8 files changed, 958 insertions(+) > It is good to allow setting QoS on device, but it looks like this is a device specific API, not a generic PMD function. I don't think any feature in DPDK should be hardcoded to one device type.