From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4E9AF2B88 for ; Fri, 24 Feb 2017 15:07:49 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP; 24 Feb 2017 06:07:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,201,1484035200"; d="scan'208";a="61822253" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by orsmga004.jf.intel.com with SMTP; 24 Feb 2017 06:07:33 -0800 Received: by (sSMTP sendmail emulation); Fri, 24 Feb 2017 14:07:33 +0000 Date: Fri, 24 Feb 2017 14:07:32 +0000 From: Bruce Richardson To: David Hunt Cc: dev@dpdk.org Message-ID: <20170224140732.GD106392@bricha3-MOBL3.ger.corp.intel.com> References: <1485163480-156507-2-git-send-email-david.hunt@intel.com> <1487647073-129064-1-git-send-email-david.hunt@intel.com> <1487647073-129064-4-git-send-email-david.hunt@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487647073-129064-4-git-send-email-david.hunt@intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH v7 03/17] lib: create rte_distributor_private.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Feb 2017 14:07:49 -0000 On Tue, Feb 21, 2017 at 03:17:39AM +0000, David Hunt wrote: > We'll be adding content in here common to both burst and > legacy APIs. > > Signed-off-by: David Hunt > --- Couple of minor nits on the commit text here: * check-git-log.sh doesn't like the title as it's too technical. Suggest using "create private header file" or similar * I think you could quality the "content" as being "internal implementation definitions" /Bruce