From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 50412591E for ; Mon, 27 Feb 2017 14:00:36 +0100 (CET) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Feb 2017 05:00:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,214,1484035200"; d="scan'208";a="62539930" Received: from bricha3-mobl3.ger.corp.intel.com ([10.252.1.169]) by orsmga004.jf.intel.com with SMTP; 27 Feb 2017 05:00:24 -0800 Received: by (sSMTP sendmail emulation); Mon, 27 Feb 2017 13:00:23 +0000 Date: Mon, 27 Feb 2017 13:00:23 +0000 From: Bruce Richardson To: Aaron Conole Cc: dev@dpdk.org, Stephen Hemminger Message-ID: <20170227130022.GB127920@bricha3-MOBL3.ger.corp.intel.com> References: <20170209142953.8167-1-aconole@redhat.com> <20170225160309.31270-1-aconole@redhat.com> <20170225160309.31270-3-aconole@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170225160309.31270-3-aconole@redhat.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH v4 02/26] eal: return error instead of panic for cpu init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 13:00:36 -0000 On Sat, Feb 25, 2017 at 11:02:45AM -0500, Aaron Conole wrote: > There may be no way to gracefully recover, but the application > should be notified that a failure happened, rather than completely > aborting. This allows the user to proceed with a "slow-path" type > solution. > > Signed-off-by: Aaron Conole > --- > lib/librte_eal/linuxapp/eal/eal.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c > index bf6b818..5023d0d 100644 > --- a/lib/librte_eal/linuxapp/eal/eal.c > +++ b/lib/librte_eal/linuxapp/eal/eal.c > @@ -740,6 +740,12 @@ static int rte_eal_vfio_setup(void) > } > #endif > > +static void rte_eal_init_alert(const char *msg) > +{ > + fprintf(stderr, "EAL: FATAL: %s\n", msg); > + RTE_LOG(ERR, EAL, "%s\n", msg); > +} Checkpatch flags the use of spaces rather than tabs here. /Bruce