From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f52.google.com (mail-pg0-f52.google.com [74.125.83.52]) by dpdk.org (Postfix) with ESMTP id D9D292BB1 for ; Wed, 1 Mar 2017 16:10:31 +0100 (CET) Received: by mail-pg0-f52.google.com with SMTP id p5so21277596pga.1 for ; Wed, 01 Mar 2017 07:10:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pxgqJWfHLOmV/M+2p2TShkAzkxvNiErP/WEYO090+yg=; b=eWqWE609vby6PNTwT4oD1HyA2IrmkSf8Ll0modGYrbiAeTc0RRqj8lHysLH4FEmuLT rqxLx1tSpJVTchPySjwo3aXVE09gqjBStRDnzLzKNj/5PX0iTNKQGISSkHCbn4Ex7WO0 wAErvembjfy7wOAetAViKlPni4fQ2cbdQFrpC0VlLP44mrY+sfK3OWZQWEEGZ52ti9Yw Ck/Ed6YBrl05d824zR+3VCoiDtRKf0iSHb0mnlULvN+cMQaRUmZYTuxoR7XFkh+v/ve6 2KeiYcse+Gs65JEMJtWIG4dvJVX8DGjLSGclWBr2l6mLOtFI2YHib4kpOf75DRMTqXcJ jqEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pxgqJWfHLOmV/M+2p2TShkAzkxvNiErP/WEYO090+yg=; b=BrAm2+SySb1hdThsPKNhPa8pJi8k8Ch/ADH4RrmE2eZVVWOyS8FhIx+gwImNLmKA7u SdiFfFjBZezgh4GdQwXiZi1usP2xZdX7W0kmB3iggJYtqEtLmRHUEHeQmDHQ6snCSZjh r0Q1E4bUmu18ePW5yV3IiDbNtOuvLGL4xgW2XmN9HOruJxHco2ybfCjjzcgKZ5Hrm3IY ynVP8wyU4+PLAg8ouBNR3cYvQzQbpR5CCVzvSJUYyAi6eSohP0ZVek7LCNYNox3gJip0 8fOJOXFk9Cc0yjf/k/o1+72wdzcT1xBrwXrc+PZvE3fnoxkuNZNtGY2z7Bpf4JWp1Mwe 6bIQ== X-Gm-Message-State: AMke39nlUMbT7TGaW+Bp9eb+C5W/ZUwcJkA6z11qtEpmjrWebZdpmWVIY8AYzboWfXfqqA== X-Received: by 10.98.217.67 with SMTP id s64mr9183256pfg.119.1488381030861; Wed, 01 Mar 2017 07:10:30 -0800 (PST) Received: from xeon-e3 (204-195-18-65.wavecable.com. [204.195.18.65]) by smtp.gmail.com with ESMTPSA id 197sm11262104pfv.19.2017.03.01.07.10.30 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Mar 2017 07:10:30 -0800 (PST) Date: Wed, 1 Mar 2017 07:10:23 -0800 From: Stephen Hemminger To: Thomas Monjalon Cc: "Legacy, Allain" , dev@dpdk.org, "RICHARDSON, BRUCE" , "YIGIT, FERRUH" Message-ID: <20170301071023.54417ae9@xeon-e3> In-Reply-To: <1802328.ieTeZWi1ce@xps13> References: <1487985795-136044-1-git-send-email-allain.legacy@windriver.com> <20170228102701.GA141940@bricha3-MOBL3.ger.corp.intel.com> <70A7408C6E1BFB41B192A929744D85238A75943B@ALA-MBC.corp.ad.wrs.com> <1802328.ieTeZWi1ce@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 11/15] net/avp: packet receive functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 15:10:32 -0000 On Wed, 01 Mar 2017 15:14:57 +0100 Thomas Monjalon wrote: > 2017-03-01 13:23, Legacy, Allain: > > > -----Original Message----- > > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > > In my experience, checkpatch ignores long lines that are due to error > > > messages. Perhaps you need to put the error message on a separate line, > > > if other things before the message are of significant size. > > I have gone through the entire patchset and reverted my previous changes to reduce line length on any occurrences of debug log strings. I kept the error message on the first line and all input variables on subsequent lines (and no longer than 80). checkpatches.sh flags most of them as warnings, but since unbroken strings seems more important I will submit my next patchset version (v3) like this. > > > > WARNING:LONG_LINE_STRING: line over 80 characters > > #120: FILE: drivers/net/avp/avp_ethdev.c:236: > > + PMD_DRV_LOG(ERR, "Timeout while waiting for a response for %u\n", > > > > There is maybe something to fix in the checkpatches.sh options. > Please could you look at SPLIT_STRING and LONG_LINE_STRING? In checkpatch source there is a regex to identify logging functions and special exceptions for long lines etc. But the logging functions are for kernel (printk etc), not DPDK logging functions so the messages are incorrect. Maybe there is some way to extend checkpatch to handle rte_log?