From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 6F7442B9D for ; Wed, 1 Mar 2017 11:33:36 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Mar 2017 02:33:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,225,1484035200"; d="scan'208";a="1103527668" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by orsmga001.jf.intel.com with SMTP; 01 Mar 2017 02:33:33 -0800 Received: by (sSMTP sendmail emulation); Wed, 01 Mar 2017 10:33:31 +0000 Date: Wed, 1 Mar 2017 10:33:31 +0000 From: Bruce Richardson To: Olivier Matz Cc: dev@dpdk.org Message-ID: <20170301103331.GA25032@bricha3-MOBL3.ger.corp.intel.com> References: <20170223172407.27664-1-bruce.richardson@intel.com> <20170223172407.27664-3-bruce.richardson@intel.com> <20170301112243.6f91e0cb@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170301112243.6f91e0cb@platinum> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH v1 02/14] ring: create common structure for prod and cons metadata X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 10:33:36 -0000 On Wed, Mar 01, 2017 at 11:22:43AM +0100, Olivier Matz wrote: > On Thu, 23 Feb 2017 17:23:55 +0000, Bruce Richardson > wrote: > > create a common structure to hold the metadata for the producer and > > the consumer, since both need essentially the same information - the > > head and tail values, the ring size and mask. > > > > Signed-off-by: Bruce Richardson > > --- > > lib/librte_ring/rte_ring.h | 32 ++++++++++++++++---------------- > > 1 file changed, 16 insertions(+), 16 deletions(-) > > > > diff --git a/lib/librte_ring/rte_ring.h b/lib/librte_ring/rte_ring.h > > index 04fe667..0c8defd 100644 > > --- a/lib/librte_ring/rte_ring.h > > +++ b/lib/librte_ring/rte_ring.h > > @@ -1,7 +1,7 @@ > > /*- > > * BSD LICENSE > > * > > - * Copyright(c) 2010-2014 Intel Corporation. All rights reserved. > > + * Copyright(c) 2010-2017 Intel Corporation. All rights reserved. > > * All rights reserved. > > * > > * Redistribution and use in source and binary forms, with or > > without @@ -139,6 +139,19 @@ struct rte_ring_debug_stats { > > > > struct rte_memzone; /* forward declaration, so as not to require > > memzone.h */ > > +/* structure to hold a pair of head/tail values and other metadata */ > > +struct rte_ring_ht_ptr { > > Just wondering if we can find a better name for this structure. I'm not > sure '_ptr' is really relevant. What do you think of: > > rte_ring_endpoint > rte_ring_ht > rte_ring_headtail > I'll use one of the latter two in next version. /Bruce