From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 44F17C304 for ; Wed, 1 Mar 2017 11:43:46 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP; 01 Mar 2017 02:43:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,225,1484035200"; d="scan'208";a="1103530275" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by orsmga001.jf.intel.com with SMTP; 01 Mar 2017 02:43:44 -0800 Received: by (sSMTP sendmail emulation); Wed, 01 Mar 2017 10:43:43 +0000 Date: Wed, 1 Mar 2017 10:43:43 +0000 From: Bruce Richardson To: Olivier Matz Cc: dev@dpdk.org Message-ID: <20170301104343.GC25032@bricha3-MOBL3.ger.corp.intel.com> References: <20170223172407.27664-1-bruce.richardson@intel.com> <20170223172407.27664-7-bruce.richardson@intel.com> <20170301113457.0f2a2ef8@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170301113457.0f2a2ef8@platinum> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.7.2 (2016-11-26) Subject: Re: [dpdk-dev] [PATCH v1 06/14] ring: remove watermark support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 10:43:47 -0000 On Wed, Mar 01, 2017 at 11:34:57AM +0100, Olivier Matz wrote: > On Thu, 23 Feb 2017 17:23:59 +0000, Bruce Richardson wrote: > > Remove the watermark support. A future commit will add support for having > > enqueue functions return the amount of free space in the ring, which will > > allow applications to implement their own watermark checks, while also > > being more useful to the app. > > > > Signed-off-by: Bruce Richardson > > --- > > app/test/commands.c | 52 ------------ > > app/test/test_ring.c | 149 +-------------------------------- > > doc/guides/rel_notes/release_17_05.rst | 2 + > > examples/Makefile | 2 +- > > lib/librte_ring/rte_ring.c | 23 ----- > > lib/librte_ring/rte_ring.h | 58 +------------ > > 6 files changed, 8 insertions(+), 278 deletions(-) > > There are some other references to remove: > > app/test/autotest_test_funcs.py: child.sendline("set_watermark test 100") > app/test/autotest_test_funcs.py: index = child.expect([" watermark=100", > app/test/autotest_test_funcs.py: return -1, "Fail [Bad watermark]" > > doc/guides/prog_guide/ring_lib.rst:Water Marking > doc/guides/prog_guide/ring_lib.rst:The ring can have a high water mark (threshold). > doc/guides/prog_guide/ring_lib.rst:Once an enqueue operation reaches the high water mark, the producer is notified, if the water mark is configured. > Yep, good catch. Will include in v2 /Bruce