From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 448442BB1 for ; Wed, 1 Mar 2017 11:35:00 +0100 (CET) Received: by mail-wr0-f175.google.com with SMTP id l37so26979563wrc.1 for ; Wed, 01 Mar 2017 02:35:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9WjlKd1rEzsWI7bkZWvRy74AK7NGX+CYhD/MR2TFs0U=; b=QF94r9THqiqHpweyyypV9Olxq+fb1/HHeApqast2Xv4BJN1y+Nl4Ipp4Z7qLsus6nu OL5pwDCpcmEuGTt0JKmniXgXtuG7ZV7xX9cbZmZe/Cm/RvRtxkerYV3sGElfLJ/aZFdT rQZ/Y5t6YLqjofb7PAgKgQs92KMjq2SgkcGW8oaCU6mRVzglyUZAGhJDp7kRzADbuQJz A6VCHA7/J12abjSQcwrHA90k7Kil4sMYbjqZGHLLvYirS7qJXMcJH/6wj6ww5eyqhT4c SjBsvG2PfVVyJYcIEgyF7gK0iPLfDyLfBH8+DNhtuyLP7qZyl0tZ5W3luAm+DlahcCv1 UgBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9WjlKd1rEzsWI7bkZWvRy74AK7NGX+CYhD/MR2TFs0U=; b=jlFsWN/XMhnIq73fdAlRVBHhq32LQBCPxufaCYoCUGviWZGiieCyi44tlxpJoPPr3l 2oEkQSZOkpfKhEu2PV17rkY8h1IRRYZppNBjk5EIzpKDedvSWg3cT5qDvbEK6tX7wx0W yjsCHpGRsk2I840Ka9oglgTwMcGqTXZrcj3zvRsvLHLw/pCwcjSPZWsxUil2bbtbJM8W EUY1jXAglj3RZVetJ+KefegcHLZv/4tLdv0rLKugxJnc+PfTP2eWviuctLdJW5i3st+Q a9wtIvQR4qMc27HqIrOXQ7RebVP4XSClKNARXy+5DhGKlRG4aZS+elcpuRv6Jxtn8T3o l/3Q== X-Gm-Message-State: AMke39mkl8pYNYbXus/0G4523Van7kFNTjeuvBLL7I7qlJ5e4mRY2dUJp4iIILbq4j/ryUJv X-Received: by 10.223.147.162 with SMTP id 31mr6244023wrp.133.1488364499959; Wed, 01 Mar 2017 02:34:59 -0800 (PST) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id 39sm5980667wrv.55.2017.03.01.02.34.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 01 Mar 2017 02:34:59 -0800 (PST) Date: Wed, 1 Mar 2017 11:34:57 +0100 From: Olivier Matz To: Bruce Richardson Cc: dev@dpdk.org Message-ID: <20170301113457.0f2a2ef8@platinum> In-Reply-To: <20170223172407.27664-7-bruce.richardson@intel.com> References: <20170223172407.27664-1-bruce.richardson@intel.com> <20170223172407.27664-7-bruce.richardson@intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 06/14] ring: remove watermark support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 10:35:00 -0000 On Thu, 23 Feb 2017 17:23:59 +0000, Bruce Richardson wrote: > Remove the watermark support. A future commit will add support for having > enqueue functions return the amount of free space in the ring, which will > allow applications to implement their own watermark checks, while also > being more useful to the app. > > Signed-off-by: Bruce Richardson > --- > app/test/commands.c | 52 ------------ > app/test/test_ring.c | 149 +-------------------------------- > doc/guides/rel_notes/release_17_05.rst | 2 + > examples/Makefile | 2 +- > lib/librte_ring/rte_ring.c | 23 ----- > lib/librte_ring/rte_ring.h | 58 +------------ > 6 files changed, 8 insertions(+), 278 deletions(-) There are some other references to remove: app/test/autotest_test_funcs.py: child.sendline("set_watermark test 100") app/test/autotest_test_funcs.py: index = child.expect([" watermark=100", app/test/autotest_test_funcs.py: return -1, "Fail [Bad watermark]" doc/guides/prog_guide/ring_lib.rst:Water Marking doc/guides/prog_guide/ring_lib.rst:The ring can have a high water mark (threshold). doc/guides/prog_guide/ring_lib.rst:Once an enqueue operation reaches the high water mark, the producer is notified, if the water mark is configured.