From: Bruce Richardson <bruce.richardson@intel.com>
To: Beilei Xing <beilei.xing@intel.com>
Cc: jingjing.wu@intel.com, helin.zhang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ppp implemantation
Date: Fri, 3 Mar 2017 09:41:03 +0000 [thread overview]
Message-ID: <20170303094103.GA189196@bricha3-MOBL3.ger.corp.intel.com> (raw)
In-Reply-To: <20170303093926.GB188460@bricha3-MOBL3.ger.corp.intel.com>
On Fri, Mar 03, 2017 at 09:39:26AM +0000, Bruce Richardson wrote:
> Given that this patch is not about point-to-point protocol, i.e. the
> best-known expansion of "PPP", I think you need to clarify the acronym
> in the commit message, at minimum, if not also in the commit title.
>
> /Bruce
>
Never mind, I see your updated patchset has already been sent with
better titles.
/Bruce
> On Fri, Mar 03, 2017 at 03:26:07PM +0800, Beilei Xing wrote:
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > ---
> > app/test-pmd/cmdline.c | 57 ++++++++
> > app/test-pmd/config.c | 62 +++++++++
> > app/test-pmd/testpmd.h | 3 +
> > drivers/net/i40e/base/i40e_adminq_cmd.h | 32 +++++
> > drivers/net/i40e/base/i40e_common.c | 236 +++++++++++++++++++++++++++++++-
> > drivers/net/i40e/base/i40e_prototype.h | 17 +++
> > drivers/net/i40e/base/i40e_type.h | 79 +++++++++++
> > drivers/net/i40e/i40e_ethdev.c | 68 +++++++++
> > drivers/net/i40e/rte_pmd_i40e.h | 1 +
> > 9 files changed, 554 insertions(+), 1 deletion(-)
> >
next prev parent reply other threads:[~2017-03-03 9:41 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 7:26 [dpdk-dev] [PATCH] MPSL enabling Beilei Xing
2017-03-03 7:26 ` [dpdk-dev] [PATCH 1/2] net/i40e: change tunnel filter function name Beilei Xing
2017-03-03 7:26 ` [dpdk-dev] [PATCH] ppp implemantation Beilei Xing
2017-03-03 9:39 ` Bruce Richardson
2017-03-03 9:41 ` Bruce Richardson [this message]
2017-03-03 7:26 ` [dpdk-dev] [PATCH 2/2] net/i40e: parse NVGRE filter Beilei Xing
2017-03-03 7:26 ` [dpdk-dev] [PATCH] PPP prototype Beilei Xing
2017-03-03 7:26 ` [dpdk-dev] [PATCH] ppp implemantation Beilei Xing
2017-03-03 7:26 ` [dpdk-dev] [PATCH 0/6] net/i40e: support pipeline personalization profile Beilei Xing
2017-03-03 7:39 ` [dpdk-dev] [PATCH v2 0/5] " Beilei Xing
2017-03-03 7:39 ` [dpdk-dev] [PATCH v2 1/5] " Beilei Xing
2017-03-08 12:07 ` Ferruh Yigit
2017-03-09 3:30 ` Xing, Beilei
2017-03-03 7:39 ` [dpdk-dev] [PATCH v2 2/5] net/i40e: add ppp processing Beilei Xing
2017-03-08 12:07 ` Ferruh Yigit
2017-03-03 7:39 ` [dpdk-dev] [PATCH v2 3/5] app/testpmd: add command for writing personalization profile Beilei Xing
2017-03-08 12:10 ` Ferruh Yigit
2017-03-03 7:39 ` [dpdk-dev] [PATCH v2 4/5] net/i40e: add get all loaded profiles Beilei Xing
2017-03-03 7:39 ` [dpdk-dev] [PATCH v2 5/5] app/testpmd: add command for getting " Beilei Xing
2017-03-08 11:43 ` [dpdk-dev] [PATCH v2 0/5] net/i40e: support pipeline personalization profile Ferruh Yigit
2017-03-09 3:07 ` Xing, Beilei
2017-03-23 10:02 ` [dpdk-dev] [PATCH v3 0/5] pipeline personalization profile support Beilei Xing
2017-03-23 10:02 ` [dpdk-dev] [PATCH v3 1/5] net/i40e: add pipeline personalization profile processing Beilei Xing
2017-03-23 14:50 ` Iremonger, Bernard
2017-03-24 2:01 ` Xing, Beilei
2017-03-23 10:02 ` [dpdk-dev] [PATCH v3 2/5] app/testpmd: add command for loading a profile Beilei Xing
2017-03-23 10:02 ` [dpdk-dev] [PATCH v3 3/5] net/i40e: add get all loaded profiles Beilei Xing
2017-03-23 10:02 ` [dpdk-dev] [PATCH v3 4/5] app/testpmd: add command for getting " Beilei Xing
2017-03-23 10:02 ` [dpdk-dev] [PATCH v3 5/5] doc: add pipeline personalization profile support for i40e Beilei Xing
2017-03-24 10:19 ` [dpdk-dev] [PATCH v4 0/5] pipeline personalization profile support Beilei Xing
2017-03-24 10:19 ` [dpdk-dev] [PATCH v4 1/5] net/i40e: add pipeline personalization profile processing Beilei Xing
2017-03-24 14:52 ` Chilikin, Andrey
2017-03-25 4:04 ` Xing, Beilei
2017-03-25 21:03 ` Chilikin, Andrey
2017-03-27 2:09 ` Xing, Beilei
2017-03-24 10:19 ` [dpdk-dev] [PATCH v4 2/5] app/testpmd: add command for loading a profile Beilei Xing
2017-03-24 10:19 ` [dpdk-dev] [PATCH v4 3/5] net/i40e: add get all loaded profiles Beilei Xing
2017-03-24 10:19 ` [dpdk-dev] [PATCH v4 4/5] app/testpmd: add command for getting " Beilei Xing
2017-03-24 10:19 ` [dpdk-dev] [PATCH v4 5/5] doc: add pipeline personalization profile support for i40e Beilei Xing
2017-03-24 14:31 ` Mcnamara, John
2017-03-27 6:17 ` [dpdk-dev] [PATCH v5 0/5] pipeline personalization profile support Beilei Xing
2017-03-27 6:17 ` [dpdk-dev] [PATCH v5 1/5] net/i40e: add pipeline personalization profile processing Beilei Xing
2017-03-27 6:17 ` [dpdk-dev] [PATCH v5 2/5] app/testpmd: add command for loading a profile Beilei Xing
2017-03-27 6:17 ` [dpdk-dev] [PATCH v5 3/5] net/i40e: add get all loaded profiles Beilei Xing
2017-03-27 6:17 ` [dpdk-dev] [PATCH v5 4/5] app/testpmd: add command for getting " Beilei Xing
2017-03-27 6:17 ` [dpdk-dev] [PATCH v5 5/5] doc: add pipeline personalization profile support for i40e Beilei Xing
2017-03-29 12:26 ` [dpdk-dev] [PATCH v6 0/6] dynamic device profile support Beilei Xing
2017-03-29 12:26 ` [dpdk-dev] [PATCH v6 1/6] net/i40e/base: change ppp to ddp Beilei Xing
2017-03-29 12:26 ` [dpdk-dev] [PATCH v6 2/6] net/i40e: add dynamic device profile processing Beilei Xing
2017-03-29 13:17 ` Wu, Jingjing
2017-03-29 14:25 ` Xing, Beilei
2017-03-29 12:26 ` [dpdk-dev] [PATCH v6 3/6] app/testpmd: add command for loading a profile Beilei Xing
2017-03-29 12:26 ` [dpdk-dev] [PATCH v6 4/6] net/i40e: add get all loaded profiles Beilei Xing
2017-03-29 12:26 ` [dpdk-dev] [PATCH v6 5/6] app/testpmd: add command for getting " Beilei Xing
2017-03-29 12:26 ` [dpdk-dev] [PATCH v6 6/6] doc: add dynamic device profile support for i40e Beilei Xing
2017-03-29 14:44 ` [dpdk-dev] [PATCH v7 0/6] dynamic device profile support Beilei Xing
2017-03-29 14:44 ` [dpdk-dev] [PATCH v7 1/6] net/i40e/base: change ppp to ddp Beilei Xing
2017-03-29 14:44 ` [dpdk-dev] [PATCH v7 2/6] net/i40e: add dynamic device profile processing Beilei Xing
2017-03-29 14:44 ` [dpdk-dev] [PATCH v7 3/6] app/testpmd: add command for loading a profile Beilei Xing
2017-03-29 14:44 ` [dpdk-dev] [PATCH v7 4/6] net/i40e: add get all loaded profiles Beilei Xing
2017-03-29 14:44 ` [dpdk-dev] [PATCH v7 5/6] app/testpmd: add command for getting " Beilei Xing
2017-03-29 14:44 ` [dpdk-dev] [PATCH v7 6/6] doc: add dynamic device profile support for i40e Beilei Xing
2017-03-30 2:51 ` [dpdk-dev] [PATCH v8 0/6] dynamic device personalization support Beilei Xing
2017-03-30 2:51 ` [dpdk-dev] [PATCH v8 1/6] net/i40e/base: change ppp to ddp Beilei Xing
2017-03-30 14:06 ` Ferruh Yigit
2017-03-30 2:51 ` [dpdk-dev] [PATCH v8 2/6] net/i40e: add dynamic device personalization processing Beilei Xing
2017-03-30 14:06 ` Ferruh Yigit
2017-03-30 14:08 ` Ferruh Yigit
2017-03-30 2:51 ` [dpdk-dev] [PATCH v8 3/6] app/testpmd: add command for loading ddp Beilei Xing
2017-03-30 2:51 ` [dpdk-dev] [PATCH v8 4/6] net/i40e: add get all loaded profiles Beilei Xing
2017-03-30 2:51 ` [dpdk-dev] [PATCH v8 5/6] app/testpmd: add command for getting " Beilei Xing
2017-03-30 14:07 ` Ferruh Yigit
2017-03-30 2:51 ` [dpdk-dev] [PATCH v8 6/6] doc: add dynamic device personalization support for i40e Beilei Xing
2017-03-30 6:18 ` [dpdk-dev] [PATCH v8 0/6] dynamic device personalization support Wu, Jingjing
2017-03-30 14:05 ` Ferruh Yigit
2017-03-03 7:52 ` [dpdk-dev] [PATCH 0/6] net/i40e: support pipeline personalization profile Xing, Beilei
2017-03-03 7:26 ` [dpdk-dev] [PATCH 1/6] net/i40e: fix a typo in flow Beilei Xing
2017-03-03 7:26 ` [dpdk-dev] [PATCH 2/6] net/i40e: support pipeline personalization profile Beilei Xing
2017-03-03 7:26 ` [dpdk-dev] [PATCH 3/6] net/i40e: add ppp processing Beilei Xing
2017-03-03 7:26 ` [dpdk-dev] [PATCH 4/6] app/testpmd: add command for writing personalization profile Beilei Xing
2017-03-03 7:26 ` [dpdk-dev] [PATCH 5/6] net/i40e: add get all loaded profiles Beilei Xing
2017-03-03 7:26 ` [dpdk-dev] [PATCH 6/6] app/testpmd: add command for getting " Beilei Xing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303094103.GA189196@bricha3-MOBL3.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).