From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id E80AA3DC for ; Fri, 3 Mar 2017 10:41:07 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2017 01:41:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,236,1484035200"; d="scan'208";a="55413022" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.61]) by orsmga002.jf.intel.com with SMTP; 03 Mar 2017 01:41:04 -0800 Received: by (sSMTP sendmail emulation); Fri, 03 Mar 2017 09:41:03 +0000 Date: Fri, 3 Mar 2017 09:41:03 +0000 From: Bruce Richardson To: Beilei Xing Cc: jingjing.wu@intel.com, helin.zhang@intel.com, dev@dpdk.org Message-ID: <20170303094103.GA189196@bricha3-MOBL3.ger.corp.intel.com> References: <1488525977-15321-1-git-send-email-beilei.xing@intel.com> <1488525977-15321-3-git-send-email-beilei.xing@intel.com> <20170303093926.GB188460@bricha3-MOBL3.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170303093926.GB188460@bricha3-MOBL3.ger.corp.intel.com> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Re: [dpdk-dev] [PATCH] ppp implemantation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2017 09:41:08 -0000 On Fri, Mar 03, 2017 at 09:39:26AM +0000, Bruce Richardson wrote: > Given that this patch is not about point-to-point protocol, i.e. the > best-known expansion of "PPP", I think you need to clarify the acronym > in the commit message, at minimum, if not also in the commit title. > > /Bruce > Never mind, I see your updated patchset has already been sent with better titles. /Bruce > On Fri, Mar 03, 2017 at 03:26:07PM +0800, Beilei Xing wrote: > > Signed-off-by: Beilei Xing > > --- > > app/test-pmd/cmdline.c | 57 ++++++++ > > app/test-pmd/config.c | 62 +++++++++ > > app/test-pmd/testpmd.h | 3 + > > drivers/net/i40e/base/i40e_adminq_cmd.h | 32 +++++ > > drivers/net/i40e/base/i40e_common.c | 236 +++++++++++++++++++++++++++++++- > > drivers/net/i40e/base/i40e_prototype.h | 17 +++ > > drivers/net/i40e/base/i40e_type.h | 79 +++++++++++ > > drivers/net/i40e/i40e_ethdev.c | 68 +++++++++ > > drivers/net/i40e/rte_pmd_i40e.h | 1 + > > 9 files changed, 554 insertions(+), 1 deletion(-) > >