From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D35AA36E for ; Wed, 8 Mar 2017 06:10:39 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2017 21:10:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,262,1486454400"; d="scan'208";a="72913397" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga005.jf.intel.com with ESMTP; 07 Mar 2017 21:10:37 -0800 Date: Wed, 8 Mar 2017 13:09:13 +0800 From: Yuanhan Liu To: Yong Wang Cc: john.mcnamara@intel.com, dev@dpdk.org Message-ID: <20170308050913.GA18844@yliu-dev.sh.intel.com> References: <1488950271-28524-1-git-send-email-wang.yong19@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488950271-28524-1-git-send-email-wang.yong19@zte.com.cn> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2] doc: fix parameter of virtio_user for container X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2017 05:10:40 -0000 On Wed, Mar 08, 2017 at 12:17:51AM -0500, Yong Wang wrote: > Update the "Virtio_user for Container Networking" doc, add the > "--file-prefix" option to testpmd in host and container to avoid > hugepage config file conflict. > > Fixes: 50665deebda0 ("doc: add guide to use virtio-user for container networking") > > --- The three-dashes denotes the end of the commit log. Anything below it (including your Signed-off-by) will be discarded while apply. That said, you should put the change log under the "---" after your SoB. Besides, if someone gave you Acked-by, Reviewed-by or Tested-by and you were requested to make some minor changes, you could carry the tag for later versions. Which means, you could (and should) add both my and John's Acked-by after your SoB for v3. --yliu > v2: > * Modify the fixline from two lines to one line. > * Remove the unnecessary "_" in "--file-prefix" option. > > Signed-off-by: Yong Wang > --- > doc/guides/howto/virtio_user_for_container_networking.rst | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-)