* [dpdk-dev] [PATCH] net/mlx5: fix TSO TCP checksum flag
@ 2017-03-07 11:47 Shahaf Shuler
2017-03-09 7:17 ` Nélio Laranjeiro
0 siblings, 1 reply; 3+ messages in thread
From: Shahaf Shuler @ 2017-03-07 11:47 UTC (permalink / raw)
To: nelio.laranjeiro, adrien.mazarguil; +Cc: dev, stable
Since PKT_TX_TCP_SEG implies PKT_TX_TCP_CKSUM, the PMD must force this
flag.
The fix applied for both tunneled and non-tunneled packets.
Fixes: 19c5dc66b851 ("net/mlx5: add hardware TSO support")
Fixes: 751f56489e31 ("net/mlx5: add hardware TSO support for VXLAN and GRE")
Cc: stable@dpdk.org
Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
---
drivers/net/mlx5/mlx5_rxtx.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
index 405836c..2d33f2d 100644
--- a/drivers/net/mlx5/mlx5_rxtx.c
+++ b/drivers/net/mlx5/mlx5_rxtx.c
@@ -499,6 +499,9 @@
if (is_tunneled && txq->tunnel_en) {
tso_header_sz += buf->outer_l2_len +
buf->outer_l3_len;
+ cs_flags |= MLX5_ETH_WQE_L4_INNER_CSUM;
+ } else {
+ cs_flags |= MLX5_ETH_WQE_L4_CSUM;
}
if (unlikely(tso_header_sz >
MLX5_MAX_TSO_HEADER))
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix TSO TCP checksum flag
2017-03-07 11:47 [dpdk-dev] [PATCH] net/mlx5: fix TSO TCP checksum flag Shahaf Shuler
@ 2017-03-09 7:17 ` Nélio Laranjeiro
2017-03-09 16:07 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Nélio Laranjeiro @ 2017-03-09 7:17 UTC (permalink / raw)
To: Shahaf Shuler; +Cc: adrien.mazarguil, dev, stable
On Tue, Mar 07, 2017 at 01:47:51PM +0200, Shahaf Shuler wrote:
> Since PKT_TX_TCP_SEG implies PKT_TX_TCP_CKSUM, the PMD must force this
> flag.
> The fix applied for both tunneled and non-tunneled packets.
>
> Fixes: 19c5dc66b851 ("net/mlx5: add hardware TSO support")
> Fixes: 751f56489e31 ("net/mlx5: add hardware TSO support for VXLAN and GRE")
> Cc: stable@dpdk.org
>
> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_rxtx.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c
> index 405836c..2d33f2d 100644
> --- a/drivers/net/mlx5/mlx5_rxtx.c
> +++ b/drivers/net/mlx5/mlx5_rxtx.c
> @@ -499,6 +499,9 @@
> if (is_tunneled && txq->tunnel_en) {
> tso_header_sz += buf->outer_l2_len +
> buf->outer_l3_len;
> + cs_flags |= MLX5_ETH_WQE_L4_INNER_CSUM;
> + } else {
> + cs_flags |= MLX5_ETH_WQE_L4_CSUM;
> }
> if (unlikely(tso_header_sz >
> MLX5_MAX_TSO_HEADER))
> --
> 1.8.3.1
>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix TSO TCP checksum flag
2017-03-09 7:17 ` Nélio Laranjeiro
@ 2017-03-09 16:07 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2017-03-09 16:07 UTC (permalink / raw)
To: Nélio Laranjeiro, Shahaf Shuler; +Cc: adrien.mazarguil, dev, stable
On 3/9/2017 7:17 AM, Nélio Laranjeiro wrote:
> On Tue, Mar 07, 2017 at 01:47:51PM +0200, Shahaf Shuler wrote:
>> Since PKT_TX_TCP_SEG implies PKT_TX_TCP_CKSUM, the PMD must force this
>> flag.
>> The fix applied for both tunneled and non-tunneled packets.
>>
>> Fixes: 19c5dc66b851 ("net/mlx5: add hardware TSO support")
>> Fixes: 751f56489e31 ("net/mlx5: add hardware TSO support for VXLAN and GRE")
>>
>> Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
> Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-09 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-07 11:47 [dpdk-dev] [PATCH] net/mlx5: fix TSO TCP checksum flag Shahaf Shuler
2017-03-09 7:17 ` Nélio Laranjeiro
2017-03-09 16:07 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).