From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 533D3D018 for ; Thu, 9 Mar 2017 08:18:05 +0100 (CET) Received: by mail-wm0-f46.google.com with SMTP id t189so48453993wmt.1 for ; Wed, 08 Mar 2017 23:18:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ElvCTI0r0SIN3B6FxqGGxZV1aHAGBOsA/UalWn/hrXM=; b=BXUuU6Efaqfafa1nTRvcYnTLCq1VHyBCq/IkucxazIdchf5zczgVX/ozeSH7jGrhvB KMVDMtPFAvZ29gU+XG04esLpMOe4PAiBwuPks6lz77V8kVs1wp9cNeeXfFpEK87zeYHM Wqp3+Z/zGzqI2NOxW+5StSHVVcVjQAxluO4loXLyCoEQnYWYlQ1Bir5sYdwnV/yFTgqp kMqDeGgdkoPyQN4Tbp1GSC/DoexqIyZ4b4ww6mgpyGyqaT4hqoNjT0IvwlCIKUAWr/R7 qvSpxyqZedpMLAb8xJ5KwxHtvBDoWTYmS5PFKz69O0OlX/nTz5Ivvql+Udw/+RpmnZ71 QM6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ElvCTI0r0SIN3B6FxqGGxZV1aHAGBOsA/UalWn/hrXM=; b=UWOFO55J6KF8kn1qNFAlo8RpBjum4yBTPJAnEGVkwdXtgeHybdlNngQSZO2vXZa38d CY5exxQvc/NQBd3RJXfJp9EWzoLM+sK96N5k0ndMCGnc8FeQo4AVI1hrV9xtJoHL/08o wEt1/DAFlzo3rJ64hGXugwxwe31lpEgD5wZU6ORTobWRex1Z0G+7Bw5qxYlJ+RpWtv9B 98JX5G1/hjFE1jdlyozxpswtthK5NsRLhl5IKqulcztN78N5O3pFAqvTtJmfP6pMsQI3 2TocU1O5qnVZyrp43yxVCMcOX2pMLXep8b6xfyTU96xC5yo1Vc+rssuBVCAejzNolZtu n49g== X-Gm-Message-State: AMke39mzO4ny1zsam7PTybVK8sSWB5aM5y/Ru18PV20iCAMME3dHHnzVko0TSX25uWThbnL6 X-Received: by 10.28.139.134 with SMTP id n128mr14886091wmd.132.1489043884795; Wed, 08 Mar 2017 23:18:04 -0800 (PST) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id i203sm7628131wmf.12.2017.03.08.23.18.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Mar 2017 23:18:04 -0800 (PST) Date: Thu, 9 Mar 2017 08:17:56 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Shahaf Shuler Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20170309071756.GQ22756@autoinstall.dev.6wind.com> References: <1488887271-34342-1-git-send-email-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1488887271-34342-1-git-send-email-shahafs@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix TSO TCP checksum flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 07:18:05 -0000 On Tue, Mar 07, 2017 at 01:47:51PM +0200, Shahaf Shuler wrote: > Since PKT_TX_TCP_SEG implies PKT_TX_TCP_CKSUM, the PMD must force this > flag. > The fix applied for both tunneled and non-tunneled packets. > > Fixes: 19c5dc66b851 ("net/mlx5: add hardware TSO support") > Fixes: 751f56489e31 ("net/mlx5: add hardware TSO support for VXLAN and GRE") > Cc: stable@dpdk.org > > Signed-off-by: Shahaf Shuler > --- > drivers/net/mlx5/mlx5_rxtx.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 405836c..2d33f2d 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -499,6 +499,9 @@ > if (is_tunneled && txq->tunnel_en) { > tso_header_sz += buf->outer_l2_len + > buf->outer_l3_len; > + cs_flags |= MLX5_ETH_WQE_L4_INNER_CSUM; > + } else { > + cs_flags |= MLX5_ETH_WQE_L4_CSUM; > } > if (unlikely(tso_header_sz > > MLX5_MAX_TSO_HEADER)) > -- > 1.8.3.1 > Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND