From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 612912C01 for ; Fri, 10 Mar 2017 10:39:38 +0100 (CET) Received: by mail-wr0-f171.google.com with SMTP id u108so61151560wrb.3 for ; Fri, 10 Mar 2017 01:39:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=93bORJRhcjVGhCQ7mJtjFPeca4BhOpLGRLK13Qd49zk=; b=yGgDoxcUN++5hXeUbKzDFi/brnKa46li/F2gBu61Y/+ykvkg6bQMuSq84OeYybPjzk MNj0770nAtj8Wi1rCSuQgFg5eXYgLdVV9LaTFUnAEcahJv1eVoGEbGYpSshsSFu9xkgp /zqR0T0hRE+W+VnDdx+4wHEr1jkjDk3uyTXDdrJpAH0yXYOydzSIL0zuh2rIaie+mETO ZyFc8vj78gafeWw2iD451H8zWxppIbnLRgmenCwYj7/dKWjMaUYU1b5jstEX9rUh+h7L 0r5JKag/xqwE/rT97xN8Gp/3y4gWdw9Ydt4C4KDacR+ptTh9hqUAJk9/ECsCwdQaAzoi kOfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=93bORJRhcjVGhCQ7mJtjFPeca4BhOpLGRLK13Qd49zk=; b=RYpMI9bGJiQwgLxr/i7dtp8iCsmhXi5pvQW56YNVNiqLuW4Hhc5DarnE/N3R17QOAP fPiwCYG3ZlnXjPO3CHPruVhhg/4VRWIP/c9RE4NJ7X+9EUaOyTBNFN3gm06Y8Y1WFjr9 0kKnTPF9JToYmzxjA/PZGd3DFF28Pfh3X+jPWiVuIFMenD4y2omlYqq1uV2IZRRlogcL BydnviPfkoXp2CF8ZVfwPYGdqTzF2ovFwEZxmMEljisDW6yG5dMAwQn8e7BH1hfRes0C wZS4Sq0pkS2nRoFQ+0nMIIP7wVAz143AvwbENH0Q+XyJG1Pmi/bjoNOaFwcgM5cERTOi abkA== X-Gm-Message-State: AMke39l+Sx1X6ax2A8ZyaiLPk/uecQ6r6RCvm8maO7eiORIQAD8GYCfyy5oayehWbDr4JBLL X-Received: by 10.223.172.137 with SMTP id o9mr15993454wrc.66.1489138778181; Fri, 10 Mar 2017 01:39:38 -0800 (PST) Received: from paques.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g23sm2481274wme.8.2017.03.10.01.39.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Mar 2017 01:39:37 -0800 (PST) Date: Fri, 10 Mar 2017 10:39:01 +0100 From: Pascal Mazon To: Ferruh Yigit Cc: keith.wiles@intel.com, dev@dpdk.org Message-ID: <20170310103901.7ae693ff@paques.dev.6wind.com> In-Reply-To: <990c6cd5-9767-3dd4-b499-295eb8b4c8fa@intel.com> References: <990c6cd5-9767-3dd4-b499-295eb8b4c8fa@intel.com> Organization: 6WIND X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 3/4] net/tap: add netlink back-end for flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Mar 2017 09:39:38 -0000 On Thu, 9 Mar 2017 15:29:01 +0000 Ferruh Yigit wrote: > On 3/7/2017 4:35 PM, Pascal Mazon wrote: > > Each kernel netdevice may have queueing disciplines set for it, > > which determine how to handle the packet (mostly on egress). That's > > part of the TC (Traffic Control) mechanism. > > This is nice. > qdisc is egress part of the network stack right, is there any ingress > part of it? > qdisc is mainly for egress (can range from 0 to fffe), but there is one qdisc for ingress (ffff). > > > > Through TC, it is possible to set filter rules that match specific > > packets, and act according to what is in the rule. This is a perfect > > candidate to implement the flow API for the tap PMD, as it has an > > associated kernel netdevice automatically. > > > > Each flow API rule will be translated into its TC counterpart. > > What can be use cases here? Well, it can be any case with rte_flow. Such as directing incoming packets to specific queues for the application, dropping them, and any kind of filtering (along those supported, see later patch). > > > > > To leverage TC, it is necessary to communicate with the kernel using > > netlink. This patch introduces a library to help that communication. > > > > What do you think implementing these out of tap PMD? These can be used > by KNI too. > Well, I don't know about KNI, but I think setting it in tap PMD, which is the current sole user for this, is a good start. It will always be time later to make it more generic for other uses. Regards, Pascal > > Inside netlink.c, functions are generic for any netlink messaging. > > Inside tcmsgs.c, functions are specific to deal with TC rules. > > > > Signed-off-by: Pascal Mazon > > Acked-by: Olga Shern > <...>