From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id B41B7CF62 for ; Tue, 14 Mar 2017 09:14:59 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id t189so57368692wmt.1 for ; Tue, 14 Mar 2017 01:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lKLk0nd62PuG0bjpIKAF4ErVlSrhb3Ck+WFMB0zIUiw=; b=Qzw72AaQ9DQYi9FPsi0XFk1TtIcCsAh8yGom9l0UwLqYiV2g8w/Ch2pA2yRzVqXmjg YBCLVFW5H/SlN10F3r0eXByuUizVxnDEammQ0tOGSOcK47YV1vhsT842ozwyBih6TV0C LhAGWnjicnqqM9AfUqonFkWOjz5iBxteeqrhxdtFkephCaPypyryxukbj+gYS+ISwAgE KE56Oca4EqKVNmfct2GFrnO7FbFsrs7jDspbqNwoLz4gDd/YuQQMS+5YjsL3tz8He/s8 jMTCYpiENkzRFTVSq8Rgh1jR7Pktg/+bSubgPQHdUE9ziMcIk8Of5rCzK945/GTVq7xj 4sRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lKLk0nd62PuG0bjpIKAF4ErVlSrhb3Ck+WFMB0zIUiw=; b=byz90yNNyyQuOBeMfFS8YDjzU+JMBPlC7iY8HKTtux8/zJISnepSvf4cwomJlIZw51 Is35LAzCHS2PNrpxnBXAx5x1jMP0nw981xGvhvFvYF2hGloOMA9h11oZx/55c4dvm8DB H7urbzDNHjdkv2iGr66a1XJ6slkWu5mq3OF4IRTNoffOf0g58JSb/eZ7jVEALBfEtMbZ t7yXKZnKLjIZ6tCqBuYpkpSszMjuxc4s7O3moSxI3OfIcGQQEgl0Kit9HETurLrLKGGG GkQLxu9eqbraloFO9dZyZ6zKau8ccL1HbKUOU2UQ5UkBzWnFLFVIdT1mr6d95Zhppwx+ d2Ww== X-Gm-Message-State: AFeK/H0a1XpTTC2HM6TR5WpX6WDI4/BAcDXsrbkHIpHsVpFobzY0Ro73UwnYPqeSKHVtWhYM X-Received: by 10.28.100.196 with SMTP id y187mr13493991wmb.129.1489479299080; Tue, 14 Mar 2017 01:14:59 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id 63sm28157082wrh.68.2017.03.14.01.14.58 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Mar 2017 01:14:58 -0700 (PDT) Date: Tue, 14 Mar 2017 09:14:56 +0100 From: Olivier Matz To: Hemant Agrawal Cc: Thomas Monjalon , , , , , , Message-ID: <20170314091456.2625022d@platinum> In-Reply-To: <43323e28-d28f-bbce-2b32-5a7e29190529@nxp.com> References: <1487205586-6785-1-git-send-email-hemant.agrawal@nxp.com> <20170308100553.14ca39a7@glumotte.dev.6wind.com> <521bf2d1-0393-c4ac-422e-96134880502a@nxp.com> <3284470.c3gGJi30Hp@xps13> <92fa2a03-373d-4904-0539-68e2322c14fa@nxp.com> <43323e28-d28f-bbce-2b32-5a7e29190529@nxp.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCHv8 19/46] pool/dpaa2: add DPAA2 hardware offloaded mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 08:14:59 -0000 Hi Hemant, On Tue, 14 Mar 2017 12:12:17 +0530, Hemant Agrawal wrote: > On 3/9/2017 11:27 AM, Hemant Agrawal wrote: > > On 3/8/2017 9:09 PM, Thomas Monjalon wrote: > >> 2017-03-08 18:22, Hemant Agrawal: > >>>> On Fri, 3 Mar 2017 18:16:36 +0530, Hemant Agrawal > >>>> wrote: > >>>> I think the current mempool handlers should be moved first in a > >>>> separate patch. > >> > >> Yes it should have been done earlier. > >> > >>> Are you seeing any benefit by making it a separate patch series? > >> > >> A separate patchset for moving mempool handlers will be easy to review > >> and accept. > >> If integrated in this series, it is kind of hidden and prevent the > >> visibility and review it deserves. > >> By the way the mempool move should be directly committed in the main > >> repository, while this series targets next-net. > >> > > > > hw mempool has dependency on mc-bus. So, we will break it into *5* series, > > > > 1. mc-bus - which can go on main repo - Rebased over main repo > > 2. dpaa2-pool - it can also go on main rep (depends on mc-bus) - Rebased > > over 'main repo + 1'. > > 3. dpaa2-pmd - this depends on mc-bus and dpaa2-pool > > A. mc-bus -another series rebased over net-next > > B. dpaa2-pool - another series rebased over 'net-next + A' > > C. the pmd itself rebased over 'net-next + A + B' > > > > Are you sure, you will like us to do the above and flood the mailing > > list :) > > > > I think, this will make the review difficult. > > > > Bruce, Ferruh, Olivier - does the above help you? If so, we can do it. > > Any views, we can rebase our next version accordingly. > we are looking forward to get it merged in 17.05. Yes, moving the other mempool drivers in the drivers/ directory before adding another one there makes sense to me, in order to avoid having two places for mempool handlers. As Thomas stated, it's probably better to have it in another patchset, so it can be quickly reviewed and integrated. Regards, Olivier