From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id BBAEBD0B2 for ; Tue, 14 Mar 2017 09:59:10 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id t189so58200329wmt.1 for ; Tue, 14 Mar 2017 01:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BYsngq9iH21weOU+RwkjqvOwwaCFVGQ5xZ93pxiU6RA=; b=b5LTg04CPUWRgL+S+3VXl0G9M+NOJ42ifQxqy47e+2KB/+xID0s3vY0tqcLCf+/GLs 53hmuwXgatqN7G+jwqHJ7oVON77gxXrgJjgJBB9ZRShzzG1wiRPhO+5AoUQvSbGvf4E/ g+V1PC08+W9n414iCyPb+bAZ85WPdnQlmUX3tXRtYJuIaJ9uaTeYydaMHp9j0+phlXmI zs+ZHqxdwh4+3j9+GFWsA4iWJIPoGYPMHBG2ywR3IyU2pWy9uVX59TTgnRC4lK2ei5AA pdi01uH+Za2WM7sF5UxI2FdosOw495SE6+dohAajMrgPbN7LKaN85rt9zub2pnZB5CxD wsIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BYsngq9iH21weOU+RwkjqvOwwaCFVGQ5xZ93pxiU6RA=; b=aRgWOXHERkYm+ORKjzfNq/+TJFZz3PRRfUSKzApWWLrvtpX1t+cPLUr1jSYL3ieOyN rxiQrc4oDTzpniUOv9JFRy64no6NBBbJ9wIj3i13g7dEWccZSaKFgzar0B94Q+heT4Ph nJEY0O3AhG2DnGOGYu1X1HCSGIbgbPAl0SJ56N+P4JECfjPmKTy4yFpd3pznlFSM/hP9 cRoU4bjo7hZDH7l5SfpsBgHlmDiKcKsbcNWUlcLrQ/kE4SBk5upj9GGPHb/nwTgjDLDa QdMahEr2FElZppxGXlcsGiMNMza/svw5dWGLTKxZXfWBIrzx0XutrpXrOfNq4gl6wMCE Scbg== X-Gm-Message-State: AFeK/H1xyVbKFkiWamgPLrwqDW8TzDmoNBafMZAeAfx0ThatzJ4EtSYzerhmGVkS5blc6Y3b X-Received: by 10.28.62.204 with SMTP id l195mr12944757wma.88.1489481947396; Tue, 14 Mar 2017 01:59:07 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id k76sm28201327wrc.12.2017.03.14.01.59.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 Mar 2017 01:59:06 -0700 (PDT) Date: Tue, 14 Mar 2017 09:59:04 +0100 From: Olivier Matz To: Bruce Richardson Cc: jerin.jacob@caviumnetworks.com, dev@dpdk.org Message-ID: <20170314095904.63ab7bb9@platinum> In-Reply-To: <20170307113217.11077-1-bruce.richardson@intel.com> References: <20170223172407.27664-1-bruce.richardson@intel.com> <20170307113217.11077-1-bruce.richardson@intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 00/14] refactor and cleanup of rte_ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Mar 2017 08:59:10 -0000 On Tue, 7 Mar 2017 11:32:03 +0000, Bruce Richardson wrote: > NOTE: this set depends on the v2 cleanup set sent previously. > http://dpdk.org/ml/archives/dev/2017-February/thread.html#58200 > > This patchset make a set of, sometimes non-backward compatible, cleanup > changes to the rte_ring code in order to improve it. The resulting code is > shorter, since the existing functions are restructured to reduce code > duplication, as well as being more consistent in behaviour. The specific > changes made are explained in each patch which makes that change. > > Changes in V2: > * Eliminated extra cacheline padding where cachelines are 128B > * Renamed rte_ring_ht_ptr struct to rte_ring_headtail > * Removed missed references to ring watermarks in test code and docs > > This patchset is largely the same as that posted previously on-list as > an RFC: > http://dpdk.org/ml/archives/dev/2017-February/thread.html#56982 > > Changes in V1 from RFC: > * Included release notes updates as changes are made in each patch > * Fixed some missed comment updates when changing the code > * Separated some initial fixup patches from this set to send separately > * Dropped the final two patches for an rte_event_ring, as not relevant > for this set. That can be done as a separate set later. > * The macros for copying the pointers have an extra parameter added, > indicating the start of the ring buffer itself. This allows more > flexibility for reusing them in other ring implementations. > > Bruce Richardson (14): > ring: remove split cacheline build setting > ring: create common structure for prod and cons metadata > ring: eliminate duplication of size and mask fields > ring: remove debug setting > ring: remove the yield when waiting for tail update > ring: remove watermark support > ring: make bulk and burst fn return vals consistent > ring: allow enqueue fns to return free space value > ring: allow dequeue fns to return remaining entry count > examples/quota_watermark: use ring space for watermarks > ring: reduce scope of local variables > ring: separate out head index manipulation for enq/deq > ring: create common function for updating tail idx > ring: make ring struct and enq/deq macros type agnostic > > app/pdump/main.c | 2 +- > config/common_base | 3 - > doc/guides/prog_guide/env_abstraction_layer.rst | 5 - > doc/guides/prog_guide/ring_lib.rst | 15 - > doc/guides/rel_notes/release_17_05.rst | 32 + > doc/guides/sample_app_ug/server_node_efd.rst | 2 +- > drivers/crypto/null/null_crypto_pmd.c | 2 +- > drivers/net/bonding/rte_eth_bond_pmd.c | 3 +- > drivers/net/ring/rte_eth_ring.c | 4 +- > examples/distributor/main.c | 5 +- > examples/load_balancer/runtime.c | 34 +- > .../client_server_mp/mp_client/client.c | 9 +- > .../client_server_mp/mp_server/main.c | 2 +- > examples/packet_ordering/main.c | 13 +- > examples/qos_sched/app_thread.c | 14 +- > examples/quota_watermark/qw/init.c | 5 +- > examples/quota_watermark/qw/main.c | 21 +- > examples/quota_watermark/qw/main.h | 1 + > examples/quota_watermark/qwctl/commands.c | 4 +- > examples/quota_watermark/qwctl/qwctl.c | 2 + > examples/quota_watermark/qwctl/qwctl.h | 1 + > examples/server_node_efd/node/node.c | 2 +- > examples/server_node_efd/server/main.c | 2 +- > lib/librte_hash/rte_cuckoo_hash.c | 5 +- > lib/librte_mempool/rte_mempool_ring.c | 12 +- > lib/librte_pdump/rte_pdump.c | 2 +- > lib/librte_port/rte_port_frag.c | 3 +- > lib/librte_port/rte_port_ras.c | 2 +- > lib/librte_port/rte_port_ring.c | 34 +- > lib/librte_ring/rte_ring.c | 76 +-- > lib/librte_ring/rte_ring.h | 760 ++++++++------------- > test/test-pipeline/pipeline_hash.c | 5 +- > test/test-pipeline/runtime.c | 19 +- > test/test/autotest_test_funcs.py | 7 - > test/test/commands.c | 52 -- > test/test/test_link_bonding_mode4.c | 6 +- > test/test/test_pmd_ring_perf.c | 12 +- > test/test/test_ring.c | 704 +++---------------- > test/test/test_ring_perf.c | 36 +- > test/test/test_table_acl.c | 2 +- > test/test/test_table_pipeline.c | 2 +- > test/test/test_table_ports.c | 12 +- > test/test/virtual_pmd.c | 8 +- > 43 files changed, 554 insertions(+), 1388 deletions(-) > Series Acked-by: Olivier Matz Thanks!