From: "Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: ferruh.yigit@intel.com, dev@dpdk.org, adrien.mazarguil@6wind.com
Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: add enhanced multi-packet send for ConnectX-5
Date: Wed, 15 Mar 2017 11:44:23 +0100 [thread overview]
Message-ID: <20170315104423.GD22756@autoinstall.dev.6wind.com> (raw)
In-Reply-To: <20170315103907.GC22756@autoinstall.dev.6wind.com>
On Wed, Mar 15, 2017 at 11:39:07AM +0100, Nélio Laranjeiro wrote:
> Hi Yongseok,
>
> I did not see this v2, in the future please use the "in-reply-to" in
> addition of the --thread option.
>
> Please see the comments below,
>
>[...]
> >
> > @@ -292,7 +298,11 @@ mlx5_args_check(const char *key, const char *val, void *opaque)
> > } else if (strcmp(MLX5_TXQS_MIN_INLINE, key) == 0) {
> > priv->txqs_inline = tmp;
> > } else if (strcmp(MLX5_TXQ_MPW_EN, key) == 0) {
> > - priv->mps &= !!tmp; /* Enable MPW only if HW supports */
> > + priv->mps = !!tmp ? priv->mps : MLX5_MPW_DISABLED;
> > + } else if (strcmp(MLX5_TXQ_MPW_HDR_DSEG_EN, key) == 0) {
> > + priv->mpw_hdr_dseg = !!tmp;
> > + } else if (strcmp(MLX5_TXQ_MAX_INLINE_LEN, key) == 0) {
> > + priv->txq_max_inline_len = tmp;
> > } else if (strcmp(MLX5_TSO, key) == 0) {
>
> Is it really necessary to let the ConnectX-5 behave in the non enhanced
> feature?
>[...]
Sorry I did not read correctly. Forget this remark.
Thanks,
--
Nélio Laranjeiro
6WIND
next prev parent reply other threads:[~2017-03-15 10:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 23:13 [dpdk-dev] [PATCH v2 0/2] " Yongseok Koh
2017-03-10 23:13 ` [dpdk-dev] [PATCH v2 1/2] " Yongseok Koh
2017-03-15 7:28 ` Shahaf Shuler
2017-03-15 10:39 ` Nélio Laranjeiro
2017-03-15 10:44 ` Nélio Laranjeiro [this message]
2017-03-15 14:28 ` Ferruh Yigit
2017-03-10 23:13 ` [dpdk-dev] [PATCH v2 2/2] doc: update PMD options for mlx5 Yongseok Koh
2017-03-15 7:30 ` Shahaf Shuler
2017-03-15 23:55 ` [dpdk-dev] [PATCH v3 0/2] net/mlx5: add enhanced multi-packet send for ConnectX-5 Yongseok Koh
2017-03-15 23:55 ` [dpdk-dev] [PATCH v3 1/2] " Yongseok Koh
2017-03-15 23:55 ` [dpdk-dev] [PATCH v3 2/2] doc: update PMD options for mlx5 Yongseok Koh
2017-03-16 0:01 ` [dpdk-dev] [PATCH v3 0/2] net/mlx5: add enhanced multi-packet send for ConnectX-5 Yongseok Koh
2017-03-16 13:47 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170315104423.GD22756@autoinstall.dev.6wind.com \
--to=nelio.laranjeiro@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).