From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 524A428F3 for ; Wed, 15 Mar 2017 11:44:32 +0100 (CET) Received: by mail-wr0-f171.google.com with SMTP id l37so8123411wrc.1 for ; Wed, 15 Mar 2017 03:44:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=xQOwqGt/6ES3OqJ5wdYqhm0cPnIRGkeOM2zJ20ESsEA=; b=oLNHlOLFaxNossp3SKaxesUp1hNXoJxPeXTPob93bTQa4uGpexRM12VTkYAY2VlG/Y OTK3lzqOR4fjp+bVKZE7zqiAzuqaMS0C9v8uoYUcTfmuU+17tryD5oqlH1iE1suprDsB Ve73goFHLplXBJbxpl6Mqg3FMyHMWFpDceJ7Xan64hfKkpCwNkLxn/X/c/M5LjtuywV8 kIvNiN+C9Kbumrp3OqbPxq4D81GqbehQb18+65u9UKYnjc4bPbQQVcMitkcbU0BoNrpU PGChyIn0OqPYNjohVqWO7FnLIVAgSzazNUbEHvHf0nIn+ui9FHFj1ymT1JMz2Nk2IGmg nSag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=xQOwqGt/6ES3OqJ5wdYqhm0cPnIRGkeOM2zJ20ESsEA=; b=lxUZUQCMY7Y8S0QWT68WHkPLOleubOiRTNqqT40kTU9o6SJfPtgCcWcDRwXi5kxo92 KsuRg5mumEidnK5vYOp5d66h9Wj68fMrJfJeigECCR/sOno3Y5JtzCMSWABATMyYZjh1 4YRNcCSvyykUmFtR8nRkNcYXiNXymeDISzKRXycsYwbs2TmFrEoPxDF6Z6EcYB8IyTPl wOBdnz1HZyo4P0ao8qog4V5eTcB87aRtkVtZELr+Nky/Wlq3GgJBU6YZfm517MChhdrz yAGkygwE6zo1dOkZ9mcv8YczjhohyGcucFRCDwGYxHoGhCp8DBrkqnEt+l/g18ncCBhT flVg== X-Gm-Message-State: AFeK/H1iE53pbmp3KtW4i64kX+JkwFf4g75ksKmOMFagTMvz3z3ElmRhDJa9kVAgn2OJ3TvW X-Received: by 10.223.171.239 with SMTP id s102mr2277507wrc.23.1489574672061; Wed, 15 Mar 2017 03:44:32 -0700 (PDT) Received: from autoinstall.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q4sm1860085wrc.35.2017.03.15.03.44.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Mar 2017 03:44:31 -0700 (PDT) Date: Wed, 15 Mar 2017 11:44:23 +0100 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yongseok Koh Cc: ferruh.yigit@intel.com, dev@dpdk.org, adrien.mazarguil@6wind.com Message-ID: <20170315104423.GD22756@autoinstall.dev.6wind.com> References: <20170310231334.2457-1-yskoh@mellanox.com> <20170310231334.2457-2-yskoh@mellanox.com> <20170315103907.GC22756@autoinstall.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170315103907.GC22756@autoinstall.dev.6wind.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/mlx5: add enhanced multi-packet send for ConnectX-5 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2017 10:44:32 -0000 On Wed, Mar 15, 2017 at 11:39:07AM +0100, Nélio Laranjeiro wrote: > Hi Yongseok, > > I did not see this v2, in the future please use the "in-reply-to" in > addition of the --thread option. > > Please see the comments below, > >[...] > > > > @@ -292,7 +298,11 @@ mlx5_args_check(const char *key, const char *val, void *opaque) > > } else if (strcmp(MLX5_TXQS_MIN_INLINE, key) == 0) { > > priv->txqs_inline = tmp; > > } else if (strcmp(MLX5_TXQ_MPW_EN, key) == 0) { > > - priv->mps &= !!tmp; /* Enable MPW only if HW supports */ > > + priv->mps = !!tmp ? priv->mps : MLX5_MPW_DISABLED; > > + } else if (strcmp(MLX5_TXQ_MPW_HDR_DSEG_EN, key) == 0) { > > + priv->mpw_hdr_dseg = !!tmp; > > + } else if (strcmp(MLX5_TXQ_MAX_INLINE_LEN, key) == 0) { > > + priv->txq_max_inline_len = tmp; > > } else if (strcmp(MLX5_TSO, key) == 0) { > > Is it really necessary to let the ConnectX-5 behave in the non enhanced > feature? >[...] Sorry I did not read correctly. Forget this remark. Thanks, -- Nélio Laranjeiro 6WIND