From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0080.outbound.protection.outlook.com [104.47.38.80]) by dpdk.org (Postfix) with ESMTP id A26EB3B5 for ; Tue, 21 Mar 2017 13:53:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=xevK4MOX9uxpyQ2OfLCUsjN5EngN6I5kMgmeXDrrfSU=; b=jQ0R34j2ZErneQx7+j8iFICDB0JA+nScwhh97mAWihcX+/H5W9K5qIGxTrgNYSu01ecs5g9KMrf5oTN0MN8vuDRanc/C1tdfuVjGHeIc3RIjAnpNIYiABaPqrsDvdWiEz+6NK9g4Xm/n3zzORpIfcqpXl+WJyveMGiEpsK93wzQ= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (14.140.2.178) by BN4PR07MB2273.namprd07.prod.outlook.com (10.164.63.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Tue, 21 Mar 2017 12:53:42 +0000 Date: Tue, 21 Mar 2017 18:23:22 +0530 From: Shijith Thotton To: Ferruh Yigit Cc: dev@dpdk.org, Jerin Jacob , Derek Chickles , Venkat Koppula , Srisivasubramanian S , Mallesham Jatharakonda Message-ID: <20170321125321.GA13113@localhost.localdomain> References: <1487669225-30091-1-git-send-email-shijith.thotton@caviumnetworks.com> <1488454371-3342-1-git-send-email-shijith.thotton@caviumnetworks.com> <1488454371-3342-37-git-send-email-shijith.thotton@caviumnetworks.com> <9a8d31ce-8590-25f3-eab8-6a34e4a645a2@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9a8d31ce-8590-25f3-eab8-6a34e4a645a2@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: PN1PR01CA0068.INDPRD01.PROD.OUTLOOK.COM (10.164.136.168) To BN4PR07MB2273.namprd07.prod.outlook.com (10.164.63.155) X-MS-Office365-Filtering-Correlation-Id: 574a1d39-e2e0-4d89-b282-08d470595086 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN4PR07MB2273; X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2273; 3:YRcRO3GJWI/MDlsMa3Br/XrJGpQ2SnAxttcetd64tXWbgOc8ajb3kMuwJkZdRm3BiHYlLhTvUc5gK0G/rq2fVKHHPrmOINXhHrj2FDUPppTodmNT2Pm9xxiI5V0fnj8tncLgVu/loHzVJK5roaQ295drQb4TGsI/Z7Bga7q7/HSiWO/5jAD2WD1URoNmA5RXXHS+k13eeDsE8VqL5N7oilmlfE8HAzK2cP5mPDKt/vHgpUnKFyedMGHD2k7FJQUQfPdUn0mj7q+7GQd0wBQZUQ==; 25:e7+43BXAEJEQqtNULXieI2+W2MOKKo4+a6VF1f4IfdQMFMUyx5bpHXyDcE53EjCi48VexU4VYNS4imIwHTh0EMynWQpYLEEz2d45a96K6peBxB0EmFjDOcq9DU1COh8ikz00b/G+4VWJrL1nOYkczsiFACdzmdXV0mwL425lkEam5BqXQmPwv15lpXMY+TLOgJpY1sjlvk+HlospVr3soj3kwWJs1QogIsXH+C0WZe8pD3HsAu/sme00wZCVkEWHmKQcXREfjx+b7BJHUpZ45jRtPA/6c275IoHe8KWWNU9tuXmxmd6VBQvpq5HdGlARp1KndGBNQtti/cuTkihgW4KZxxG6uZvkkEjArdMNd+cZhfHcoAq1xj7vL4Pj+23v/gRCPiEfE7qARRIaEfkEG6ZfwW875r9i49AppkaD3IhLeukscGoSydFc2ukPGiqeCTPA+KiUuhhMXkOatUhHpQ== X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2273; 31:jg06sv2bxSKdlTQk/bQAhfRq8XRfniwq01AzQ7ePz2REq9lMfnry7l+msl07B/EQ/hzKqryb0vrnTr8sLl2trKVy+jg7yFHxcbK2ULRYgXvU0qSdFNUWP3dCw3EyAX+e1ade03AVyfyJYNJCSfswGrVZng510M0IcPc5IBsZzYGTJykkXfPJRpwVPqJJJef2JnqXaGy443me32vCKsq5hM78asp0khPretO4sygRkzZmMEqotPD75/IyoyF3BMce; 20:Gh3nqwTF+zd+jcNjbw4cQTrwu33FCvUfnggLOtz2ngzc/TYwUolkO65ZodgM+xNynXl7kXIEtFfCrBvwFUMu5xHcb+pY1xRK6zD//9z5SfML9ZfvXSlxwkV9sBVWh3Rjejpbu02p5j5m+WrAHykXl4eZOgWdQ679lBFIs7Et5R8OMPpkS5R2+PpX9OgMI8WpbsIJAKVE3GBVc6o1fHPWoBKjh5lV5EYF1tnyMhEQdjLOmDk3dUICbToZfzqeF/sbMOIX36QDBSRNKkctjrKn4UYprwEwC4BwF+L/SF0vxotizjWTrxdDgejJmI/Leyr2tOatLie9Cu/SWDB62Df7mb0rfgXv2BIKjfbbnctVpbi7bdJPr821BK4RTY5dDWPgsIV9y+AGxGh2LXwboDjYPpEeXaZSM6HsXZRrpPZDu+s8yj+hYj+sIr4U4Z8cGLhPeyjh2SDS60bE5GPmiixIF52QCDvr8ekCYu4QXSkAwZgNdM6g/7HKIHX0wkkbgeLoAIVHb8JAaTiMu+ffoNn4mc9oVnl6ZHCaBWYRPBIYZDh65E8+3QXRQ+LVGe67NdTJ1ZPww2G8r2k2pi7MtSRNrZRtj2QXrcQTjWv5PQCz0yc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123558025)(20161123562025)(20161123555025)(20161123560025)(20161123564025)(6072148); SRVR:BN4PR07MB2273; BCL:0; PCL:0; RULEID:; SRVR:BN4PR07MB2273; X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2273; 4:8RJvfK9NhXCL+k1bGWOKNgiFSEd5WjvBp4HF5miXCfOuQBazio6tUjmcpnkZsrOzxRa/XuSVkt6YS1A+aN695349O/qGtzDEsnAN7QTZZP7qs3gFi1fNz3aljJIJPG8Clw3lrJ8DLAaQADO70JcRcUa0AuRsMga2mhT0Z1OhA964YBr4PF172EVQwX+/jSylRZaoM8DhJHEzr+Eu6BmFn9ar/d1whw7xyA7hUaHVK75iPTBNbnqJdOMsSZoPd1qiKqOIrFR0cWCAVLGjinvTLqI1VPrYibuHDhiTrs5VH/4MR54C6oWqbFrW8T1OSaYPYEsbv5JN1HeuqA2cqGk/O5PQfIMHleiPgvmBe7JGINEULFzyRy6XoOmuNAt8Wcucub3f/W7kpY0ikH4Aa89keiofMRbIN4KMXNc9sAtjWllz8QnFaI6jl54VWpwBwD7eDB2X2EAK6xO93r+30oR+H1RrGLqZKYH/523yz9ScCBJ9R8cGiGYL3wgKxfMgrJmjNC2xjxl0Q35aH7mcFfGmAzG0CTcXxR66ExRVQ1Ler+GUzl8emE+eaVkYA0BWtyOIKcEwCStshMLKnF+4AXmSd5rEmBrUt/ROyxXEBz1wIGE= X-Forefront-PRVS: 02530BD3AA X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(39830400002)(39450400003)(39410400002)(24454002)(377454003)(199003)(189002)(5009440100003)(53936002)(229853002)(6506006)(33656002)(25786008)(9686003)(50466002)(5660300001)(76176999)(54356999)(6666003)(2950100002)(42882006)(55016002)(54906002)(6916009)(93886004)(42186005)(66066001)(50986999)(4001350100001)(81166006)(38730400002)(189998001)(47776003)(8676002)(53546009)(6246003)(110136004)(2906002)(305945005)(61506002)(1076002)(6116002)(3846002)(23726003)(4326008)(83506001)(7736002)(110426004)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:BN4PR07MB2273; H:localhost.localdomain; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN4PR07MB2273; 23:VawxYpgV1Ucp/Hhk1HkLoaYEstN8ux56X8tYoiIEL?= =?us-ascii?Q?e2YNv9OIPgOQbjxQTOJGoaHIb2IoBYCmyHbMHInq5qE9oJkavCwM5fQTmaDw?= =?us-ascii?Q?v+pUfH0SM/By0FMH6b5cyRW9D3bkEaZWr+YjvZ7DfLLA+5ELtgkdFOm/scGC?= =?us-ascii?Q?54CsOudVFg3xswXUe0J0TXFxq2N3qiSFXgRSwkEukP/q83JQSgFSZD20CWtZ?= =?us-ascii?Q?e8zhlgSY/L2tM3Y6FjLC+SZz4RDfOoZjxkKmeTvTVWBm+h5ZKly85NQwryPL?= =?us-ascii?Q?b6JnXmsIZ+IrcjFXOkgknEimh7Z4sgi/f5Imt8gLshV7oJs7aOG8xS09BqXO?= =?us-ascii?Q?jIyVuq05kUzVfB38khJv9NagyszSIRokSYu8jyhz6c4VXLweBsgNt789k0Sy?= =?us-ascii?Q?tPFH2BgUl4NOh9ddtR50iN2z74Om05mg7z+MNS+7cofDPcKSJfopS5u79TQZ?= =?us-ascii?Q?daZ9NNVVt4U2tTk2YwGKFl8ePcqBOp5wStVGYvQfJRQ4vZYkXkVvu2Cvt6dN?= =?us-ascii?Q?XYhI1O65C82Y8t/01dZtMyA60DMysi+Pvnp/O1Hf6FBih74j6YIwtTXk658y?= =?us-ascii?Q?2tS/2Ihi5Q/KJ3EeCEopgYxZH/XGOxu9bfvlHTfaX8lZ3MDB9xajHnSaWa9g?= =?us-ascii?Q?L+T9reSe7W3U7OW4wRWa5m5QQY6Xv5naZXz2aklxBWBvDb4+1mkzRho2CVkg?= =?us-ascii?Q?WCMsYeVp1ySPSBZNzSY7bzp04WOcQbPLMeLTYw9Iyql2yCJ5zp+WTxZrrFBK?= =?us-ascii?Q?bdlthdzsU/XIoO5xkHujZNgsiU3r/RWgChEu4Z1Iy6TrIJ8JlCaEUBF2MnMS?= =?us-ascii?Q?QjT+PxpMNZxSWNcfIm4OUe/vaeEdXLQmQx4tpe8hhcq6uDw+VYoO2MHrr1vW?= =?us-ascii?Q?dDH+mop/67ota/htJS5CdruEMg14TPa4pscOlIUb1I/STLHrKaLLNlc0FWvY?= =?us-ascii?Q?Q0cSA77Zbsg2gpghrZp69ojdYsBFc/r3mJCDEh7ppSukVeWaKkALNHzihF3u?= =?us-ascii?Q?mcQRDN1SYvls5elB7zm6dZk3fmPaL2zxVC7dXobP3L3Pql9qiKj56P3+JYc9?= =?us-ascii?Q?uQQl4QgnwxJ36Ksh2hYn2qpmduHExPsR2JWLdEyMwpIV+9qxOi9FJcARaW7q?= =?us-ascii?Q?kkOEK9ZUz9Xxc/RhfL0gyaj1YqcQZ0SoBcD4tgAGM1m4Pc1MzM4HacQ1J7oc?= =?us-ascii?Q?JsPY88zoCSZH5k8noOQD3mXKrjrEvZit3fGWPqQf7zDi4wD38uXf82rmsC7V?= =?us-ascii?Q?Ajp7x+w7YFjsPY5hA+s2csjEFZyqCHflLgeF82o?= X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2273; 6:ZBCTxJHsiSeePgA6NPKooL5TIQz85mIBw7DDlgnvpoQ6eOSwr/EeRNF9KTRg0wZFlc3fh3fW/JLdoVBoBALivMS6uNlmtX/U4HU1rr3bd0oBPkRL6TkVgCj7oEDspytEIfh0fa+dx/c+rg0bxDBDgaGJeRo7JPP//u39Q5+AeK9Irru40zv6tVji3+wahGKsqRBu7FKXAA3BaIlAmP2g+XtNr96unfFpDd25+sEu3GoakF33ZhpYdNBT9gpVpzviF/KjKRYeKWegWxd/xi7oX6VKvgQpHwbLMJfbpHNHOzPI8f7eqDa1uobZ4SZlp0isLLioQQzYOh9ECbCHBhZeE0x0e131bvGvf3WKg443J9x8yPjtsitOZSZUS9jjOUEp8XUGhw+d8BWqOVbdwKgL1Q==; 5:rmM//xQFAsHuUTa75TblLuRSEwmAGjiwg3J0R2j+aNlxIT+dASeOLBd3lUnQTy7gKWZmWC1JWRmUn66B2sfhkxEOhiIKSS3gkj6S6XAiFOscy2F4hAhw0fsyZBNA5rTcZWyxdPqBG6n4EwLvMYdfoA==; 24:z5G6e9vHZz6fXUUKbDe9VmabzZ0RoP+ihnWxSK+TRI12tJ2BTOXpXF8P+1ZKXN74N/KffwEt3e6nL33nchoaGVXulGxB8rygpjxYfgPgk18= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN4PR07MB2273; 7:wMXrcTetV3E3oQZVKRQUQBrqYxmsBDLt14aLDAcvD98HgwdnV82dxWH6XHnQPXQdzWrRucNGR2T7bgPtkFgBVTuNM0wDy7Mqw1uZUpbUfd/kLf3F/GoBjRWwEhijpKeCEr2dZmKmKTkB7hKRDwOdClO++SKCI+GHpnx+zOitOgv+cCYZZCEUsLk1JCeveb7dNxcok0WwyPnRch3xSWkIzc+0YhyPNmkZl7OAEdHG5BGTI8yYRvXGEOXdehn/5u/1ft16JT90PQlaPc9Kn9DMSpKYiJJh13i+Ipw6p6e9aN58FuZcZWcM69pxOzDJnTFwQCiaxDubj87vH7Wa2MflrA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2017 12:53:42.3468 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR07MB2273 Subject: Re: [dpdk-dev] [PATCH v2 36/46] net/liquidio: add API to set MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 12:53:49 -0000 On Tue, Mar 21, 2017 at 12:24:49PM +0000, Ferruh Yigit wrote: > On 3/2/2017 11:32 AM, Shijith Thotton wrote: > > Signed-off-by: Shijith Thotton > > Signed-off-by: Jerin Jacob > > Signed-off-by: Derek Chickles > > Signed-off-by: Venkat Koppula > > Signed-off-by: Srisivasubramanian S > > Signed-off-by: Mallesham Jatharakonda > > <...> > > > > > static int > > +lio_dev_change_vf_mtu(struct rte_eth_dev *eth_dev, uint16_t new_mtu) > > +{ > > + struct lio_device *lio_dev = LIO_DEV(eth_dev); > > + > > + PMD_INIT_FUNC_TRACE(); > > + > > + if (!lio_dev->intf_open) { > > + lio_dev_err(lio_dev, "Port %d down, can't change MTU\n", > > + lio_dev->port_id); > > + return -EINVAL; > > + } > > + > > + /* Limit the MTU to make sure the ethernet packets are between > > + * ETHER_MIN_MTU bytes and PF's MTU > > + */ > > + if ((new_mtu < ETHER_MIN_MTU) || > > + (new_mtu > lio_dev->linfo.link.s.mtu)) { > > + lio_dev_err(lio_dev, "Invalid MTU: %d\n", new_mtu); > > + lio_dev_err(lio_dev, "Valid range %d and %d\n", > > + ETHER_MIN_MTU, lio_dev->linfo.link.s.mtu); > > + return -EINVAL; > > + } > > + > > + return 0; > > +} > > Is this really sets the MTU? > "new_mtu" seems not used, except limit check, an lio_send_ctrl_pkt() > required perhaps? It won't set MTU for hardware and is possible only by PF. So lio_send_ctrl_pkt is not required. VF MTU is limited by PF MTU and is mentioned under limitations in driver documentation. Here we are allowing upper layer to set MTU up to the value configured by PF. Shijith