From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 2157611C5 for ; Tue, 21 Mar 2017 17:58:02 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id n11so17244954wma.0 for ; Tue, 21 Mar 2017 09:58:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=nhBgjH/4BLQvy2TSkBV3PCn+xUf5+cjMdRwJ6tufiEw=; b=o3uAXn0ErITxk4frMjIvt+UfE/hmoBiuRpCOUGSKLLO2lWIClHiOt6x1HZOAw6VQtL cD6s504U5YaS3f32vUbM9foDrV1boshbckNHc7vA93l8vjOPgHgL7xt/dsE4qrO3hDm3 kflYx9IZdxdeqwMqcHzgx9+3SehsZEEknt5US8u3hhuAF2tAQ4TLm+pim1kwgYMieXvR okyyXrNBLYiyt9SwApqXZT9683lMGk3mXuftKU5CfLLt7fPocBx3e+2LVqZTlEcTKQ1B DlEg4lrZwHmmOBZKDRMLMXVLzbD22t4nz0bMz0UouYiX1GwozVl2G602dBZpH+QBetxZ cj7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=nhBgjH/4BLQvy2TSkBV3PCn+xUf5+cjMdRwJ6tufiEw=; b=l0Tq2EfdVLuSGwZfBcKKXQUhvohpZ5+N6BlH6CEA3QdYg3VGf47SOS9E5VNZ+V+26h iFWbNr61XBcglcmuh76yX/hJZ3KdglFl/P0kM7Qx9oe1smEifbJBkCzxq6HiPaukDu1o H/VsK2S/fwsE2FRlizZr5oqK7nMVbkkIqiAZ9Hep7Q2gzloBSm+BqrQQHI0FmhjTabiM B4v4NT4cdXhL88mcKk1tcpEgqVuCcoLHmdDD/kXwN7PBMul0hUSeHVQfyJ4hdru4tYkt cNeT/I0G73phATqMxskchGnlvUYb7RNXQY9Kdrrfa74DzTni00P6/Y07fq5kt2Qd4Pbm 4J5A== X-Gm-Message-State: AFeK/H09BQ2ewyXXJg6ODNdJGGNKJ2F1B87ZwsLvCX2G0n14CzwExoXhxQ9deS0Qt5sWfgL9 X-Received: by 10.28.142.82 with SMTP id q79mr3071749wmd.94.1490115482475; Tue, 21 Mar 2017 09:58:02 -0700 (PDT) Received: from paques.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z88sm25774137wrb.26.2017.03.21.09.58.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Mar 2017 09:58:02 -0700 (PDT) Date: Tue, 21 Mar 2017 17:57:52 +0100 From: Pascal Mazon To: "Wiles, Keith" Cc: "dev@dpdk.org" Message-ID: <20170321175752.4e64e45a@paques.dev.6wind.com> In-Reply-To: <9176239A-AA15-49F2-AF81-FF9B58C9AF1D@intel.com> References: <9176239A-AA15-49F2-AF81-FF9B58C9AF1D@intel.com> Organization: 6WIND X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/4] net/tap: move private elements to external header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 16:58:03 -0000 On Tue, 21 Mar 2017 15:32:06 +0000 "Wiles, Keith" wrote: > > Just noticed this new header does not have the C++ ifdefs. Create a > new patch to fix this problem, unless you need to update this patch > series. Just starting my review of this one, sorry was traveling last > week. > > Regards, > Keith > Hi Keith, rte_eth_tap.h header is only presenting functions for local use within the tap driver. That part of the code is completely internal to the driver, compiled as pure C, and is not to be used directly by the (potentially c++) user application linking itself with DPDK. It's thus normal to keep it standard C without the need for c++ ifdefs. The other PMDs in drivers/net also don't use the c++ ifdefs in their headers, by the way. Best regards, Pascal