From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D108511C5 for ; Wed, 22 Mar 2017 07:23:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490163799; x=1521699799; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jcFQq/p1kc43GhZTXUOz8m+AkF3OzWltFx+QMMocJV0=; b=oAS34xbNT8ncQstaZ/J4w0aG6KBNjrkQ3TE8s0e02LHA9rpfnY807wgY RKzAMS89X57K4MWuUuMVhuWTrbh1Ng==; Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2017 23:23:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,203,1486454400"; d="scan'208";a="239006489" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga004.fm.intel.com with ESMTP; 21 Mar 2017 23:23:17 -0700 Date: Wed, 22 Mar 2017 14:21:20 +0800 From: Yuanhan Liu To: "Liu, Changpeng" Cc: "dev@dpdk.org" , Maxime Coquelin , "Harris, James R" Message-ID: <20170322062120.GM18844@yliu-dev.sh.intel.com> References: <1488534682-3494-1-git-send-email-yuanhan.liu@linux.intel.com> <1488534682-3494-14-git-send-email-yuanhan.liu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH 13/17] vhost: do not include net specific headers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 06:23:19 -0000 On Mon, Mar 20, 2017 at 07:32:45AM +0000, Liu, Changpeng wrote: > > diff --git a/lib/librte_vhost/rte_virtio_net.h b/lib/librte_vhost/rte_virtio_net.h > > index fa98d29..e19ebad 100644 > > --- a/lib/librte_vhost/rte_virtio_net.h > > +++ b/lib/librte_vhost/rte_virtio_net.h > > @@ -42,14 +42,10 @@ > > #include > > #include > > #include > > -#include > > #include > > -#include > > -#include > > > > #include > > #include > > -#include > > One small nits here, remove net specific headers is good idea, since API rte_vhost_dequeue_burst/rte_vhost_enqueue_burst > has "struct rte_mbuf" declared parameter, user must include in their own applications. > Can we add extra line "struct rte_mbuf;" before the rte_vhost_dequeue_burst/rte_vhost_enqueue_burst > APIs to avoid such extra includes? Good suggestion, and sure, we can do that. And I had a plan to add a config option to not build the net driver when it's given. Thus, it could give us a vhost with minimum dependences, say no dependence on mbuf, on rte_malloc and etc. I was thinking to name it to "CONFIG_RTE_VHOST_MINIMUM", or something like that. It's likely something I will do in the next release. --yliu