From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D0E3411C5 for ; Wed, 22 Mar 2017 21:19:42 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 384746A6DE; Wed, 22 Mar 2017 20:19:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 384746A6DE Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=aconole@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 384746A6DE Received: from dhcp-25-97.bos.redhat.com (unknown [10.18.25.172]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7801B18201; Wed, 22 Mar 2017 20:19:41 +0000 (UTC) From: Aaron Conole To: dev@dpdk.org Cc: Bruce Richardson , Thomas Monjalon , Stephen Hemminger Date: Wed, 22 Mar 2017 16:19:26 -0400 Message-Id: <20170322201940.24028-1-aconole@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Wed, 22 Mar 2017 20:19:42 +0000 (UTC) Subject: [dpdk-dev] [PATCH v7 00/14] eal: Remove most causes of panic on init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 20:19:43 -0000 In many cases, it's enough to simply let the application know that the call to initialize DPDK has failed. A complete halt can then be decided by the application based on error returned (and the app could even attempt a possible re-attempt after some corrective action by the user or application). Changes ->v2: - Audited all "RTE_LOG (" calls that were introduced, and converted to "RTE_LOG(" - Added some fprintf(stderr, "") lines to indicate errors before logging is initialized - Removed assignments to errno. - Changed patch 14/25 to reflect EFAULT, and document in 25/25 Changes ->v3: - Checkpatch issues in patches 3 (spelling mistake), 9 (issue with leading spaces), and 19 (braces around single line statement if-condition) Changes ->v4: - Error text cleanup. - Add a new check around rte_bus_scan(), added during the development of this series. Changes ->v5: - checkpatch.pl cleanup in patch 02/26 - move rte_errno.h include from patch 15 to patch 02 - remove stdbool.h and use int as return type in patch 06/26 Changes ->v6: - convert all of the initialization calls to RTE_LOG() to rte_eal_init_alert() - run through check-git-log and checkpatches - add Bruce's ack to the series Changes ->v7: - Squash a bunch of commits - Make the corresponding BSD side changes - refactor the PCI probe failure code to be more explicit in the intent - Remove most of Bruce's acks (with all the shuffling/changes I think the series should be re-evaluated) Aaron Conole (14): eal: do not panic on cpu detection eal: do not panic when CPU isn't supported eal: do not panic on hugepage info init eal: do not panic if parsing args returns error eal: do not panic on memzone initialization fails eal: set errno when exiting for already called eal: do not panic on a number of conditions eal: do not panic on timer init failure eal: do not panic on interrupt thread init eal: do not error if plugins fail to init eal: do not panic on PCI failures eal: do not panic if vdev init fails eal: do not panic when bus probe/scan fails rte_eal_init: add info about various error codes lib/librte_eal/bsdapp/eal/eal.c | 117 +++++++++++++----- lib/librte_eal/common/eal_common_cpuflags.c | 13 +- lib/librte_eal/common/eal_common_dev.c | 5 +- lib/librte_eal/common/eal_common_lcore.c | 7 +- lib/librte_eal/common/eal_common_pci.c | 12 +- lib/librte_eal/common/eal_common_tailqs.c | 3 +- .../common/include/generic/rte_cpuflags.h | 9 ++ lib/librte_eal/common/include/rte_eal.h | 27 ++++- lib/librte_eal/linuxapp/eal/eal.c | 131 +++++++++++++++------ lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 9 +- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 5 +- 11 files changed, 256 insertions(+), 82 deletions(-) -- 2.9.3