From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0044.outbound.protection.outlook.com [104.47.37.44]) by dpdk.org (Postfix) with ESMTP id C6E401B53 for ; Fri, 24 Mar 2017 12:17:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=EdUPTW7X7qNXXqzr9RFyhrA4WHVr5OEHNQYVT+IEN9Y=; b=n/QHQkhQDjefDBiQA8nxXVhMyHYVIKLkX3c8ItQG1ZdpGNIjpqrNlpXMpSSGL/L+5irBHKWz3roG8XG/aHJavK04iby5qIZOm6FUNBT7jd7oOERL4xqasoJJRGJwngO4vVNzlockiQVxn4VZyZdldbvnJhpKko5sDHHp+CWyRD0= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (171.76.89.237) by CY1PR0701MB1728.namprd07.prod.outlook.com (10.163.21.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Fri, 24 Mar 2017 11:17:06 +0000 Date: Fri, 24 Mar 2017 16:46:49 +0530 From: Jerin Jacob To: "Eads, Gage" Cc: "dev@dpdk.org" , "thomas.monjalon@6wind.com" , "Richardson, Bruce" , "Van Haaren, Harry" , "hemant.agrawal@nxp.com" , "nipun.gupta@nxp.com" , "santosh.shukla@caviumnetworks.com" Message-ID: <20170324111648.vhrigcj2gxebqnou@localhost.localdomain> References: <1488562101-6658-1-git-send-email-jerin.jacob@caviumnetworks.com> <1488562101-6658-20-git-send-email-jerin.jacob@caviumnetworks.com> <9184057F7FC11744A2107296B6B8EB1E01E90810@FMSMSX108.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E01E90810@FMSMSX108.amr.corp.intel.com> User-Agent: NeoMutt/20170306 (1.8.0) X-Originating-IP: [171.76.89.237] X-ClientProxiedBy: PN1PR01CA0116.INDPRD01.PROD.OUTLOOK.COM (10.174.144.32) To CY1PR0701MB1728.namprd07.prod.outlook.com (10.163.21.142) X-MS-Office365-Filtering-Correlation-Id: d1cd27ce-73f0-4b6c-8f9b-08d472a7502f X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:CY1PR0701MB1728; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 3:TkZd3ncd9beKyQB7LmYNUU2gvCUCW61P6PDV/Y6cz54p7BpHsr034lArHiMHj2i/ybXnY8RiljZVJ0LzaFCz/lFoYT0HlpXvAW3+bJ133Koufw8T1rbM7I9OuSVCN6S4+xJJf8ON+SDs3n3vQn7zD0sPDqOp7Gb26FLPhGLuC6rEEQq9YZawx91/xI4efH6otskt9OO5YzHJDFJGgTLDedVIFkTYNgHxQs5vuwthaPZEXN1mORrAvfEr4vq3kqYIs/w8rrdcXX9OTo8wFX4mmw==; 25:cG1v4bbw/FRs3IEATgsImbSqpUhCrs2Ef+iiKRvNM9/U2T6TKtrZsWfwP5LPUyAsKwR9tGCbdG45U+fmYaPohy0KT3PAxST0aJyvAG6jHCuoWNltZW5znD8p2bfIp9dQ4+G7+de91mUHnN9DeJ0V5UyJCTwKzf5HN9gwchNAtNfTOCuYEobv+qOrF5E5yY2RW1viFQ/X36HUdX4uH3kCQiEmDKYz9jKqF2YgFS6RYujkLGOwUdWUGdpfAb8TXqGHUd6/08RGUA713X4PRzBSn9+OLl91hGguun0ssnIAr/VKlntzv80yK8KaRv22aJHCgM+mUrb1o/SZoK1qeU3+OS7isrW4gxr9+JZbhKHZjiwuJQlpKZt8HjKtJeCd9k+xxW8YE0fOIYk7MMIUxAKBdfRvVna7kMPbldIvBpPO8RRiR4xYv4tJ6IZtov+0mkur4c4/AtRX+ekDvR72aqUVEw== X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 31:XeCow92t1oYt70XIFno6oSpmOak1ZNEukDm2hMip0uQNUKxs1WxUUFgZA9MfIOugzYdglBJNLv6lsNrpSnbJXPSDnaBxVL4WkNfswTMm8V2yOGwR99DtqZ3dJSZXiHLKw7YxweNx8ZvOiPxgZ/oyOvFstMBEOwIclkZbRjj7vqSLq1EbFX4MSQtt/D85e12NKuDEtygAtpT+gcKF8n3bnRDKHOQ4na/FCK2ALTqs/I8=; 20:gi6JvuzudniBRdylTGHMwuZKUf+QfVFo6R2+GgFTHt8MEvMfs2WgrZA0MydSjgbGa4Ak6y38kTohH8vhSzrd7rD+HwrlWGzKeLginIt5UN2KChIpxP8grgLH9Ml/JYTtMzIUovnn92WM3O0uUj7kpyA5Ae31zTljl8/nr3odRWAVm7HKUnz2apj5Slwq+AIyd3rgHSyzEqrnmFWcn8kzu6eCRC3ibdDvAch4VFkRrTAw5UmqXSBzCUI+pe0tBys8Rd307C9i3guENOY60iGyxBTZ+26/14U+kEQdeH3WeUvSOFHBDLkIk/1oJmhFxY7NXTbGTSnXTwmiYEdoRWhXe4S7mVpcN26p5T2CNlXZuQoGaXlPyNwYkY1jyUZjNA+fbOwED35egTUi5B+/UZVEb0d5PoF7xEFIIWQ+DYUBMvr8kG4VYs9xwdfJXbY4cYPO6pSMxkgxM/gOCCJvfxhhx+ceb3j6GbfsG+9GssuiMBhhsOLTmHGwqRSi7C67+lEs3z2EVMcvzS/Zd3c+A+TXBLe9ADUbaN35FAJxH3F4LUz++IFdEFm2U6yuon+Qw6wB99VAY/x8+b+B4d99g6cipVHTlj6YoaftMChVkgfzPiE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(20161123558025)(6072148); SRVR:CY1PR0701MB1728; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0701MB1728; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 4:pUvmSA6mwyEMO14/IlHTGv00YRADWMYbw1tQ9M5KdRu4hf59AzT8uVrsDro9N5EsgJ3luXa46kUvKmLc8W6yGJWgVhV0pP9SiXNsQ/gr67X7T6a7sHrM+Ae4IRS2BDaPgTzdzk7pc85P9eP7vhKgLAImQoFCJ3M1OdkVm4rt9Npg7CHD2odrZ7dG2bEZIqi+RnKVbw2UAspkwaKh2yCabmgZOL61QXLfeFIQVosqmxJgChPQurS7++GtEIHB9s7yhcJkVpsvyXT7ureKJQ7hE1Sl6xPzewJlIaDBM24G5vJkEbtpZ3BAO9djf2Kk7Vm4U/kL/h5/WAovwNi4slvOhsfCzDfQ6fTmzHvDU9vhBDJ2XtVhaitTMJixEfCchq8KdftMAsjiQ4yG+bllEb3Bi3pbJ88+1UVvBNzUty4+Sf9aTHdJzwY8fEZmv5DEwi+cy0wgUfdSBiXeOyHBuqtCl8JGUapvVcils7SfubXy7eUy8ndsbCKSBpz4nF02PkxSGw83GKo8dLpf4CZYke5l6OI9Kxu/R9pOauk8G5S4e82e4HMUEEZFJ4IThDotrch6Ul4/BLgbwEOYZxi88blMKkiPEqCnhAjd+n27EmnOCUU= X-Forefront-PRVS: 0256C18696 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(39410400002)(39830400002)(39450400003)(24454002)(6116002)(3846002)(5660300001)(23726003)(42186005)(25786009)(7736002)(305945005)(8676002)(54356999)(50986999)(1076002)(83506001)(189998001)(53936002)(50466002)(33646002)(47776003)(38730400002)(61506002)(9686003)(6666003)(55016002)(42882006)(2950100002)(6916009)(6246003)(229853002)(110136004)(107886003)(8656002)(6506006)(66066001)(4326008)(76176999); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0701MB1728; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0701MB1728; 23:2c1LsCEeho0/pVZOw8rcBSyieb4KqmxzIDDODUR?= =?us-ascii?Q?8uFrZEOkyXqOtePpsIb+DP7ZUSzn/rMIDK58R8S9xwlLGRCzhsRAFUE7Q6je?= =?us-ascii?Q?8N409ochB4lgNlelLaGklr9Tnu+AZwUSPFYtXhyQT9Ak0evGkQXzIo7XgM7s?= =?us-ascii?Q?fFEeFTtzSxtmQqRmlhRDZ5fHxa5NDlBA8zZR5V1TYFRhEBivH6lXO3Tc540u?= =?us-ascii?Q?4ACnHoLoCOv+jcRcZRi81HNY7SAbtuSmWdnSRVcGN+Q+ey867bk9IIQ7u2mn?= =?us-ascii?Q?TRJDTsqkfTI9KE8Dtjqi1LUGO3B9hi1wVl0esNpvvQIuc1lXWFGvT6TzDR+p?= =?us-ascii?Q?Zd4vpfHOR9TduNL6CRPPnQiCOK556uj7mClS3JDU1/t75GPC4K4Wxx1Yym8a?= =?us-ascii?Q?H9TBO9yNqyDLgjGJ9g0j53U4nxSbJ5CDpBtpUzR3BIgbLWzF9DXKueSNrFKr?= =?us-ascii?Q?ZMT47SV3LKQEgXAxkBLdjiOspMScj3o3Prdi6yK+yS4HWpVdbYazbHVFQ+Yj?= =?us-ascii?Q?EiYzavRqCQMmqruoQOe6aN7KRXRUtDTYqC4sBOOIuAcjmJ72EBk+ChbuWGKs?= =?us-ascii?Q?6heKNAoWgkMih5te7hhJCEVzuUZ7CGx0CHCo2vCJLx/xcDO8bSFyA6316WSi?= =?us-ascii?Q?rdBFmEoeoGi2YpYXv/NJJuvUISl40kgjC11wZ9+Upx1ccJptcyO7RMLtNrdv?= =?us-ascii?Q?a7kf+Cv6bJFzbpp9+tgTOWQq8UAllxNaB68vTNi/h5ehjY5+zpYu8oE/GXNw?= =?us-ascii?Q?POD3TfiST5BBAZRwmJgMtnmBcqP1AikgSR+n4hw7whIjmBaBDRyuq8fy6U3Y?= =?us-ascii?Q?nWphQwCJTbDp3LRexkOjJmO9MJDH3eMyxtVn3+QmHdHVgbdF2JvuxnRv1YHi?= =?us-ascii?Q?kouLfo5a4bl82LKKi5aEQV+oJks8/BrXgifWTs9ODy6WHGToYgRR0v8hU+S8?= =?us-ascii?Q?mHJ8LoMeTUG/DOUMnvDbYmYXlUdHQdBwhF8RuIgLPBh05sL/ef1V/yqR4j4+?= =?us-ascii?Q?7pss9L3dX2ST9jrxJ6M+YC7HR9dFz3sSIX/Et6kc7alWLGg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 6:gXW7WyAhxyil1SB/L5W+yzDVCnYmX3G5w6tZtVsPFH87Ba+VnfcTy5RteWh2GlwxU1zviQkH4mpoPKseFc8vrnKsfqBUxlCSm7Ygf3B0a8DHM1rs6T0vszUpx6Gxf9bHb98M/1xdImVbZoT6WbmFsPSdqnLoTB3hwb99FNOHEfkSOIsZJOwZGD9Ctcynzh5kXT+U2OYtdQvq98rw/inDAS8GSrGO2aopXdDfZ5ePGTU2ZrUf40tJuZGK/In9SXbZIjA8Af1LNunVdsNarlec+0kEG7qDBQ2bO5gIv15Z7PiMxpVYgiXdJ+yaA33hpZ3i8Y0vldjDI/HhVpu92OlWT2Rhlu6t1Bieg/Fl7YqFSoTpgqupBJNEHpsQyyFMBJ9s+u22V9qceFHneckU75XLQQ==; 5:15TZtSxk/77Y8CNruJDz0z56TzIMix00s373r+vUGYC24B7ONFv1wnya7yGgmQmNKZOjDHX9nO8IHLmP9KyYjr5BMs6BUvNp761wD5xh0RVYOzPhGMRTGcv8tz2HADhPwQQp4jZIAm2Q5qAebzi8/g==; 24:xEptHbBaJiIckzucmuoPsQW+VIcF93OzG7l0gGi2z5WGNZ5AsXhCWeOchcOKIr0RqZMS3BCAl1TJA4z3ch4Pq9GNCJMcSWDOC3XMJdnBlPE= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY1PR0701MB1728; 7:IvhamW+rNcsH/JG1eKUc+WT9ruR6yKi09zUhitiWFECOUKoL4ZlALnb6gA7xth+l8xZ6+rBo8mWqZfm/1ulzCVv0ViHG7MRXuPzA9AJUadE6UYl0IV8obGMY6ul2DhyQ/ZdsryYakt5m6tF4ppFF7vYQedw8f/CvC9ArFPRvydAGyn2xdb8AkCTUMlNSbvtEqHbu5p80gGAP7tNf/HTycm1nj+2Z/g1GFUIGPbRVC3M6RoUMocsLsLYcFh0mHhIIeMtVQw+cTvVu2aPyqv8nDKPCpe+UyY0BbXoZSFtheBc66nXg+z1ohd57wNAbnxJrJNDRcwuDrxQyKBVBBDnFMA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2017 11:17:06.4536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0701MB1728 Subject: Re: [dpdk-dev] [PATCH 19/39] event/octeontx: add support worker dequeue function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 11:17:13 -0000 On Thu, Mar 23, 2017 at 06:51:07PM +0000, Eads, Gage wrote: > Hi Jerin, Hi Gage, > > > > > +force_inline uint16_t __hot > > +ssows_deq_timeout(void *port, struct rte_event *ev, uint64_t > > +timeout_ticks) { > > + struct ssows *ws = port; > > + uint64_t iter; > > + uint16_t ret = 1; > > + > > + ssows_swtag_wait(ws); > > + if (ws->swtag_req) { > > + ws->swtag_req = 0; > > + } else { > > + ret = ssows_get_work(ws, ev); > > + for (iter = 1; iter < timeout_ticks && (ret == 0); iter++) > > + ret = ssows_get_work(ws, ev); > > + } > > + return ret; > > +} > > If I understand this correctly, each ssows_get_work() call will wait up to N ns, where N is the dequeue_timeout_ns value supplied to ssovf_mbox_getwork_tmo_set() in ssovf_configure(). > > So in ssows_deq_timeout, the wait time is (worst case) timeout_ticks * (N * (ns to tick conversion factor)) ticks, which depends on the user-supplied N at eventdev configuration time. > > Perhaps in ssovf_configure, if the RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT flag is used, the getwork timeout should be set to 1 tick? I agree. That will improve the timeout accuracy.I will change to ssovf_mbox_getwork_tmo_set(conf->min_dequeue_timeout_ns) in ssovf_configure if RTE_EVENT_DEV_CFG_PER_DEQUEUE_TIMEOUT flag is set. Thanks > Thanks, > Gage