From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0085.outbound.protection.outlook.com [104.47.37.85]) by dpdk.org (Postfix) with ESMTP id C10895583 for ; Fri, 24 Mar 2017 12:29:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eHqr1KkN2Ql/FNFWj3Gqqb0hZz5kZyC274DcdghRV1o=; b=d+4qTZgvaAuAqMHjKknCWcxY8BdVMG6xmYcogy4Nf4PMjW0Zzlgkhl6nrEq9mLC3IsmfX6ydX51AvH7teHrClPHj48knVqTSSnRbDLxf4GhbteNCQEa6Rx7woXTLctyFjTg4QKxJFmyaSzefW7U+mAGfKz4IylhDPvZlWgpNhIQ= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (14.140.2.178) by DM3PR07MB2282.namprd07.prod.outlook.com (10.164.33.156) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Fri, 24 Mar 2017 11:29:20 +0000 Date: Fri, 24 Mar 2017 16:59:04 +0530 From: Shijith Thotton To: Ferruh Yigit Cc: dev@dpdk.org, stephen@networkplumber.org Message-ID: <20170324112903.GA15473@localhost.localdomain> References: <1487669225-30091-1-git-send-email-shijith.thotton@caviumnetworks.com> <1488454371-3342-1-git-send-email-shijith.thotton@caviumnetworks.com> <2979245b-17a1-4971-5883-5165d1e6b523@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2979245b-17a1-4971-5883-5165d1e6b523@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [14.140.2.178] X-ClientProxiedBy: PN1PR01CA0055.INDPRD01.PROD.OUTLOOK.COM (10.164.136.155) To DM3PR07MB2282.namprd07.prod.outlook.com (10.164.33.156) X-MS-Office365-Filtering-Correlation-Id: 186f150f-ad88-459e-e498-08d472a904b3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM3PR07MB2282; X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2282; 3:zWyYasYxheimwTGxX5OrRSv8yrCKN76+2iOmiHOeZOGwYua56szU14JyS+BLwfJXwjNiBe2GKiFqOc+N0GNxhE+aN/q0OwqvgwLNuQ2skdYQUMTjz7B1wObvVU7DxWJ/DaAxAKXOJZu7HqRM++kzVYjRB3pTyeu9nd+RBhjMQBMfIOrz8g5xq644g30CZfqCg3u1/IMUeOdvin3/qRoGq0g16cNs8E2c5sgvZyr/p5LxBOhqSVThbNCEfMAW1g2rXA7BvRgiEtSed5GcW6t0eg==; 25:neXDX0Yc5C2AGSw3hkB3zU/uDIP/1RAPkPqULgR+Q9ZajPwLYyS2OiK7idSx5JJ13ZHkkpbNa1BRXTOAqT++WTJw3TctStmOHaEOOwm5gYJATHxI4ru6JIFtqP0TQ/VR2V18eF2Chli8pii6i8BFuixGhNOkgQ4mTKYY/4VPIc/s0zOpihRgQLw9fe1yVSa2DNRaaWqmfQgVGsKz5d7JPbFxvuqLIPSXfXCSGjMi9c0EFNa6b94r67jgLJUSksq93qoqO+B2UuDWVxpMoYVdhz70ix0RaboTtppI+bWzZqLkRinz3kHwngEnnKK3iA2iwkHka6wncYkYRH031TjX1HMIhNTu0y/SQDEg4mKI8J0YIdFbg2GZVCUoCGmfOFYzj4NxsuN1HqxJK4Uov1Ao9S/bTSdK73DdfljUt92YnlPr5wySZHB6a9zx6z8eYfjIWWu1mt5cSbZF2RjKPD6vRQ== X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2282; 31:2H89UIRexhy90WMsHo2nQvWskeOnegdXzjjJjCMsVKA/im2RSiWGYshSm0LY47oqpdjiO7dpRsIHSSozs1B/ZFLg8rICQkyI1Zks6lrACxRgV+QrELcNLJJPYbBrdxEku3QxHeJ/+AROsbmJA+S6731XcivM/hAHB0FgeT3yx7u2T9L8T6DMElWNrnuIkx5Lm54eCBzFtU+z23enIGRHiNYfSTlylqh0GOLbldhR5NVHS5rXdmXWfOrQ6O2D0SZj; 20:wCR0arb4hQv3ftjoRJOBFbuBxyCVny56PZcNjIfN22RVtPOfAVsuGQSTZ0Iq8LSaMw+sEf4iaqAIAf3KWrIV941woaWleT45PJhmNY2IpNCTv6164DeXDIWyxqtn7P7eLP4WRdOKFFk85MIOe3C81HwpzokYxKEs0Zv3yn35y9rye2qxXGRkm1zw2LocZWy2g46B+JFjnRYZjARcLRMLbfZiONLg4oU850Im74C2QoBXocuerldA1tvTAQYx3IjJUQflJwOs3+KnTEfa8QMZGbW2ZRzB4yHtjTxcG9VfP0eWizZ9b8PzsqDluW/7+llpSPbCkoqR2jFbD5s6oa3CxxgKTeuNuBY93bwGACQKfS+70AgLz05hZw0c0IbI9iY6zNLikNMIJ8zjF+2xZnHbZg0N6VPqeIOkjZyOUjM9/fY8G9ndXctUPJqQ5IY7n0RgCqkquIpAyDDRXcTHi+85CzupQFWMm6sSMql2CwKwsfIdnvOA86Eg1HBtxU3H2EgJY6IRpS1RJ1fp/vnRpV7tsOgOt8pl8TGzXcA1FrYRKQSaIHVLeclk4uY7ApcQePSGuU+tR9vV6v6A7C6MuSlN5t9+gX55pu/+W4R5eB2+ANA= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(158342451672863); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123558025)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(6072148); SRVR:DM3PR07MB2282; BCL:0; PCL:0; RULEID:; SRVR:DM3PR07MB2282; X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2282; 4:KCHQZYTJb+AEJOJEaxsczmlL7C7y423fdN7zh9oW9y+M3EM/iw0cu/UQuYUQXAQ0XfcWipGH3B7+EGOC4crVjrL3FvY9AIxAnLgeV1GVjv8zp1FNF7fCiMxkVGWOxd2GarWVS9jogN9PEjRhJ/J5kbbwoRWq/T5VO8wWxfKTLmYE4TKHCUmrxvYSkhW4dvv+CxopNVGWLD0f6FYjWsgV2azERMcWh/5Tp8qDjrLrpIgsEVTF/iD50nofF86l6QeNDDUl3gT2L4QKt/ogsxz6SnAv6nurbfjB7ZyumqNp/TYHNsd/+4ihuNsR9BtXVvoyx4WdY6hfX936Ht4ASHrYnf5W4Yi+akVAr6lWvr5xnjQPk2CBEqdEZo9ByRCmAIrXHKtmmaszIaMHVomhIWJc8qqCZsqw0M/h4sycm8BRojCixUDfEWcuMfbkNYx0AnJE2P8gpKDrfkcstRFYUkyByYDDpG8ZRZp7hI+DPZNGqOUg2gvpHkQpYjm+Bor6O8rskYqMgugUGAlo4Dv5LNNEGmEw0fi/4TbykB0J7e1PdBQi067CgF5hX5fTUjgfASTyw3rHn4/8IlKCh0blLHOLnOOfNi6FuRGZwPXkeel/i4n9aQLMNJ2wyP7CKp3MouOdLE943ksVKo6m/GmGc1FGJA== X-Forefront-PRVS: 0256C18696 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6009001)(6069001)(39450400003)(377454003)(24454002)(51914003)(33656002)(5660300001)(83506001)(81166006)(229853002)(966004)(53546009)(25786009)(6506006)(42186005)(53936002)(8676002)(4001350100001)(2906002)(50986999)(50466002)(55016002)(61506002)(6306002)(1076002)(2950100002)(6916009)(42882006)(1720100001)(5009440100003)(9686003)(6666003)(47776003)(23726003)(6116002)(54356999)(6246003)(7736002)(66066001)(189998001)(3846002)(4326008)(38730400002)(76176999)(53376002)(19273905006)(305945005)(110136004)(110426004)(18370500001)(563064011); DIR:OUT; SFP:1101; SCL:1; SRVR:DM3PR07MB2282; H:localhost.localdomain; FPR:; SPF:None; MLV:nov; PTR:InfoNoRecords; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM3PR07MB2282; 23:Szxxd2SEQgDz5GO54xN6g34M88TTwYIybCMmYxwUI?= =?us-ascii?Q?GoG3mXmPhsJyQI06vNWpwlUtMhGmyHG80G7+sG4BkFjsxM8qmPgRaN4vQj8Q?= =?us-ascii?Q?SenlYDe4EsQl9SsD6NdE9Pv17LWJWF3k6WBwBHBgci4HzHFBgVRGj3m+xovK?= =?us-ascii?Q?PaB1z+lSGX3evuBoEMUZ99ayct6QRPTpRv2U8XQDe/4ZQn3JU+gZyGJypAoO?= =?us-ascii?Q?P0d78bqxs/yJvc21FVhN00mvr5AUBoA+5eeVpRHMw1PhIWbat9tbiiNvcmCf?= =?us-ascii?Q?DjGxAEk+Rk9fG6Z/lcjeoJEnIwSErILK29a93MBq6p3RTX4LkjDJ9qIEcbsX?= =?us-ascii?Q?FM4+1nph/B+c6GNYC7+Khx9aWRcCIFuFsCU+eHzOHu5uWKkBV28wPxAckT6W?= =?us-ascii?Q?En/dYuOgMQbxOMYhe+Neb4dZ3TFXAiZPZtgb1nl3tJo7hpDsXj7dKk6tQmWf?= =?us-ascii?Q?7Tcs63qhMeEjal9OXylAaABOiuLAwO4bUvo/nfUzf3zKXTEp0qMeldroAvb4?= =?us-ascii?Q?eegHsnBk4yJ7Xi9n8UjdbT3JgeuquxR7iGm3Sk2T5k36bxcssYllinCXb4kT?= =?us-ascii?Q?OyWQ54Y/rOmS6ELGvl2zRgQwq5Hmo4SjD5ruBGc/OOZtzzYweRaxqIbJCXLQ?= =?us-ascii?Q?NdiLogbGavztDrfebMd/Bmt9ubDyXmXRjEh2l+0GW/4LNQs8V35T1WAQ6Dvj?= =?us-ascii?Q?koEjGlz9/EyVbAF/20aOwRVTa/H3JtzXd/5S22FuAT5BZicXVfQkCtncdPhM?= =?us-ascii?Q?/ISJZ/u/upoIbMnm0mHHvb19MMkrHmksVvHVFb+meNAp1txMg9gjxBBKCKMd?= =?us-ascii?Q?fDRniij19miA0M+cV8bbRHzLRSQ2LXO1NFQydYt595UADBGQyxGjZafo7/ah?= =?us-ascii?Q?cTJqz52ws6iObnI4ktu42wzLYoh1Cf18mbS0tVqXXVWjGSbrX1ndVEFxTZWd?= =?us-ascii?Q?FKookZwgmIUhG1fLs8J9EpmnP6eA6KPVRzdIIgmiPQ651+/ha2uETUXBRaBm?= =?us-ascii?Q?I0C9AYTmuXNt/9jfPl1kWLnm69AO5LyidfhbQU3k/xWGoccQXUgIsJMnBAFL?= =?us-ascii?Q?Jb4p1WGf03h7KW0uFgGrAqvcIylf6YHrsFRgwbLdMebg5jCuob7aOr5s64ax?= =?us-ascii?Q?LBl4S1pOJitiNIqF0UdGyUwVt/r5h8WWbjdDOp6PZWEZ8TfEG77BPRVNT7AF?= =?us-ascii?Q?0gkJ1uNxcltAoSMToITPqr85yC0C3OvM168k4dIc9t7qB99vYwHpNOrG4wrs?= =?us-ascii?Q?Si4YNPwhO0rn8aKnmA+0QiMp8gByjA2W/kpWShB8DA1fAMT+xMv4UiHcm2te?= =?us-ascii?B?Zz09?= X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2282; 6:5UkhYUc8BiI8Muj5Lq+5ZMhcaFYdSzB8Fw/Ji0+Ja7UJa+OqOd/1l8TMozxylTK4XBn7nNgla18uIZUztTPMv7p+ZZ01WLX2jNE0G3iAQEhSp/t4Fhi52clGRxaJhtUtc4QsBuyYQitYXLVGC8f2Z+XsoPU18XqxoOkimTEFI6rlAP7bBJybjgmOeDDNa8XZa2RnSV4qOWlcjGE8ttv/xODCPQ9BOSbUxjWZTxVFK2cmatBx8e2WYS+Azgnbc+ntzuI3A7AAbLWMYKExl7ygtjq+Yigz4ggmcXmNOejaQQjroQPQMj165ZYqUBZofY7M9FmVrfVfPzyKSPhTqHGDOX2Fivm9rNZ/IM3P0KLTCPYIIi4OTdcbAtdoHsayYSl6Mss+ipI/fsnN/TfrWdf8QA==; 5:BNUpJfCgQvunJeIvMr2pnEmf2ebXEZuDfMezhVh7LzlfJdvjPRpcEQt/BUQt9S6UV7zXKMFXraFskma+Z6D4HANG2EqjP9hM4a0JA9X3goGdn752rgDw9EuUc40HiNkSAw2z7TzXQaeSf7YXMpisjw==; 24:MntmFsKrwZ1Ip8zILOk/yg4rDSVfLFbJp146QPMMY7PXuIfZrH+u1B1zNtWSE6OO16I25Xy3XX1a8y6ITaRPht5+D9q/orEIyW8nM9h/Dqs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM3PR07MB2282; 7:QiWHEkeCD71SvhWIFLgvHNqHx1keCl8+gE/bdx13TFEncogaTe6I90K+jbaG6+NrfhZY+bKlbyrYCoCudRW526r0h3rs0gySNDVC9ruWGeYA6v3qCDt2KT7XxpcJsl47D2ungKQ7kjeBvwdqdP2IWGM2C+1A+736Jr2u1/drEe/qGxrd+4IT5Dxu6UunHZ1xuiDZ4Ftzlqb2buIHe+byFWeVvSps/oE5UitIMRDIZk0lglanvzN/1lu+Ud3CSh8yt7wjOazmXKHT/EIMhHF/upmCufMEgzl9VJQ/Rj1j8m8p4oTavZ0Z45x/D25wU6LoGmePJQkvqGimXmGjiwUfUQ== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2017 11:29:20.6027 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM3PR07MB2282 Subject: Re: [dpdk-dev] [PATCH v2 00/46] LiquidIO PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 11:29:25 -0000 On Tue, Mar 21, 2017 at 12:38:18PM +0000, Ferruh Yigit wrote: > On 3/2/2017 11:32 AM, Shijith Thotton wrote: > > The patch series provides initial version of virtual function poll mode > > driver for Cavium LiquidIO II server adapters. This version adds support > > for LiquidIO II CN23XX 210SV adapters. > > > > Patch series includes driver documentation doc/guides/nics/liquidio.rst > > and list of supported features doc/guides/nics/features/liquidio.ini. > > Updated release notes to notify the addition of new PMD. > > > > v2 changes: > > * Restructured patches as suggested by Ferruh. > > - http://dpdk.org/ml/archives/dev/2017-February/058186.html > > * Addressed review comments on driver from Ferruh. > > - http://dpdk.org/ml/archives/dev/2017-February/058188.html > > - http://dpdk.org/ml/archives/dev/2017-February/058194.html > > * Modified commit logs as suggested by Ferruh. > > - http://dpdk.org/ml/archives/dev/2017-February/058189.html > > - http://dpdk.org/ml/archives/dev/2017-February/058190.html > > - http://dpdk.org/ml/archives/dev/2017-February/058193.html > > * Made changes to documentation as per review comments from John. > > - http://dpdk.org/ml/archives/dev/2017-February/058206.html > > * Fixed FreeBSD build failure. > > - http://dpdk.org/ml/archives/test-report/2017-February/011272.html > > * Updated driver documentation: > > - Added CN2360 under supported LiquidIO adapters. > > - Added CRC strip under limitations. > > > > Shijith Thotton (46): > > config: add liquidio PMD skeleton > > net/liquidio/base: hardware register definitions > > net/liquidio: definitions for log > > net/liquidio: liquidio VF PMD driver registration > > net/liquidio/base: macros to read and write register > > net/liquidio: liquidio device init > > net/liquidio: add API to disable IO queues > > net/liquidio: add API to setup IO queue registers > > net/liquidio: add mbox APIs for PF VF communication > > net/liquidio: add API to setup mbox registers > > net/liquidio: add API for PF VF handshake > > net/liquidio: add API for VF FLR > > net/liquidio: add APIs to allocate and free IQ > > net/liquidio: add API to setup IQ > > net/liquidio: add APIs to allocate and free SC buffer pool > > net/liquidio: add APIs to allocate and free soft command > > net/liquidio: add APIs for response list > > net/liquidio: add API to send packet to device > > net/liquidio: add API to configure device > > net/liquidio: add API to setup Rx queue > > net/liquidio: initialize Rx queue > > net/liquidio: add Rx data path > > net/liquidio: add API to release Rx queue > > net/liquidio: add API to setup Tx queue > > net/liquidio: add APIs for SG list > > net/liquidio: add APIs to enable and disable IO queues > > net/liquidio: add Tx data path for single segment > > net/liquidio: add Tx data path for multiple segments > > net/liquidio: add API to flush IQ > > net/liquidio: add API to release Tx queue > > net/liquidio: add APIs to start device and update link > > net/liquidio: add APIs to alloc and send control command > > net/liquidio: add API to control Rx > > net/liquidio: add RSS support > > net/liquidio: add API to get device info > > net/liquidio: add API to set MTU > > net/liquidio: add APIs to enable and disable multicast > > net/liquidio: add APIs to set link up and down > > net/liquidio: add API to configure UDP tunnel port > > net/liquidio: add support for Rx stats > > net/liquidio: add support for Tx stats > > net/liquidio: add APIs for hardware stats > > net/liquidio: add API to stop device > > net/liquidio: add API to close device > > net/liquidio: add API to add and remove VLAN port > > doc: add doc for liquidio > > Hi Shijith, > Hi Ferruh, > Overall patch looks good to me, I comment on a few issues. > I think PMD is ready to merge after mentioned issues addressed. > Thanks for the review. Will send v3 with the changes. > And can you also send a web page patch to list PMD in DPDK supported > NICs web page: > http://dpdk.org/doc/nics > (web repo: http://dpdk.org/browse/tools/dpdk-web/) > We will send the patch to update web page. > Thanks, > ferruh Thanks, Shijith