From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 5A0C7D380 for ; Fri, 24 Mar 2017 15:59:09 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id n11so15185316wma.1 for ; Fri, 24 Mar 2017 07:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Nd8kT9Wg1zc4+4d14HVp9UTU7f4NjGn8/doKIi4fraE=; b=cjuYibWqPagIgEDc7QfZDGaWEngayCxasmRtbr7MhqExNfjcuoRQIyrQJc8XW9If4Z 2hLajV9yZRpUYeQfgo4hAaNjV43FInbq7jn+Z7vmhpOjIQdjnM3D6SazOr5plLZSBv+X 7K7p0bJNYATYMU5SlnPiQEznJHrk3gTXe/x7W76pRe7c3XeTiPBe98lHskxoTdNcEHuA U+iWnEX91ILXt5bBY8ohY7ZQvslO9fDHsLsFTT3bqT9Fou/g1QJGxrP7K4Uing3cKM0H IiWuRRvobNlRpyiMM0Ht2GtTFflk9GFmEMelj2Kk/5899EI6k/ce6i7cLqkb31uEkgAS MGrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Nd8kT9Wg1zc4+4d14HVp9UTU7f4NjGn8/doKIi4fraE=; b=O+9gI6qJvKOS8p3dAR8ZYlYU9IxMVQaEPGUT4j0u/ZXrHt45ZBJFakE0AONLZdG2iY VQ4JhPqXScmKN2w+eu3aNJAYVZVuFe+uJCdQNf+7jRkFP+b4qKudRhl3n8MiCXGSLfpW YJV/xouK6owP7NUCXMruavxZJ5jy48IZYlIrZoS/Eu5fJOR1a9bq6nahVdk/ps1OKu+f F6RJo7B/RRJzoU8SBOw4z83yHLoQLd0dRn9oNCibQ82c35uQ1OJ3SPaDtvU/L+raLo2S cuvUSY3G1C3rD9zfF3BsXJaSZ/RvQJu3hRCtNsNPGznjRp+/j1rqzSIsukWafaN/cjsv I9jQ== X-Gm-Message-State: AFeK/H0f4JuPzBb6w4GFrylWyf/8roQzMTL0vuQPnbLXzb6vb/sOOG0B64W0d//NjrlHNm7S X-Received: by 10.28.113.74 with SMTP id m71mr3714816wmc.133.1490367549021; Fri, 24 Mar 2017 07:59:09 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id g78sm3216335wrd.11.2017.03.24.07.59.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Mar 2017 07:59:08 -0700 (PDT) Date: Fri, 24 Mar 2017 15:59:06 +0100 From: Olivier Matz To: "Wiles, Keith" Cc: "Ananyev, Konstantin" , "Hu, Jiayu" , Yuanhan Liu , "Richardson, Bruce" , Stephen Hemminger , "Yigit, Ferruh" , "dev@dpdk.org" , "Liang, Cunming" , Thomas Monjalon Message-ID: <20170324155906.4b88a38d@platinum> In-Reply-To: <0C56AF3E-C8AB-4903-AD34-F39C6D74C889@intel.com> References: <1B893F1B-4DA8-4F88-9583-8C0BAA570832@intel.com> <20170323021502.GA114662@localhost.localdomain> <20170323062433.GA120139@localhost.localdomain> <59AF69C657FD0841A61C55336867B5B066729E3F@IRSMSX103.ger.corp.intel.com> <20170323102135.GA124301@localhost.localdomain> <2601191342CEEE43887BDE71AB9772583FAD410A@IRSMSX109.ger.corp.intel.com> <20170324022310.GA129105@localhost.localdomain> <32FED22E-7116-4B6A-894E-C81CBF7B4BBE@intel.com> <20170324072230.GU18844@yliu-dev.sh.intel.com> <20170324080633.GA2865@localhost.localdomain> <2601191342CEEE43887BDE71AB9772583FAD80A6@IRSMSX109.ger.corp.intel.com> <0C56AF3E-C8AB-4903-AD34-F39C6D74C889@intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/2] lib: add TCP IPv4 GRO support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Mar 2017 14:59:09 -0000 On Fri, 24 Mar 2017 14:37:04 +0000, "Wiles, Keith" wrote: > > On Mar 24, 2017, at 6:43 AM, Ananyev, Konstantin wrote: > > > > > > [...] > > Yep, that's what my take from the beginning: > > Let's develop a librte_gro first and make it successful, then we can think should > > we (and how) put into ethdev layer. > > Let not create a gro library and put the code into librte_net as size is not a concern yet and it is the best place to put the code. As for ip_frag someone can move it into librte_net if someone writes the patch. The size of a library _is_ an argument. Not the binary size in bytes, but its API, because that's what the developper sees. Today, librte_net contains protocol headers definitions and some network helpers, and the API surface is already quite big (look at the number of lines of .h files). I really like having a library name which matches its content. The anwser to "what can I find in librte_gro?" is quite obvious. Regards Olivier