From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0052.outbound.protection.outlook.com [104.47.37.52]) by dpdk.org (Postfix) with ESMTP id D11FDD267 for ; Sat, 25 Mar 2017 06:38:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=DnSsSzzSXDVI3M661aQ3/6tfOr4qhH9v/3reYiXf6iw=; b=iu0lJZUhWK8K6+dQoLvbgx/Q09/B4Vc01AXqawtBYfeVO7zwpaZpUxQtVmvZNxONoHBx/feva4oY41a+a7CZWAFRMUxoHyDtn1YeCPXwUUzAjsEVlfMTeSWILFgigItjbuIxeyA0QadhRltJb2n4OaKItT64RQIcEAxhcrGzc7k= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from localhost.localdomain (171.76.89.237) by BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Sat, 25 Mar 2017 05:38:33 +0000 Date: Sat, 25 Mar 2017 11:08:19 +0530 From: Jerin Jacob To: Harry van Haaren Cc: dev@dpdk.org Message-ID: <20170325053818.jzp5m6hj4sahr5bs@localhost.localdomain> References: <489175012-101439-1-git-send-email-harry.van.haaren@intel.com> <1490374395-149320-1-git-send-email-harry.van.haaren@intel.com> <1490374395-149320-2-git-send-email-harry.van.haaren@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490374395-149320-2-git-send-email-harry.van.haaren@intel.com> User-Agent: NeoMutt/20170306 (1.8.0) X-Originating-IP: [171.76.89.237] X-ClientProxiedBy: PN1PR01CA0020.INDPRD01.PROD.OUTLOOK.COM (10.164.137.27) To BLUPR0701MB1715.namprd07.prod.outlook.com (10.163.85.141) X-MS-Office365-Filtering-Correlation-Id: d3df39e0-ea6d-4a89-99e1-08d473412e29 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001); SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 3:JTA8rI1TPr5QE6W0pD2IRxli0CNCb6mpe8K6U5/17HLTGP+bOGHxNWXbvRJJpXUEyL9DEe4hi4RkoqDBuB/lENap45wdPI/C1PubibJGsjZafxNZlpOJeA6ebj1aeweaek6AOBBVIp3p9ezfpHfMYDdNCTU7GY4Gse624YRyMK7EtCSiRR7j8/+eni0fICTeS1VlYQ/c3agBrJeDgtWQ/ydLxiHTVuRI1/w0DDLvt6qSHj5j/q/ziWKESMH1HP+ynJxPjLJlf8Y+35GkL7SnRg==; 25:wp1ltUJEFAxRSLXEi6nevX1/LBdzZav2DrE9bagrFOmz32oE4gvq/JwS6ciOVeL4ARF2IEP2v1EBvlZJHvNjbhHVvetcVLq5B3UGDHQo5CfQXdV2AAkDfI/U/EvrqCbh+6U/ySi2fZbWjd8soieZRuSHr+gWb8rWEKyaSX17kDQa3QM59ZtSfmeSWCZEYFeeaG9EQVyRQiVJ84dQx3NwSoIHEDDSSeTyxxaPHFrNqlGrq8ZP19EC2EJOn5A5zE2VGACtR87HT4nwGHw0WKExbXZ2SNAP3pXFM3ZkrT9wxlZrr9Q7Dgx99YbMKCTLnGwjShj7k3ZWblZRo4B8FXBBW6BpXtXKow7rXJSU40zv4LKYGBwt9ly39ByFm1PSCoVu1Gdif6321PNly1btQn4DaThpw1S36SfV0FbZ5yYIdYnld2eVH4ZQ5CyjEoTyiReBfPFxF6hHdti/drZqKuxPoA== X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 31:i65zWJKOtFGg3bCZjGsYXI2oRz6OuerWmGruBkoICdi5M2IVOzbP3yRqyaqKzKyoy/s2uzndN3u+Cb6spy9zjjrMyHrrlIDDIpYGtdoubj7zeyIOH5oub1lzJzrTqCSHsRyHBFMumd9hlGyuPsGOUPbUNSeE7g0vafQHheGLkLHMU0wyOzgz7wh52DUagTABp17QYYjw2K9SoS+CeZipf+C9PbEh20hkUW/5N46/nJndnynXsrrkRBy/0ghW49d9bfXZoNBe2DgVJeYjM9O/dq7Fx+otZ/SvTytPj00txIs=; 20:rC3PRxz0Eva2DjltZy3JkAABUhAhBCGKGnByjfOjfjbjNTUwRdGv5VYOSzHweRtwnLUzAB4CfiZudCGr4XLJDLKfzk7mYFwunojDLmkfhuPPC2yjm7Wr1cHFg/xVBb6bcwWIoy7xU9kj8+mC3f2nhMi8FwaB2AkX8pCYz6MmVZy2QB/yi2KKQCJ6oiaHtNdMGk/p6FSmm1mypVO3tm+rRTrdYTe9m9g3qfmbOI+XsffrTnAZFFlOhkUe7jAU3sSX/i+mtVhvVEaevMVNBEtDN+y5DH3BCgKwAtxREDBeFPYnlLr826uL2Tr1LTQeQ+si5El5nW7nDUWeG0hgBtOTjwBexIrdQyBSniP6nPDNiq0UmmcvnEjByytbnOaM6UoOAMolzkm+DviDsbuegvvox/ehrcYVorMRsfa54Ebi91oLe+hsFqCpQoVLaT88hANsxRlU4E8LQvUaXGBQMHVcgB7wH/VHY6hcxXftwUP1qvFFRnJk0ARmhsDX7TkbbSo2RJHuG8k4pRcBV33LjcJ7pXeVA5MOs37vdZoI8bPjowksE1jgqY8r/1hO4Z+k/37y/BzHyUwFNR9k2O51icmJ0tOSjWx3N6bLapY3eIA7EBM= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123558025)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(6072148); SRVR:BLUPR0701MB1715; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1715; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 4:9T2vSedn1nEULwURJJssNjQv9quHpx1rjoaTNmFFvw3WyGRqLQZwiMINssSrCK4To6NIWwxKAq0wLWQqk0M77XYGrw2x2P1wF4cEt+LvKvlLDOPdTchPyPGwL/XxNxs2yXGQR1S1zC86rndw8SUdhQo1mpztivl6dmvxCn07pEP+gq/58P7WT0p9TtYULgXt/zGr1nDAlIRRUrTgE0bxtfTWQPvftl5mCS/X70QsOBKy+oLHSY8qslp7m//ESb1dhs68QdoDubrxB1YJvzyf41BOgth15aQOp/q65ipd/qJDH9/HSUaUQ6/hw9ejQsq21e2Nxl2O3NnboOtPFXHlWNpmNnl7XbqdiUHuiapLApecTQj2dfWyPzDFWvGpNziumXggQjeaY0bahoGQlKR9j6BzT9oP/v86JnTO0wszc24T+8WAQoAwgVC8WVWY4dc2vXndGvX5xEwE7U3f2kvFaBl2rsNwPL5qJolP5FXnNJYPSSe5suvSt+hCGIRuI93cHZrdBrEsnp3gXFJABeOooeBk2Lb1QB3HuYXt0rxQhqFRq//wCHQT8hcepu0jsrVlWkkIT3Dy6EwhJuLrx3iNsYyPvjMynykbMpt2w/jK/qE/eUwxOT1N6KjWSKJ+mZisaX4P3LeI942pjRH563IM1g== X-Forefront-PRVS: 025796F161 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6069001)(6009001)(39450400003)(39410400002)(39830400002)(24454002)(50986999)(42186005)(6306002)(1076002)(4001350100001)(50466002)(53376002)(9686003)(5660300001)(54356999)(966004)(229853002)(3846002)(6506006)(53936002)(2906002)(55016002)(23726003)(76176999)(25786009)(6116002)(110136004)(61506002)(8676002)(81166006)(305945005)(7736002)(38730400002)(66066001)(6916009)(6666003)(42882006)(2950100002)(33646002)(4326008)(6246003)(47776003)(189998001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1715; H:localhost.localdomain; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0701MB1715; 23:sdzyUdwWBBlkAR1bdTm7z7h7xddLmowiol8KahB?= =?us-ascii?Q?IHlPDsZrW9swYyVrpG6y6M4Zxahk5WYA/ArBv4oWOPVOmpojj8BBiaB0icjc?= =?us-ascii?Q?YOAY2jarLVBH9i5j9dU+gn13XM6xe9uBX4ipjiMRlUfQ9OosCLrW9XB09dh2?= =?us-ascii?Q?Cfecq5IqkHa1aawM5elYouXEspYycB9RhEj+DjMoWC9eeZ6ZAr3Ffw652XCn?= =?us-ascii?Q?wKQXLr0Z3/1REHNf4EGNalCTiTbOg0YJdQK1xmWF5j/v5sIT4D9gtR2SgFNq?= =?us-ascii?Q?gakOzJ5BxtmKUyaxeDKG5ph+pafI8wvFpXt0+WTVQk0T63QwCPBUmcPmIFtq?= =?us-ascii?Q?QGoSqzntCkdYWaHWebXaBMBFkF3tKlJn38zV8ip6+upqETJVk+sQbGDk9QL/?= =?us-ascii?Q?MslqXEGFs4H1xqfMcCCs44+4tSZyGfNiZt9nIfyvhMU849gOTpx5YoIt7hPZ?= =?us-ascii?Q?alk/EIvVo+h+10kbo5UCv0a/XTT6LfijdVNOdUa3wZEBw6ZyLPwp4PIiKR8s?= =?us-ascii?Q?2gGliptZlQFE/PAeAikI5yaW2LiAA8jAteln6h8I382ju+y2SGtNUPDsPQKh?= =?us-ascii?Q?OZRkqotIWemxXjaJPnTscREWVG/80m7qyQ8p365apv2UAde/9u7NikzNLoo/?= =?us-ascii?Q?43hkNC0FlxN7YNl1J/qTAhbA3Sgh3IlbzUzfmngTvCWUJY+w4umkVLY3SSDd?= =?us-ascii?Q?loNEIeNE2k0eNFSQbugvCzNVDpN7CKjqUGAG2UfFrF2YKxXQrcOpYc3VzLgP?= =?us-ascii?Q?hn3JR+2BI6WlVMYfzCdzP+YA8wYAPRzlaeUvuaDWF0GSfdeSjOm5vsUo6TXZ?= =?us-ascii?Q?HbqXLyXn/Cjph76EJwn1qvlONrLzAe7sVhN4CVG4BlxZTMToE9DExynfCQaX?= =?us-ascii?Q?yV7PaYasUHqSjSVo7ZfICqgZ9N0ouElrr5Pxz0svEnjEEFCPT2xLGXnE9bbl?= =?us-ascii?Q?URWoRSxMsBHNQ4JyhNhcxBMOqsu38wAVzJDeLBFYDZOH93ogKVk2cmGiggIc?= =?us-ascii?Q?iaenAU24+7SWeb+qhrHo9yL6urFNGWGDel7ZGLc4lcpp0jmGAG6N0z1cIE2u?= =?us-ascii?Q?D7sNNb25WXwHac1LawGLBkGhquAcqReYyA98RHzh5Ffhe7kVk8Q=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 6:6FQ2t+XkSfJgQQoI4a1Y05N6hxv3WSNN5O+9jOd+U7X2OKRFE9t68wH4DCXExfy2S2aeMYtj+SLqBXNe2ISPlLGwXb3CnynWO/WpBZzZc4AawaTolZmGNuP6+5ZN6W9QjZYGR7vKotbQhciu2dpYgOEc0bp9fb9/3fV2eOVD4FjKyYhwM33iNb0GRmd7eqAP8dksZAyWEmUA/bqJkeoJUpTQaucYfTOPyEfSbeW55TOXx9QuXBKlFKx2LZ2pBxMYnmkmN2luofNQGR5XVNDVc9Ew2V6MpBQAKgo40+St3OIPfWjHOMmiZew6q0V6fLIywP0tUkNefx1+uCywvsXv6luebDNMQWiEjwg3yFyT6SUgN8YrMEUTssxgCd/Ld8w+0SmpBWB9oGop+8R+2y/JBA==; 5:DFJIB9x+pd6QhzZlRm0PcidXQFcCVe8sHxtx/Aa+YSRxPYPAfO/bOmNMJJMIyf3ueWEfNrdi8pqrl8al/me7KaONWNGfeYKERDWg+etEvDHat4vbIM1skdnZz0RcTTsaOoJnySipVOhK8s8uIcuGgw==; 24:MtjOJyEFIkXfp6SC/5fOlrDCKb3wHT64pORql0lbKBf7EVtqV7qX2ENPYGkHXFXyWhyMcIoxTMnBd66/FlfoGpMRWBw33jHXGFogTyb15s4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1715; 7:4ea9XJfR2HL+yNj9oVgeP3BkhAsZCQnN7QYuH2QOcQ3D0ONv1cYBC9GlKXOtTpe3Qe/um0opoCMRx4XA20dlse6ZoLm7rCsAm9sHTeo5DSeouRSy5Eh3uIHHj4PIebO/kNeYa7EKldehTDRDDh6FwhvhbYdoUf38bfCd+MXjt8GlZvzJmXckuIc4SYLzRstkxduBOK1yULYuVeMH/h86lvOgTlKF3hRn0snr5Ay0av4zcWmEfl7R6tslBf6+XEJrHMCNAw6z3C99RbrtgKiOiR0S5UvmR+N1oCLqp2Bbp91mJ9ebu78ADHcxFLeqijJNiXA9r/NO+YvygFexSufnbA== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Mar 2017 05:38:33.8285 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1715 Subject: Re: [dpdk-dev] [PATCH v5 01/20] test/eventdev: pass timeout ticks unsupported X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Mar 2017 05:38:38 -0000 On Fri, Mar 24, 2017 at 04:52:56PM +0000, Harry van Haaren wrote: > This commit reworks the return value handling of the > timeout ticks test. This feature is not mandatory for > a pmd, the eventdev layer returns -ENOTSUP if the PMD > doesn't implement the function. > > The test is modified to check if the return value is > -ENOTSUP, and return -ENOTSUP to the test framework, > which can handle "unsupported" tests since patch[1]. > > As such, this test will function correctly if the > patchset linked below is applied, it fails if the > patch is not applied and the PMD doesn't the timeout > ticks function. > > Note it does not depend (as a compile time dependency) > on the patchset linked below. > > Signed-off-by: Harry van Haaren > > [1] http://dpdk.org/dev/patchwork/patch/21979/ > --- > test/test/test_eventdev.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/test/test/test_eventdev.c b/test/test/test_eventdev.c > index 0f1deb6..7067970 100644 > --- a/test/test/test_eventdev.c > +++ b/test/test/test_eventdev.c > @@ -519,9 +519,10 @@ test_eventdev_timeout_ticks(void) > uint64_t timeout_ticks; > > ret = rte_event_dequeue_timeout_ticks(TEST_DEV_ID, 100, &timeout_ticks); > - TEST_ASSERT_SUCCESS(ret, "Fail to get timeout_ticks"); > + if (ret != -ENOTSUP) > + TEST_ASSERT_SUCCESS(ret, "Fail to get timeout_ticks"); > > - return TEST_SUCCESS; > + return -ENOTSUP; It should be "return ret". Otherwise, The test case will return -ENOTSUP irrespective of PMD supports or not. With that change, Acked-by: Jerin Jacob > } > > > -- > 2.7.4 >