From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 59B54FA72 for ; Mon, 27 Mar 2017 12:13:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490609622; x=1522145622; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=flCrSdtatlvCNUYwTXhscHJOch9KmCd9TW7xGE7vIQQ=; b=psF307QbHmataEPY1hb+ZPvMmAR687jxe4h+UhuLGkJwa9fP0u7raCTI G07/ZvzXvw/dg955QZjvDG0S2hKJxg==; Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2017 03:13:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,231,1486454400"; d="scan'208";a="948548821" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.140]) by orsmga003.jf.intel.com with SMTP; 27 Mar 2017 03:13:39 -0700 Received: by (sSMTP sendmail emulation); Mon, 27 Mar 2017 11:13:39 +0100 Date: Mon, 27 Mar 2017 11:13:39 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: olivier.matz@6wind.com, dev@dpdk.org, jerin.jacob@caviumnetworks.com Message-ID: <20170327101338.GA18148@bricha3-MOBL3.ger.corp.intel.com> References: <20170307113217.11077-1-bruce.richardson@intel.com> <20170324171008.29355-1-bruce.richardson@intel.com> <20170324171008.29355-4-bruce.richardson@intel.com> <2476675.J1ds0gYDs0@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2476675.J1ds0gYDs0@xps13> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Re: [dpdk-dev] [PATCH v3 03/14] ring: eliminate duplication of size and mask fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Mar 2017 10:13:43 -0000 On Mon, Mar 27, 2017 at 11:52:58AM +0200, Thomas Monjalon wrote: > 2017-03-24 17:09, Bruce Richardson: > > The size and mask fields are duplicated in both the producer and > > consumer data structures. Move them out of that into the top level > > structure so they are not duplicated. > > > > Signed-off-by: Bruce Richardson > > Acked-by: Olivier Matz > > Sorry Bruce, I encounter this error: > > fatal error: no member named 'size' in 'struct rte_ring_headtail' > if (r->prod.size >= ring_size) { > ~~~~~~~ ^ > Hi Thomas, again I need more information here. I've just revalidated these first three patches doing 7 builds with each one (gcc, clang, debug, shared library, old ABI, default-machine and 32-bit), as well as compiling the apps for gcc and clang, and I see no errors. /Bruce