From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Allain Legacy <allain.legacy@windriver.com>
Cc: mtetsuyah@gmail.com, maxime.coquelin@redhat.com, dev@dpdk.org,
matt.peters@windriver.com,
Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: change mbuf allocation logs to debug
Date: Tue, 28 Mar 2017 14:48:41 +0800 [thread overview]
Message-ID: <20170328064841.GZ18844@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <20170327162930.54281-1-allain.legacy@windriver.com>
On Mon, Mar 27, 2017 at 12:29:30PM -0400, Allain Legacy wrote:
> From: Matt Peters <matt.peters@windriver.com>
>
> The current packet buffer alloc failures of the vhost dequeue operations
> can flood the log system with error logs due to logging a runtime error
> condition within the data path.
I agree that we should avoid flood. But somehow I think it's valueable
to print such message. It could simply mean you don't have enough mbuf
created, or, unlikely, mbuf leak happended.
> In order to prevent this condition, but
> still enable debugging, the logs are being changed to debug logs to ensure
> they are not emitted unless the CONFIG_RTE_LIBRTE_VHOST_DEBUG option is
> enabled.
That basically means you will never see them in real life. I'm suggesting
to add a new log API, RTE_LOG_ONCE. Sounds good?
--yliu
>
> Signed-off-by: Matt Peters <matt.peters@windriver.com>
> Signed-off-by: Allain Legacy <allain.legacy@windriver.com>
> ---
> lib/librte_vhost/virtio_net.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
> index 337470d64..850b56082 100644
> --- a/lib/librte_vhost/virtio_net.c
> +++ b/lib/librte_vhost/virtio_net.c
> @@ -901,7 +901,7 @@ copy_desc_to_mbuf(struct virtio_net *dev, struct vring_desc *descs,
> if (mbuf_avail == 0) {
> cur = rte_pktmbuf_alloc(mbuf_pool);
> if (unlikely(cur == NULL)) {
> - RTE_LOG(ERR, VHOST_DATA, "Failed to "
> + LOG_DEBUG(VHOST_DATA, "Failed to "
> "allocate memory for mbuf.\n");
> return -1;
> }
> @@ -1129,7 +1129,7 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,
>
> pkts[i] = rte_pktmbuf_alloc(mbuf_pool);
> if (unlikely(pkts[i] == NULL)) {
> - RTE_LOG(ERR, VHOST_DATA,
> + LOG_DEBUG(VHOST_DATA,
> "Failed to allocate memory for mbuf.\n");
> break;
> }
> --
> 2.12.1
next prev parent reply other threads:[~2017-03-28 6:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 16:29 Allain Legacy
2017-03-28 6:48 ` Yuanhan Liu [this message]
2017-03-28 11:39 ` Legacy, Allain
2017-03-29 7:01 ` Yuanhan Liu
2017-03-29 22:45 ` Legacy, Allain
2017-03-30 1:49 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170328064841.GZ18844@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=allain.legacy@windriver.com \
--cc=dev@dpdk.org \
--cc=matt.peters@windriver.com \
--cc=maxime.coquelin@redhat.com \
--cc=mtetsuyah@gmail.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).