From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 8E215CF8A for ; Tue, 28 Mar 2017 17:00:17 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id o81so889410wmb.1 for ; Tue, 28 Mar 2017 08:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wV9X6i3L4ELRmDzp1XALR/XvO9cVceUgqANxs7SuA4A=; b=yTPRg2lSPBzoVWun8/1bXI0yREDcxonGQ/lQwKc/WFQgpwPTZ8fcvn5NgNNC6W1ZHF eBdAf9RbPmeCXKYZ/dtBxc/trnXTOQ4K6TI0ef6luXbGhPpPPZ6bQx+Z5p6cxpe95cOQ JxCVKB3xD6g+xytFfmEqWUqtv9ddzrL8TVpTBboA9dwmsaEkJ5bIXlYiMo08NhvUb/wI BKg8wDL+R2lGmfSE9M0am+5ugzlMqb+ASR/7tB5Bh608aOl3aapSlUvBVqvFhzSrw9+h xJAQD6UGmx22B+eTlHR9svBOd3PCypx3+MHwr6RTAAZV5N68hqwFT/tPwWvIKeI0Y0Gw PEaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wV9X6i3L4ELRmDzp1XALR/XvO9cVceUgqANxs7SuA4A=; b=Yip/7FbRIRpOyb9kYNb3wVGllskIF/75jqYD1P0Ynidk1DsJgfWGoEjSUbHkLGnSKm vOcSTZRZO/cqY+WgLS78TB6WEZo4un89sBhf6bUlyTOQ/d2qO8bYeUDlKuyQ7DH7j7kM 5kxy5N6cd6B/ZaLJ7vTlAMMyYC2MiNnxUemEDmqSj/VWpz/jRN7w06XtnDW1KvdxLWxv tzUAZm+Kpa+YxgWkg9M6cZa+2zde/FOLtIiX6FdXaoe1HXYuCeAdlpZESmyPbT2Ki76M Uq0bEh35tDG0gEINxmCkEhzY/lV3awmEeODNET77DOg9WktVdhZgk1ljWYKNnfqld12V zFcw== X-Gm-Message-State: AFeK/H1LqOo7db1NwuYXPaDBmTzLsV/bkTcpxUFba1I45b7Hf6pd50ogvs47S4Sb55uJvZd2 X-Received: by 10.28.10.209 with SMTP id 200mr15128109wmk.126.1490713216912; Tue, 28 Mar 2017 08:00:16 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q4sm4002038wme.17.2017.03.28.08.00.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Mar 2017 08:00:15 -0700 (PDT) Date: Tue, 28 Mar 2017 17:00:07 +0200 From: Adrien Mazarguil To: Ferruh Yigit Cc: Ed Czeck , dev@dpdk.org, john.miller@atomicrules.com, shepard.siegel@atomicrules.com, stephen@networkplumber.org Message-ID: <20170328150007.GJ3790@6wind.com> References: <41265c4fa76265df0144d5d480e4553888df2ee8.1490309515.git.ed.czeck@atomicrules.com> <3d68039422963c92ef6f05ad4bd9b0b3497eb7bd.1490309515.git.ed.czeck@atomicrules.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v5 7/7] net/ark: Arkville PMD component integration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 15:00:17 -0000 On Tue, Mar 28, 2017 at 03:38:13PM +0100, Ferruh Yigit wrote: > On 3/23/2017 11:01 PM, Ed Czeck wrote: > > * Flesh out device configuration > > * Add links dev_ops > > * allow dynamic extension loading > > > > Signed-off-by: Shepard Siegel > > Signed-off-by: John Miller > > Signed-off-by: Ed Czeck [...] > > + /* > > + * We will create additional devices based on the number of requested > > + * ports > > + */ > > + int pc = 1; > > + int p; > > I am aware some people prefer the declaring variables close to context, > which is good idea, but if I remember correct, there was a patchset, > from Adrien, to make DPDK C99 compatible, will this break it? [...] Only replying to this part, declaring variables anywhere is fine since C99, so no problem. This is not the preferred style in DPDK as abusing this sometimes makes the code less readable (can lead to super large functions without consistent code blocks). -- Adrien Mazarguil 6WIND