From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4E7F11396 for ; Wed, 29 Mar 2017 09:04:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490771047; x=1522307047; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=n3dr37fE0HvXWDE/dpNRBJ+7UloGsP22o151I5uZm88=; b=hGXpmHPF7q9kM1WJLKCzJTDteEeE46KDc8wz7Gl8k1uPeFO2LPMZvWxT beYgh/q8ig6wJ05OiX+QWk4qG8C/7g==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2017 00:04:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,240,1486454400"; d="scan'208";a="82181728" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga006.fm.intel.com with ESMTP; 29 Mar 2017 00:04:04 -0700 Date: Wed, 29 Mar 2017 15:01:50 +0800 From: Yuanhan Liu To: "Legacy, Allain" Cc: "mtetsuyah@gmail.com" , "maxime.coquelin@redhat.com" , "dev@dpdk.org" , "Peters, Matt" , Thomas Monjalon Message-ID: <20170329070150.GF18844@yliu-dev.sh.intel.com> References: <20170327162930.54281-1-allain.legacy@windriver.com> <20170328064841.GZ18844@yliu-dev.sh.intel.com> <70A7408C6E1BFB41B192A929744D8523968F8CC8@ALA-MBC.corp.ad.wrs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <70A7408C6E1BFB41B192A929744D8523968F8CC8@ALA-MBC.corp.ad.wrs.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] vhost: change mbuf allocation logs to debug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 07:04:07 -0000 On Tue, Mar 28, 2017 at 11:39:37AM +0000, Legacy, Allain wrote: > > -----Original Message----- > > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > Sent: Tuesday, March 28, 2017 2:49 AM > <...> > > > In order to prevent this condition, but > > > still enable debugging, the logs are being changed to debug logs to ensure > > > they are not emitted unless the CONFIG_RTE_LIBRTE_VHOST_DEBUG > > option is > > > enabled. > > > > That basically means you will never see them in real life. I'm suggesting > > to add a new log API, RTE_LOG_ONCE. Sounds good? > > > Rather than a log what is really needed here is a stat/counter, but this library does not have the infrastructure in place to support reporting datapath errors via stats back to the application. Right. It's supposed to be done in vhost-pmd, while the real Rx implementation is at vhost lib. > Are there any plans to add a stats infrastructure or a desired design for what that would look like? We could have such counter support once we move virtio_net.c to vhost-pmd. Unluckily, I don't think it will happen soon. OTOH, it's still good to have RTE_LOG_ONCE. It explicitly tells you something is wrong, then you could dump those stats for more info. --yliu