DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: "Dai, Wei" <wei.dai@intel.com>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
	"Zhang, Helin" <helin.zhang@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Guo Fengtian" <fengtian.guo@6wind.com>,
	"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset
Date: Wed, 29 Mar 2017 12:08:08 +0200	[thread overview]
Message-ID: <20170329120808.0907926a@platinum> (raw)
In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650A23126@PGSMSX101.gar.corp.intel.com>

Hi Wei,

On Wed, 29 Mar 2017 09:22:55 +0000, "Dai, Wei" <wei.dai@intel.com> wrote:
> First of all, I don't agree the method in this patch because the register can also rewind to 0 in normal mode except
> reset/PF down.
> 
> In the function void ixgbe_down(struct ixgbe_adapter *adapter) of ixgbe_main.c in the ixgbe kernel PF driver (version 5.0.4),
> the PF in kernel driver will ping all the active vfs to let them know PF is going down by mailbox messages.
> 
> On other side, ixgbe VF in DPDK PMD will handle the ping mailbox message in ixgbevf_dev_interrupt_handler( ) which is
> registered interrupt routine. 
> And ixgbevf_dev_interrupt_handler( ) will call ixgbevf_mbx_process( ) to process mailbox message from PF.
> 
> So it is in ixgbevf_mbx_process( ) where the SW stats registers of VF can be fixed.
> There is more than one line to send ping message to VF in kernel PF drvier codes.

Thank you for the explanation.

Just to be sure I correctly understand:
1- the ping message is properly sent by ixgbe pf linux driver
2- the ping message is not yet sent by ixgbe pf dpdk driver
3- the ping message is properly received by ixgbe vf dpdk driver, but
   it is not used yet to stop wrong stats accumulation

> I am studying it to make it clear how to identify the ping message due to PF down.

Are you saying that you are currently working on a fix for 2 and 3 (that
would be great!) or are you expecting that I work on it? In any case, I
can help, at least to test the patches.


> So can we defer this patch first.
> And another patch in above way should be submitted.


I'm of course ok to defer the initial patch, I agree it's more a workaround
than a proper solution. I was stuck because I did not know how the VF is notified
by the PF when it is reset.


Thanks
Olivier

  reply	other threads:[~2017-03-29 10:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11 17:04 Olivier Matz
2017-02-06 13:58 ` Olivier Matz
2017-02-09 14:37   ` Dai, Wei
2017-02-09 14:50   ` Dai, Wei
2017-02-16 16:49     ` Olivier Matz
2017-03-14  9:46       ` Olivier Matz
2017-03-24 14:11         ` Olivier Matz
2017-03-28 15:22           ` Thomas Monjalon
2017-03-29  9:22             ` Dai, Wei
2017-03-29 10:08               ` Olivier Matz [this message]
2017-03-30 10:46                 ` Dai, Wei
2017-03-30 11:58                   ` Olivier Matz
2017-03-29  9:37             ` Dai, Wei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170329120808.0907926a@platinum \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=fengtian.guo@6wind.com \
    --cc=ferruh.yigit@intel.com \
    --cc=helin.zhang@intel.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=thomas.monjalon@6wind.com \
    --cc=wei.dai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).