From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 52200D48B for ; Wed, 29 Mar 2017 15:10:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490793025; x=1522329025; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=zTnHi1sd+Mloe3Yaj3P7weE7BNaVwE41XjqllLIm3bE=; b=ST1Kif8cxaKFnWtUxi0hd69HAoE2N5V+mxH2azfIAiJNsYiNE2lKIPA7 ULPQxK/xANpIJr1hK8O5i1vdH4a7sw==; Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Mar 2017 06:10:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,241,1486454400"; d="scan'208";a="839655147" Received: from sivswdev01.ir.intel.com ([10.237.217.45]) by FMSMGA003.fm.intel.com with ESMTP; 29 Mar 2017 06:09:58 -0700 From: Bruce Richardson To: olivier.matz@6wind.com Cc: dev@dpdk.org, Bruce Richardson Date: Wed, 29 Mar 2017 14:09:27 +0100 Message-Id: <20170329130941.31190-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.8.4 In-Reply-To: <20170328203606.27457-1-bruce.richardson@intel.com> References: <20170328203606.27457-1-bruce.richardson@intel.com> Subject: [dpdk-dev] [PATCH v5 00/14] refactor and cleanup of rte_ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Mar 2017 13:10:25 -0000 This patchset make a set of, sometimes non-backward compatible, cleanup changes to the rte_ring code in order to improve it. The resulting code is shorter, since the existing functions are restructured to reduce code duplication, as well as being more consistent in behaviour. The specific changes made are explained in each patch which makes that change. Changes in V5, p8 & p9 only: * Fixed errors in performance-thread sample app due to missed updates to enqueue/dequeue calls. * Added in missing doxygen comments for new API parameters Changes in V4: * Fixed errors in the crypto PMDs due to missed updates to their enqueue/dequeue calls (p8 & p9). * Updated quota_watermarks documentation to match changed code (p10) Changes in V3: * removed anonymous union for sp_enqueue and sc_dequeue variables (p2) * fixed parameter to dequeue function which was mistakenly named is_mp instead of is_sc (as described in the comments) (p12) * skipped unneeded check in tail pointer update fn for sp/sc operation (p13) Changes in V2: * Eliminated extra cacheline padding where cachelines are 128B * Renamed rte_ring_ht_ptr struct to rte_ring_headtail * Removed missed references to ring watermarks in test code and docs This patchset is largely the same as that posted previously on-list as an RFC: http://dpdk.org/ml/archives/dev/2017-February/thread.html#56982 Changes in V1 from RFC: * Included release notes updates as changes are made in each patch * Fixed some missed comment updates when changing the code * Separated some initial fixup patches from this set to send separately * Dropped the final two patches for an rte_event_ring, as not relevant for this set. That can be done as a separate set later. * The macros for copying the pointers have an extra parameter added, indicating the start of the ring buffer itself. This allows more flexibility for reusing them in other ring implementations. Bruce Richardson (14): ring: remove split cacheline build setting ring: create common structure for prod and cons metadata ring: eliminate duplication of size and mask fields ring: remove debug setting ring: remove the yield when waiting for tail update ring: remove watermark support ring: make bulk and burst fn return vals consistent ring: allow enqueue fns to return free space value ring: allow dequeue fns to return remaining entry count examples/quota_watermark: use ring space for watermarks ring: reduce scope of local variables ring: separate out head index manipulation for enq/deq ring: create common function for updating tail idx ring: make ring struct and enq/deq macros type agnostic app/pdump/main.c | 2 +- config/common_base | 3 - doc/guides/prog_guide/env_abstraction_layer.rst | 5 - doc/guides/prog_guide/ring_lib.rst | 15 - doc/guides/prog_guide/writing_efficient_code.rst | 2 +- doc/guides/rel_notes/release_17_05.rst | 33 + doc/guides/sample_app_ug/quota_watermark.rst | 148 ++-- doc/guides/sample_app_ug/server_node_efd.rst | 2 +- drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 2 +- drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 2 +- drivers/crypto/armv8/rte_armv8_pmd.c | 8 +- drivers/crypto/kasumi/rte_kasumi_pmd.c | 6 +- drivers/crypto/null/null_crypto_pmd.c | 2 +- drivers/crypto/openssl/rte_openssl_pmd.c | 2 +- drivers/crypto/snow3g/rte_snow3g_pmd.c | 6 +- drivers/crypto/zuc/rte_zuc_pmd.c | 4 +- drivers/net/bonding/rte_eth_bond_pmd.c | 3 +- drivers/net/ring/rte_eth_ring.c | 4 +- examples/distributor/main.c | 5 +- examples/load_balancer/runtime.c | 34 +- .../client_server_mp/mp_client/client.c | 9 +- .../client_server_mp/mp_server/main.c | 2 +- examples/packet_ordering/main.c | 13 +- examples/performance-thread/l3fwd-thread/main.c | 8 +- examples/qos_sched/app_thread.c | 14 +- examples/quota_watermark/qw/init.c | 5 +- examples/quota_watermark/qw/main.c | 21 +- examples/quota_watermark/qw/main.h | 1 + examples/quota_watermark/qwctl/commands.c | 4 +- examples/quota_watermark/qwctl/qwctl.c | 2 + examples/quota_watermark/qwctl/qwctl.h | 1 + examples/server_node_efd/node/node.c | 2 +- examples/server_node_efd/server/main.c | 2 +- lib/librte_hash/rte_cuckoo_hash.c | 5 +- lib/librte_mempool/rte_mempool_ring.c | 12 +- lib/librte_pdump/rte_pdump.c | 4 +- lib/librte_port/rte_port_frag.c | 3 +- lib/librte_port/rte_port_ras.c | 2 +- lib/librte_port/rte_port_ring.c | 46 +- lib/librte_ring/rte_ring.c | 76 +- lib/librte_ring/rte_ring.h | 795 ++++++++------------- test/test-pipeline/pipeline_hash.c | 5 +- test/test-pipeline/runtime.c | 19 +- test/test/autotest_test_funcs.py | 7 - test/test/commands.c | 52 -- test/test/test_link_bonding_mode4.c | 6 +- test/test/test_pmd_ring_perf.c | 12 +- test/test/test_ring.c | 704 ++---------------- test/test/test_ring_perf.c | 36 +- test/test/test_table_acl.c | 2 +- test/test/test_table_pipeline.c | 2 +- test/test/test_table_ports.c | 12 +- test/test/virtual_pmd.c | 8 +- 53 files changed, 704 insertions(+), 1476 deletions(-) -- 2.9.3