From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id AB50A10F62 for ; Thu, 30 Mar 2017 13:58:56 +0200 (CEST) Received: by mail-wr0-f172.google.com with SMTP id w43so57414884wrb.0 for ; Thu, 30 Mar 2017 04:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3tDuWQCQcNpazjvlNYUBcPPmzvdGBtM2SUNAZVhZU08=; b=zO6DiEBH65qEuv60hx9NagilDwVjQsbOWHFzTrGdehP0DA5Hmi8ia2JMtg7RdDoO80 lvTCi31w3jdpGW5ELtJ9Di5bJUMOBkw+0R97w9SGtIbTWNrjYg9Q8fOirfNCOEDWHb8e p8ETdgKcXF5gU7kIt53MQKqB3HTwczCrM1H3Ds9WI8IECNxLYMKBTkuoueIWRljgNU4k jj5NJqNU58huAwoLZbql+vAEBJEV/NloZdc4N9i3DQiagX9V9dEi/RQbmcD/JLQMlNoY gOtrwzYI4veuZPTndQnPWLbfmC5h7FnoQWT+6RzCAnRyyUCErkXPYWFBM7Koyba4tgLM uLWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3tDuWQCQcNpazjvlNYUBcPPmzvdGBtM2SUNAZVhZU08=; b=nIQZhsgvYW9RrwvqL8Z0m/+HHcjft4pGMiP1bxArZematyxgnKtM43neDgAjE8KgDY gZDGuTbYDtlOC1s8ArZzWxtkBlzRA+Op6Lnx6ghTXsEfMwykTZ0bNG1KhRScfl3GUxXn DnRexDv8q+ZfrDSSMARuXKGTGwQBUDjTQvjIv2scPN7rR3JBr1phzJNcDYstL6UwAxyq IkjNQPYIXeu1HfYIN8KqQnzE13ujDmScMtAsNDBQgKdHa3cdF8Jmm4P+yfq0bCHqKJC7 KGo8tGq6NBhy9Lhf3d1r1juLh57zOS/pWyfadEKBnpNuJtCK1FVrw63hOKA5LZLWE/ky mXPg== X-Gm-Message-State: AFeK/H00CRd8B+RPE7lgT3XDoW9Bvzq+eUaSXmDY2DBtm/or9BcpE2w3vqx0KAt+noV4UZqV X-Received: by 10.223.155.147 with SMTP id d19mr5051424wrc.21.1490875136309; Thu, 30 Mar 2017 04:58:56 -0700 (PDT) Received: from platinum (2a01cb0c03c651000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:3c6:5100:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id n80sm2547414wrb.24.2017.03.30.04.58.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Mar 2017 04:58:56 -0700 (PDT) Date: Thu, 30 Mar 2017 13:58:53 +0200 From: Olivier Matz To: "Dai, Wei" Cc: Thomas Monjalon , "Zhang, Helin" , "Ananyev, Konstantin" , "dev@dpdk.org" , Guo Fengtian , "Yigit, Ferruh" Message-ID: <20170330135853.3ff18757@platinum> In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650A239EC@PGSMSX101.gar.corp.intel.com> References: <1484154254-31387-1-git-send-email-olivier.matz@6wind.com> <20170314104640.32b06adb@platinum> <20170324151148.5c3d9f9d@platinum> <1981763.1ss0qQn5ig@xps13> <49759EB36A64CF4892C1AFEC9231E8D650A23126@PGSMSX101.gar.corp.intel.com> <20170329120808.0907926a@platinum> <49759EB36A64CF4892C1AFEC9231E8D650A239EC@PGSMSX101.gar.corp.intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbevf: fix stats update after a PF reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 11:58:56 -0000 Hi Wei, On Thu, 30 Mar 2017 10:46:45 +0000, "Dai, Wei" wrote: > HI, Olivier > > > > > Hi Wei, > > > > On Wed, 29 Mar 2017 09:22:55 +0000, "Dai, Wei" wrote: > > > First of all, I don't agree the method in this patch because the > > > register can also rewind to 0 in normal mode except reset/PF down. > > > > > > In the function void ixgbe_down(struct ixgbe_adapter *adapter) of > > > ixgbe_main.c in the ixgbe kernel PF driver (version 5.0.4), the PF in kernel > > driver will ping all the active vfs to let them know PF is going down by mailbox > > messages. > > > > > > On other side, ixgbe VF in DPDK PMD will handle the ping mailbox > > > message in ixgbevf_dev_interrupt_handler( ) which is registered interrupt > > routine. > > > And ixgbevf_dev_interrupt_handler( ) will call ixgbevf_mbx_process( ) to > > process mailbox message from PF. > > > > > > So it is in ixgbevf_mbx_process( ) where the SW stats registers of VF can be > > fixed. > > > There is more than one line to send ping message to VF in kernel PF drvier > > codes. > > > > Thank you for the explanation. > > > > Just to be sure I correctly understand: > > 1- the ping message is properly sent by ixgbe pf linux driver > Yes, I think so. > > > 2- the ping message is not yet sent by ixgbe pf dpdk driver > I have not find any codes in DPDK PF to send them. > > > 3- the ping message is properly received by ixgbe vf dpdk driver, but > > it is not used yet to stop wrong stats accumulation > Yes, need register some callback function on to handle it. > > > > > > I am studying it to make it clear how to identify the ping message due to PF > > down. > > > > Are you saying that you are currently working on a fix for 2 and 3 (that would be > > great!) or are you expecting that I work on it? In any case, I can help, at least > > to test the patches. > > I am working on it now. Need check both ixgbe kernel driver and DPDK driver and also > need look up some pages in datasheet including 82599, X540 and X550. > So it is not an easy task. > By the way, not only statistics function but also other configurations should be > restored. > > Anyway, I always appreciate your help. Of course, you can help me test my upcoming patches. Great, thank you. Please CC me when you send the patches, I'll test them. Regards, Olivier