From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A309EDE0 for ; Sat, 1 Apr 2017 07:16:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491023765; x=1522559765; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=RCXBE4LrbkMzQtmq+hIlaFMDFCZaL6ND08SqPx5Zi6c=; b=TdsSibn38fQGiusuEkffx6uE31zgOYktpuffC0lugMX5C7SIFM3UxqbD OgZAJCJ4/7A/TIfCr30BLmR0wJ2gsA==; Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2017 22:16:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,255,1486454400"; d="scan'208";a="81634719" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by orsmga005.jf.intel.com with ESMTP; 31 Mar 2017 22:16:02 -0700 Date: Sat, 1 Apr 2017 13:13:40 +0800 From: Yuanhan Liu To: Jianfeng Tan Cc: dev@dpdk.org, david.marchand@6wind.com, maxime.coquelin@redhat.com Message-ID: <20170401051340.GO18844@yliu-dev.sh.intel.com> References: <1488563803-87754-1-git-send-email-jianfeng.tan@intel.com> <1490989498-87546-1-git-send-email-jianfeng.tan@intel.com> <1490989498-87546-6-git-send-email-jianfeng.tan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1490989498-87546-6-git-send-email-jianfeng.tan@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v3 5/5] net/virtio-user: add lsc support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 01 Apr 2017 05:16:06 -0000 On Fri, Mar 31, 2017 at 07:44:58PM +0000, Jianfeng Tan wrote: > +static void virtio_user_delayed_handler(void *param) Coding style issue. ... > > if (offset == offsetof(struct virtio_net_config, max_virtqueue_pairs)) > *(uint16_t *)dst = dev->max_queue_pairs; > @@ -319,7 +362,11 @@ virtio_user_eth_dev_alloc(const char *name) > > dev->portid = hw->port_id = data->port_id; > virtio_hw_internal[hw->port_id].vtpci_ops = &virtio_user_ops; > - hw->use_msix = 0; > + /* After commit 26bbd3e7dc51("net/virtio: disable LSC interrupt if MSIX > + * not enabled"), we require this to enable LSC. Just pretend that we > + * support msix. > + */ We normally do not reference a commit in comments. Instead, you could simply say "this is required to enable LSC (see __the_function__), ...". Series applied to dpdk-next-virtio, with above minor fixes. --yliu > + hw->use_msix = 1; > hw->modern = 0; > hw->use_simple_rxtx = 0; > hw->virtio_user_dev = dev; > -- > 2.7.4