DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH v2] pci: fix glibc 2.25 warning regarding major/minor definitions
@ 2017-04-04 12:36 Nirmoy Das
  2017-04-04 12:53 ` Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Nirmoy Das @ 2017-04-04 12:36 UTC (permalink / raw)
  To: dev; +Cc: Nirmoy Das

fix below warning:
error: In the GNU C Library, "makedev" is defined
by <sys/sysmacros.h>. For historical compatibility, it is
currently defined by <sys/types.h> as well, but we plan to
remove this soon. To use "makedev", include <sys/sysmacros.h>
directly. If you did not intend to use a system-defined macro
"makedev", you should undefine it after including <sys/types.h>. [-Werror]
dev = makedev(major, minor);
             ^~~~~~~~~~~~~~~~~

Signed-off-by: Nirmoy Das <ndas@suse.de>
---
 lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
index 20a4a665e..af0a4a9bc 100644
--- a/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
+++ b/lib/librte_eal/linuxapp/eal/eal_pci_uio.c
@@ -39,6 +39,7 @@
 #include <sys/stat.h>
 #include <sys/mman.h>
 #include <linux/pci_regs.h>
+#include <sys/sysmacros.h>
 
 #if defined(RTE_ARCH_X86)
 #include <sys/io.h>
-- 
2.12.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH v2] pci: fix glibc 2.25 warning regarding major/minor definitions
  2017-04-04 12:36 [dpdk-dev] [PATCH v2] pci: fix glibc 2.25 warning regarding major/minor definitions Nirmoy Das
@ 2017-04-04 12:53 ` Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2017-04-04 12:53 UTC (permalink / raw)
  To: Nirmoy Das; +Cc: dev

2017-04-04 14:36, Nirmoy Das:
> fix below warning:
> error: In the GNU C Library, "makedev" is defined
> by <sys/sysmacros.h>. For historical compatibility, it is
> currently defined by <sys/types.h> as well, but we plan to
> remove this soon. To use "makedev", include <sys/sysmacros.h>
> directly. If you did not intend to use a system-defined macro
> "makedev", you should undefine it after including <sys/types.h>. [-Werror]
> dev = makedev(major, minor);
>              ^~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Nirmoy Das <ndas@suse.de>

Just applied the same patch from Jerin:
	http://dpdk.org/patch/23136

Thank you anyway

PS: please use --in-reply-to when sending a v2

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-04-04 12:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-04 12:36 [dpdk-dev] [PATCH v2] pci: fix glibc 2.25 warning regarding major/minor definitions Nirmoy Das
2017-04-04 12:53 ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).