From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Zhiyong Yang <zhiyong.yang@intel.com>
Cc: dev@dpdk.org, maxime.coquelin@redhat.com
Subject: Re: [dpdk-dev] [PATCH 0/2] net/virtio: support to turn on/off the traffic flow
Date: Thu, 6 Apr 2017 11:59:53 +0800 [thread overview]
Message-ID: <20170406035953.GM18844@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1490960419-16779-1-git-send-email-zhiyong.yang@intel.com>
On Fri, Mar 31, 2017 at 07:40:17PM +0800, Zhiyong Yang wrote:
> Current dpdk code virtio_dev_stop only disables interrupt and marks link down,
> When it is invoked, tx/rx traffic flows still work. This is a strange behavior.
> The patchset supports the switch of flow by calling virtio_dev_start/stop.
>
> The implementation refers to vhost pmd.
That's a difference story. Vhost pmd uses 2 vars to track the
status, whereas you are using only one here. So why not
setting/clearing "started" at dev_start/stop, respectively?
Then we can check "started" at Rx/Tx functions.
BTW, why does it have to be atomic?
--yliu
>
> Zhiyong Yang (2):
> net/virtio: add data elements to turn on/off traffic flow
> net/virtio: support to turn on/off the traffic flow
>
> drivers/net/virtio/virtio_ethdev.c | 37 +++++++++++++++++++++++++++-
> drivers/net/virtio/virtio_pci.h | 1 +
> drivers/net/virtio/virtio_rxtx.c | 12 +++++++++
> drivers/net/virtio/virtio_rxtx.h | 6 +++++
> drivers/net/virtio/virtio_rxtx_simple.c | 4 +++
> drivers/net/virtio/virtio_rxtx_simple_neon.c | 5 +++-
> drivers/net/virtio/virtio_rxtx_simple_sse.c | 5 +++-
> drivers/net/virtio/virtio_user_ethdev.c | 1 +
> 8 files changed, 68 insertions(+), 3 deletions(-)
>
> --
> 2.7.4
next prev parent reply other threads:[~2017-04-06 4:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 11:40 Zhiyong Yang
2017-03-31 11:40 ` [dpdk-dev] [PATCH 1/2] net/virtio: add data elements to turn on/off " Zhiyong Yang
2017-04-19 6:29 ` [dpdk-dev] [PATCH v2] net/virtio: support " Zhiyong Yang
2017-04-26 7:45 ` Maxime Coquelin
2017-04-26 7:56 ` Yuanhan Liu
2017-04-26 8:02 ` Maxime Coquelin
2017-03-31 11:40 ` [dpdk-dev] [PATCH 2/2] net/virtio: support to turn on/off the " Zhiyong Yang
2017-04-06 3:59 ` Yuanhan Liu [this message]
2017-04-17 8:50 ` [dpdk-dev] [PATCH 0/2] " Yang, Zhiyong
2017-04-19 2:03 ` Yuanhan Liu
2017-04-19 2:31 ` Yang, Zhiyong
2017-04-19 2:58 ` Yuanhan Liu
2017-04-19 5:27 ` Yang, Zhiyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406035953.GM18844@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=zhiyong.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).