From: Santosh Shukla <santosh.shukla@caviumnetworks.com>
To: olivier.matz@6wind.com, dev@dpdk.org
Cc: hemant.agrawal@nxp.com, shreyansh.jain@nxp.com,
Santosh Shukla <santosh.shukla@caviumnetworks.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2 1/2] test/mempool_perf: Free mempool on exit
Date: Thu, 6 Apr 2017 12:15:48 +0530 [thread overview]
Message-ID: <20170406064549.7966-1-santosh.shukla@caviumnetworks.com> (raw)
In-Reply-To: <1491382264-23489-1-git-send-email-santosh.shukla@caviumnetworks.com>
Mempool_perf test not freeing pool memory.
Cc: stable@dpdk.org
Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>
---
v1 --> v2:
* Fixed patch context
test/test/test_mempool_perf.c | 31 +++++++++++++++++++------------
1 file changed, 19 insertions(+), 12 deletions(-)
diff --git a/test/test/test_mempool_perf.c b/test/test/test_mempool_perf.c
index ebf1721ac..3c45971ab 100644
--- a/test/test/test_mempool_perf.c
+++ b/test/test/test_mempool_perf.c
@@ -312,6 +312,8 @@ do_one_mempool_test(unsigned cores)
static int
test_mempool_perf(void)
{
+ int ret = -1;
+
rte_atomic32_init(&synchro);
/* create a mempool (without cache) */
@@ -322,7 +324,7 @@ test_mempool_perf(void)
my_obj_init, NULL,
SOCKET_ID_ANY, 0);
if (mp_nocache == NULL)
- return -1;
+ goto err;
/* create a mempool (with cache) */
if (mp_cache == NULL)
@@ -333,33 +335,33 @@ test_mempool_perf(void)
my_obj_init, NULL,
SOCKET_ID_ANY, 0);
if (mp_cache == NULL)
- return -1;
+ goto err;
/* performance test with 1, 2 and max cores */
printf("start performance test (without cache)\n");
mp = mp_nocache;
if (do_one_mempool_test(1) < 0)
- return -1;
+ goto err;
if (do_one_mempool_test(2) < 0)
- return -1;
+ goto err;
if (do_one_mempool_test(rte_lcore_count()) < 0)
- return -1;
+ goto err;
/* performance test with 1, 2 and max cores */
printf("start performance test (with cache)\n");
mp = mp_cache;
if (do_one_mempool_test(1) < 0)
- return -1;
+ goto err;
if (do_one_mempool_test(2) < 0)
- return -1;
+ goto err;
if (do_one_mempool_test(rte_lcore_count()) < 0)
- return -1;
+ goto err;
/* performance test with 1, 2 and max cores */
printf("start performance test (with user-owned cache)\n");
@@ -367,17 +369,22 @@ test_mempool_perf(void)
use_external_cache = 1;
if (do_one_mempool_test(1) < 0)
- return -1;
+ goto err;
if (do_one_mempool_test(2) < 0)
- return -1;
+ goto err;
if (do_one_mempool_test(rte_lcore_count()) < 0)
- return -1;
+ goto err;
rte_mempool_list_dump(stdout);
- return 0;
+ ret = 0;
+
+err:
+ rte_mempool_free(mp_cache);
+ rte_mempool_free(mp_nocache);
+ return ret;
}
REGISTER_TEST_COMMAND(mempool_perf_autotest, test_mempool_perf);
--
2.11.0
next prev parent reply other threads:[~2017-04-06 6:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-05 8:51 [dpdk-dev] [PATCH " Santosh Shukla
2017-04-05 8:51 ` [dpdk-dev] [PATCH 2/2] test/mempool_perf: support default mempool autotest Santosh Shukla
2017-04-05 10:02 ` Shreyansh Jain
2017-04-05 12:40 ` santosh
2017-04-05 9:57 ` [dpdk-dev] [PATCH 1/2] test/mempool_perf: Free mempool on exit Shreyansh Jain
2017-04-05 12:33 ` santosh
2017-04-06 6:45 ` Santosh Shukla [this message]
2017-04-06 6:45 ` [dpdk-dev] [PATCH v2 2/2] test/mempool_perf: support default mempool autotest Santosh Shukla
2017-04-07 15:51 ` [dpdk-dev] [PATCH v2 1/2] test/mempool_perf: Free mempool on exit Olivier Matz
[not found] ` <BLUPR0701MB17140B8FD2D59B1A7835769FEA0E0@BLUPR0701MB1714.namprd07.prod.outlook.com>
[not found] ` <d0ea6fc4-7cbb-8766-616e-097c4e0fbb14@caviumnetworks.com>
2017-04-10 20:09 ` Olivier MATZ
2017-04-18 8:34 ` [dpdk-dev] [PATCH v3 1/3] test/test/mempool_perf: Remove mempool global vars Santosh Shukla
2017-04-18 8:34 ` [dpdk-dev] [PATCH v3 2/3] test/test/mempool_perf: Free mempool on exit Santosh Shukla
2017-04-18 8:34 ` [dpdk-dev] [PATCH v3 3/3] test/test/mempool_perf: support default mempool autotest Santosh Shukla
2017-04-18 13:42 ` [dpdk-dev] [PATCH v3 1/3] test/test/mempool_perf: Remove mempool global vars Olivier MATZ
2017-04-18 14:39 ` santosh
2017-04-18 14:41 ` [dpdk-dev] [PATCH v4 " Santosh Shukla
2017-04-18 14:41 ` [dpdk-dev] [PATCH v4 2/3] test/test/mempool_perf: Free mempool on exit Santosh Shukla
2017-04-18 14:41 ` [dpdk-dev] [PATCH v4 3/3] test/test/mempool_perf: support default mempool autotest Santosh Shukla
2017-04-18 15:31 ` [dpdk-dev] [PATCH v4 1/3] test/test/mempool_perf: Remove mempool global vars Olivier MATZ
2017-04-19 12:48 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170406064549.7966-1-santosh.shukla@caviumnetworks.com \
--to=santosh.shukla@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=olivier.matz@6wind.com \
--cc=shreyansh.jain@nxp.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).