From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 3E7D22B9B for ; Fri, 7 Apr 2017 14:30:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491568202; x=1523104202; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=gks1W7QEGANzRDcb5h1c1I3Q8ostKwKsaL0TFRAOoys=; b=kqHMvIdC/g/NNIIzgKeAtQi5rW14nJY9XR+zbTOYmoRZx/VtW+ocNBh9 fvgE0Ts3yvOVdG736VIFQw9ttTtSsQ==; Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Apr 2017 05:30:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,165,1488873600"; d="scan'208";a="953351713" Received: from bricha3-mobl3.ger.corp.intel.com ([10.237.221.140]) by orsmga003.jf.intel.com with SMTP; 07 Apr 2017 05:29:59 -0700 Received: by (sSMTP sendmail emulation); Fri, 07 Apr 2017 13:29:57 +0100 Date: Fri, 7 Apr 2017 13:29:57 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: Andriy Berestovskyy , dev@dpdk.org Message-ID: <20170407122956.GA26192@bricha3-MOBL3.ger.corp.intel.com> References: <1490288768-8114-1-git-send-email-Andriy.Berestovskyy@cavium.com> <1491562925-27247-1-git-send-email-Andriy.Berestovskyy@caviumnetworks.com> <7103767.xpENpphzvJ@xps13> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7103767.xpENpphzvJ@xps13> Organization: Intel Research and =?iso-8859-1?Q?De=ACvel?= =?iso-8859-1?Q?opment?= Ireland Ltd. User-Agent: Mutt/1.8.0 (2017-02-23) Subject: Re: [dpdk-dev] [PATCH v3] ether: use a default for max Rx frame size in configure() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Apr 2017 12:30:02 -0000 On Fri, Apr 07, 2017 at 02:15:47PM +0200, Thomas Monjalon wrote: > 2017-04-07 13:02, Andriy Berestovskyy: > > At the moment rte_eth_dev_configure() behaves inconsistent: > > - for normal frames: zero max_rx_pkt_len uses a default > > - for jumbo frames: zero max_rx_pkt_len gives an error > > > > This patch fixes this inconsistency by using a default value > > if max_rx_pkt_len is zero both for normal and jumbo frames. > > > > Signed-off-by: Andriy Berestovskyy > > --- > > > > Notes: > > v3 changes: > > - use a default only if max_rx_pkt_len is zero > > Looks good. > > Acked-by: Thomas Monjalon > > It is a small API change but it is fixing an inconsistency, > so I think it can be integrated in 17.05-rc2 as is. > Any different opinion? Is this entirely hidden from drivers? As I said previously, I believe NICs using ixgbe/i40e etc. only use the frame size value when the jumbo frame flag is set. That may lead to further inconsistent behaviour unless all NICs are set up to behave as expected too. /Bruce