DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: pvp: fix typo in host's testpmd command line
@ 2017-04-07 15:06 Maxime Coquelin
  2017-04-10  7:54 ` Mcnamara, John
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Coquelin @ 2017-04-07 15:06 UTC (permalink / raw)
  To: dev, john.mcnamara; +Cc: jfreiman, Maxime Coquelin

This patch adds missing backslash in host's testpmd command
line.

Without it the command works, but a single core is used
instead of four, which might create confusion.

Fixes: 58a2551a160f ("doc: introduce PVP reference benchmark")

Cc: John McNamara <john.mcnamara@intel.com>
Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 doc/guides/howto/pvp_reference_benchmark.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/guides/howto/pvp_reference_benchmark.rst b/doc/guides/howto/pvp_reference_benchmark.rst
index 6d514ff..208e4c7 100644
--- a/doc/guides/howto/pvp_reference_benchmark.rst
+++ b/doc/guides/howto/pvp_reference_benchmark.rst
@@ -158,7 +158,7 @@ Testpmd launch
       $RTE_SDK/install/bin/testpmd -l 0,2,3,4,5 --socket-mem=1024 -n 4 \
           --vdev 'net_vhost0,iface=/tmp/vhost-user1' \
           --vdev 'net_vhost1,iface=/tmp/vhost-user2' -- \
-          --portmask=f --disable-hw-vlan -i --rxq=1 --txq=1
+          --portmask=f --disable-hw-vlan -i --rxq=1 --txq=1 \
           --nb-cores=4 --forward-mode=io
 
    With this command, isolated CPUs 2 to 5 will be used as lcores for PMD threads.
-- 
2.9.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: pvp: fix typo in host's testpmd command line
  2017-04-07 15:06 [dpdk-dev] [PATCH] doc: pvp: fix typo in host's testpmd command line Maxime Coquelin
@ 2017-04-10  7:54 ` Mcnamara, John
  2017-04-21  0:46   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Mcnamara, John @ 2017-04-10  7:54 UTC (permalink / raw)
  To: Maxime Coquelin, dev; +Cc: jfreiman



> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Friday, April 7, 2017 4:06 PM
> To: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
> Cc: jfreiman@redhat.com; Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH] doc: pvp: fix typo in host's testpmd command line
> 
> This patch adds missing backslash in host's testpmd command line.
> 
> Without it the command works, but a single core is used instead of four,
> which might create confusion.
> 
> Fixes: 58a2551a160f ("doc: introduce PVP reference benchmark")
> 
> Cc: John McNamara <john.mcnamara@intel.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Acked-by: John McNamara <john.mcnamara@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] doc: pvp: fix typo in host's testpmd command line
  2017-04-10  7:54 ` Mcnamara, John
@ 2017-04-21  0:46   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-04-21  0:46 UTC (permalink / raw)
  To: Maxime Coquelin; +Cc: dev, Mcnamara, John, jfreiman

10/04/2017 09:54, Mcnamara, John:
> > -----Original Message-----
> > From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> > Sent: Friday, April 7, 2017 4:06 PM
> > To: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>
> > Cc: jfreiman@redhat.com; Maxime Coquelin <maxime.coquelin@redhat.com>
> > Subject: [PATCH] doc: pvp: fix typo in host's testpmd command line
> > 
> > This patch adds missing backslash in host's testpmd command line.
> > 
> > Without it the command works, but a single core is used instead of four,
> > which might create confusion.
> > 
> > Fixes: 58a2551a160f ("doc: introduce PVP reference benchmark")
> > 
> > Cc: John McNamara <john.mcnamara@intel.com>
> > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-04-21  0:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-07 15:06 [dpdk-dev] [PATCH] doc: pvp: fix typo in host's testpmd command line Maxime Coquelin
2017-04-10  7:54 ` Mcnamara, John
2017-04-21  0:46   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).