DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH 03/11] vhost: remove unnecessary cast of void pointer
Date: Fri,  7 Apr 2017 13:44:49 -0400	[thread overview]
Message-ID: <20170407174457.4180-4-stephen@networkplumber.org> (raw)
In-Reply-To: <20170407174457.4180-1-stephen@networkplumber.org>

Remove unnecessary casts of void * pointers to a specfic type.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_vhost/virtio_net.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
index d6b7c7a22..b9f216842 100644
--- a/lib/librte_vhost/virtio_net.c
+++ b/lib/librte_vhost/virtio_net.c
@@ -629,14 +629,14 @@ parse_ethernet(struct rte_mbuf *m, uint16_t *l4_proto, void **l4_hdr)
 
 	switch (ethertype) {
 	case ETHER_TYPE_IPv4:
-		ipv4_hdr = (struct ipv4_hdr *)l3_hdr;
+		ipv4_hdr = l3_hdr;
 		*l4_proto = ipv4_hdr->next_proto_id;
 		m->l3_len = (ipv4_hdr->version_ihl & 0x0f) * 4;
 		*l4_hdr = (char *)l3_hdr + m->l3_len;
 		m->ol_flags |= PKT_TX_IPV4;
 		break;
 	case ETHER_TYPE_IPv6:
-		ipv6_hdr = (struct ipv6_hdr *)l3_hdr;
+		ipv6_hdr = l3_hdr;
 		*l4_proto = ipv6_hdr->proto;
 		m->l3_len = sizeof(struct ipv6_hdr);
 		*l4_hdr = (char *)l3_hdr + m->l3_len;
@@ -686,7 +686,7 @@ vhost_dequeue_offload(struct virtio_net_hdr *hdr, struct rte_mbuf *m)
 		switch (hdr->gso_type & ~VIRTIO_NET_HDR_GSO_ECN) {
 		case VIRTIO_NET_HDR_GSO_TCPV4:
 		case VIRTIO_NET_HDR_GSO_TCPV6:
-			tcp_hdr = (struct tcp_hdr *)l4_hdr;
+			tcp_hdr = l4_hdr;
 			m->ol_flags |= PKT_TX_TCP_SEG;
 			m->tso_segsz = hdr->gso_size;
 			m->l4_len = (tcp_hdr->data_off & 0xf0) >> 2;
-- 
2.11.0

  parent reply	other threads:[~2017-04-07 17:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-07 17:44 [dpdk-dev] [PATCH 00/11] remove unnecessary cast of void pointers Stephen Hemminger
2017-04-07 17:44 ` [dpdk-dev] [PATCH 01/11] table: remove unnecessary void cast Stephen Hemminger
2017-04-07 17:44 ` [dpdk-dev] [PATCH 02/11] kni: remove unnecessary cast of void pointers Stephen Hemminger
2017-04-10  9:29   ` Ferruh Yigit
2017-04-07 17:44 ` Stephen Hemminger [this message]
2017-04-07 17:44 ` [dpdk-dev] [PATCH 04/11] port: " Stephen Hemminger
2017-04-07 17:44 ` [dpdk-dev] [PATCH 05/11] crypto: remove unnecessary cast of void pointer Stephen Hemminger
2017-04-07 17:44 ` [dpdk-dev] [PATCH 06/11] acl: " Stephen Hemminger
2017-04-07 17:44 ` [dpdk-dev] [PATCH 07/11] eal: " Stephen Hemminger
2017-04-07 17:44 ` [dpdk-dev] [PATCH 08/11] net: remmove " Stephen Hemminger
2017-04-07 17:44 ` [dpdk-dev] [PATCH 09/11] ether: remove " Stephen Hemminger
2017-04-07 17:44 ` [dpdk-dev] [PATCH 10/11] mempool: " Stephen Hemminger
2017-04-07 17:44 ` [dpdk-dev] [PATCH 11/11] test: " Stephen Hemminger
2017-04-08 19:42 ` [dpdk-dev] [PATCH 00/11] remove unnecessary cast of void pointers Thomas Monjalon
2017-04-11 16:06 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170407174457.4180-4-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).