From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 8C2692BB0 for ; Tue, 11 Apr 2017 14:56:14 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id o81so62636628wmb.1 for ; Tue, 11 Apr 2017 05:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YVYSVBOQ4JjAWijKXkL0h9j45EWZ5GTaUwLpzcwJPMo=; b=TjXQK+O2O5aZB/o2WREwkmpyGFXOoKG1kZrOCU3FQFQP6qha+2YhQE1HNecZsTXzQp /gUhb+MUGsnNH1tiTU4i+5zFRMnwkptesjZ2Uyd8nOEgI6m084ZdzFTfg9dnS5iciP06 vj+MZZJ1K1NgQZJurqLHvJknh57riJJGJtejZQgD8OoxW7/ANwjKPFBgjIIIGchnTA1Z vUyZoVX3AM9v8MfhAcZyzCjHWc5ZPz+m03fGubycIzzCYjk7llEmWhaRhdZtxJv8metL of7LDGnhHBmTZz0Q4pOQYHLoS6IdIsJCuCZddwz3Hd4Y9YcpaOGYK2y0dVRZTNXyOR9V KDIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YVYSVBOQ4JjAWijKXkL0h9j45EWZ5GTaUwLpzcwJPMo=; b=oSJVIwhdOlAqyR6z6XAZkHzIXLQSF4IjT0RmRT13883cC5RLsrleivlNf88XRz8NPj b/cA90+EB/72pl7LD+mliyOXDdfY4fuL8+tTSLS/qB6BwCuvjl3qGWgvHivd74PFuU5F RBUMoVH90lVqZ6nob9J/9bjFNlyyqvm7gmH0MqAjMa79wn2dEU2PY+sc3XvCOMCFltVM r/2FKV51Jb3X8M+Ko85atGRuun1DSP2ie0cuBOYN6Ts2nJbKffJ3oRYoZA9mFeYs/4pa KBccuJ6sXCzAsywMhFOh4Hd5MH4tRBAm+lX9ffj2nOiLJ/2YA9S/z5SZQm77QTzNi3a+ 6tcA== X-Gm-Message-State: AN3rC/7qkuZvql018c3u9HAqdEQmKTukCsxKfiux/qVRILi+S1t/0fqn 20Q//tFHUXFmN5hj X-Received: by 10.28.59.69 with SMTP id i66mr14054607wma.42.1491915374147; Tue, 11 Apr 2017 05:56:14 -0700 (PDT) Received: from neon (bc535-h01-176-146-114-125.dsl.sta.abo.bbox.fr. [176.146.114.125]) by smtp.gmail.com with ESMTPSA id d17sm2396029wmi.21.2017.04.11.05.56.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 11 Apr 2017 05:56:13 -0700 (PDT) Date: Tue, 11 Apr 2017 14:56:12 +0200 From: Olivier MATZ To: Thomas Monjalon Cc: Ferruh Yigit , Hemant Agrawal , dev@dpdk.org, shreyansh.jain@nxp.com Message-ID: <20170411145612.4bd8ed34@neon> In-Reply-To: <1526541.obk11Y6NX2@xps13> References: <1489754838-1455-2-git-send-email-hemant.agrawal@nxp.com> <21940728.tivBTtkBCF@xps13> <5f4fe240-8f17-0d4f-04b7-a8dd04b2c16e@intel.com> <1526541.obk11Y6NX2@xps13> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] mempool/dpaa2: add DPAA2 hardware offloaded mempool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Apr 2017 12:56:14 -0000 On Tue, 11 Apr 2017 14:50:14 +0200 Thomas Monjalon wrote: > 2017-04-11 09:39, Ferruh Yigit: > > On 4/11/2017 8:50 AM, Thomas Monjalon wrote: > > > 2017-04-11 11:28, Hemant Agrawal: > > >> On 4/11/2017 1:28 AM, Olivier MATZ wrote: > > >>> Hemant Agrawal wrote: > > >>>> --- a/drivers/bus/Makefile > > >>>> +++ b/drivers/bus/Makefile > > >>>> @@ -33,6 +33,10 @@ include $(RTE_SDK)/mk/rte.vars.mk > > >>>> > > >>>> core-libs := librte_eal librte_mbuf librte_mempool librte_ring librte_ether > > >>>> > > >>>> +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL),y) > > >>>> +CONFIG_RTE_LIBRTE_FSLMC_BUS = $(CONFIG_RTE_LIBRTE_DPAA2_MEMPOOL) > > >>>> +endif > > >>>> + > > >>>> DIRS-$(CONFIG_RTE_LIBRTE_FSLMC_BUS) += fslmc > > >>>> DEPDIRS-fslmc = ${core-libs} > > >>>> > > >>> > > >>> What's the purpose of this? > > >>> Not sure we are allowed to modify the configs in the Makefiles. > > >> > > >> DPAA2_MEMPOOL will not work without the DPAA2 mempool hw instance > > >> detected on FSLMC_BUS. > > >> So, it is required that if you are enabling DPAA2_MEMPOOL, FSLMC_BUS is > > >> to be enabled. > > >> > > >> Currently the config structure do not provide such dependency definitions. > > >> > > >> This was done based on the suggestions on the initial patches from > > >> Ferruh and Jerin. > > > > > > Please do not do that. > > > We do not change the configuration in the back of the user. > > > This kind of dependency should be managed in the configuration step > > > which do not exist yet. > > > > > > You can use $(error) to stop the compilation instead. > > > > As Hemant mentioned, this was my suggestion. There is a configuration > > dependency here, that we don't have a way to resolve in dpdk. > > > > If one of the end leaf selected, it makes sense to me to auto select > > dependent pieces. > > A dependency must be solved at configuration time with appropriate > user notification. > For now, we just check them at compilation time and throw an error. Yes, a good reason for not doing this is because the "make config" generates a rte_config.h file. Changing a configuration option at one place in a Makefile makes configuration inconsistent. I don't think it's a blocker issue for the patch integration. Regards, Olivier