From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f174.google.com (mail-pf0-f174.google.com [209.85.192.174]) by dpdk.org (Postfix) with ESMTP id 68C98F94 for ; Wed, 12 Apr 2017 18:09:34 +0200 (CEST) Received: by mail-pf0-f174.google.com with SMTP id i5so15911912pfc.2 for ; Wed, 12 Apr 2017 09:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LSJYdZTXUyAfpG0I6iSKQygIREjAACJ5S6Chxd1rh34=; b=MzI7t7Hssy49Y2kS4iQdE+u2BlUc4o+ekd40eZDIRh439w++uaOBRH2H4DYVX8F/CD kLrqb5aMULmWELOl97EUa6bs7hkuYsl8kqoCa62SqaUMyGxD1VNfaOiQ/wY2EbcX9XWa 4IvXJBjUKrjesu/UqCFGn0Vdqjl1TJdUW69OZY/xq1/Cu/zTwEbYaIXfgKkpyrRqgo3S BwdkF2hKIUvAr/XqN6wS/beCfoT9ob0zJ0MqkPuQUfjKIwtal0xlOddztHb0YWY/YGZs 58R77jIDnHsL+y29apwGAR9tmH2Truj8gPKVUbkZCxW5LqDlRiXEAeuOhP0xz3LT+Cin rs3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LSJYdZTXUyAfpG0I6iSKQygIREjAACJ5S6Chxd1rh34=; b=GWohZzTLsvZI40xEv87NUR3U+75ykEUYD+6n4Zd2dBivbit850ekwV5lPK/1PlxQwO PIZEzjGNnmJ5n/wbb1qpUJIt4IfNaeZ3nD8/NXMuzzxLnlxs/xNRoqbQh9Kd5ycgNDEl 4wDDk4K5TnK3zAfVBUAGnEpuEruA7OiUhrrLdbfUg9M8nbHp4z0CS4Nb2J/CjNvteJXK yzOcnJ074544uUric4F/1o7t1hROaSXhi88m271MaJXGEvAkDCrZJ19ikzUqyBL9BPY5 l4ybGrW/B1Hk/uzc+2PHjEGfgTyM2nP7zJ7IScCOowA+J9Z+Bv5m7SSNt+aisofaCv97 9D7A== X-Gm-Message-State: AN3rC/7mCdzKVyVVsHR7xrjyK6eZt8NUVmhG4YABjwqbVOnjG4dslsTeBrCWXZJ/TQ8Ahw== X-Received: by 10.84.231.138 with SMTP id g10mr26179123plk.110.1492013373904; Wed, 12 Apr 2017 09:09:33 -0700 (PDT) Received: from xeon-e3 (76-14-206-252.or.wavecable.com. [76.14.206.252]) by smtp.gmail.com with ESMTPSA id m19sm11218620pfg.115.2017.04.12.09.09.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 12 Apr 2017 09:09:33 -0700 (PDT) Date: Wed, 12 Apr 2017 09:09:31 -0700 From: Stephen Hemminger To: Gaetan Rivet Cc: dev@dpdk.org Message-ID: <20170412090931.72cc2e64@xeon-e3> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v13 0/7] rte_bus_pci X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2017 16:09:35 -0000 On Tue, 11 Apr 2017 13:07:27 +0200 Gaetan Rivet wrote: > I have rebased the work done by Shreyansh and Thomas to follow > the bus abstraction introduced in v17.02 for the PCI bus > implementation. > This series is only a partial version of the previous one, because > some of the patches have already been integrated, and others still > need rework. > > Additionally, Jan Blunck sent this RFC: > > [RFC] eal: use busname and devargs to attach devices > > That has not been considered for this version as it had not yet spawned > a discussion. > > changes in v13: > - Removed the PCI tests. They cannot follow the bus implementation > anymore, and it is an opportunity to update their original design. > - Changed the rte_pci_match function semantic to match its name. > - Made the rte_pci_match function private. > - Made the rte_bus_list private > - Made rte_eal_pci_add_device, > rte_eal_pci_insert_device, > rte_eal_pci_remove_device, > functions private. > > Additional work is needed: > - The PCI bus should be moved to the relevant bus sub-directory. > - The documentation must be updated. > > But this version should allow for the PCI bus implementation to be > integrated in v17.05-rc2. > > Gaetan Rivet (1): > test: remove pci tests > > Shreyansh Jain (6): > pci: split match and probe > pci: remove loop over drivers in device detach > pci: add bus driver > pci: use bus driver for scan/probe > pci: use bus driver for attach/detach > doc: remove deprecation notice for rte_bus > > MAINTAINERS | 2 - > doc/guides/rel_notes/release_17_02.rst | 2 +- > lib/librte_eal/bsdapp/eal/Makefile | 2 +- > lib/librte_eal/bsdapp/eal/eal.c | 14 - > lib/librte_eal/bsdapp/eal/eal_pci.c | 34 +- > lib/librte_eal/bsdapp/eal/rte_eal_version.map | 2 - > lib/librte_eal/common/eal_bus.h | 45 +++ > lib/librte_eal/common/eal_common_dev.c | 57 +++- > lib/librte_eal/common/eal_common_pci.c | 362 +++++++++++++-------- > lib/librte_eal/common/eal_private.h | 41 ++- > lib/librte_eal/common/include/rte_bus.h | 29 ++ > lib/librte_eal/common/include/rte_pci.h | 94 ++++-- > lib/librte_eal/linuxapp/eal/Makefile | 2 +- > lib/librte_eal/linuxapp/eal/eal.c | 14 - > lib/librte_eal/linuxapp/eal/eal_pci.c | 38 +-- > lib/librte_eal/linuxapp/eal/rte_eal_version.map | 2 - > test/test/Makefile | 2 - > test/test/test.h | 3 - > test/test/test_mp_secondary.c | 17 - > test/test/test_pci.c | 322 ------------------ > .../bus/pci/devices/0000:01:00.0/class | 1 - > .../bus/pci/devices/0000:01:00.0/config | Bin 64 -> 0 bytes > .../devices/0000:01:00.0/consistent_dma_mask_bits | 1 - > .../bus/pci/devices/0000:01:00.0/device | 1 - > .../bus/pci/devices/0000:01:00.0/dma_mask_bits | 1 - > .../bus/pci/devices/0000:01:00.0/enable | 1 - > .../bus/pci/devices/0000:01:00.0/irq | 1 - > .../bus/pci/devices/0000:01:00.0/modalias | 1 - > .../bus/pci/devices/0000:01:00.0/msi_bus | 1 - > .../bus/pci/devices/0000:01:00.0/numa_node | 1 - > .../bus/pci/devices/0000:01:00.0/resource | 13 - > .../bus/pci/devices/0000:01:00.0/sriov_numvfs | 1 - > .../bus/pci/devices/0000:01:00.0/sriov_totalvfs | 1 - > .../bus/pci/devices/0000:01:00.0/subsystem_device | 1 - > .../bus/pci/devices/0000:01:00.0/subsystem_vendor | 1 - > .../bus/pci/devices/0000:01:00.0/uevent | 6 - > .../bus/pci/devices/0000:01:00.0/vendor | 1 - > .../bus/pci/devices/0000:01:02.0/class | 1 - > .../bus/pci/devices/0000:01:02.0/device | 1 - > .../bus/pci/devices/0000:01:02.0/resource | 13 - > .../bus/pci/devices/0000:01:02.0/subsystem_device | 1 - > .../bus/pci/devices/0000:01:02.0/subsystem_vendor | 1 - > .../bus/pci/devices/0000:01:02.0/vendor | 1 - > .../bus/pci/devices/0000:02:ab.0/class | 1 - > .../bus/pci/devices/0000:02:ab.0/device | 1 - > .../bus/pci/devices/0000:02:ab.0/resource | 13 - > .../bus/pci/devices/0000:02:ab.0/subsystem_device | 1 - > .../bus/pci/devices/0000:02:ab.0/subsystem_vendor | 1 - > .../bus/pci/devices/0000:02:ab.0/vendor | 1 - > 49 files changed, 478 insertions(+), 675 deletions(-) > create mode 100644 lib/librte_eal/common/eal_bus.h > delete mode 100644 test/test/test_pci.c > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/class > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/config > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/consistent_dma_mask_bits > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/device > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/dma_mask_bits > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/enable > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/irq > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/modalias > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/msi_bus > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/numa_node > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/resource > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/sriov_numvfs > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/sriov_totalvfs > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/subsystem_device > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/subsystem_vendor > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/uevent > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:00.0/vendor > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:02.0/class > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:02.0/device > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:02.0/resource > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:02.0/subsystem_device > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:02.0/subsystem_vendor > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:01:02.0/vendor > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:02:ab.0/class > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:02:ab.0/device > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:02:ab.0/resource > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:02:ab.0/subsystem_device > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:02:ab.0/subsystem_vendor > delete mode 100644 test/test/test_pci_sysfs/bus/pci/devices/0000:02:ab.0/vendor > Looks good. Removing dependencies on PCI is part of the roadblocks in supporting Hyper-V/VMBUS and Xen netfront properly. Acked-by: Stephen Hemminger