Re: [dpdk-dev] [PATCH] ethdev: fix compilation issue with strict flags

["Gaëtan Rivet" <gaetan.rivet@6wind.com>]

Yes, with the __rte_cache_aligned, the :8 should be useless anyway.

On Thu, Apr 13, 2017 at 08:29:27AM +0300, Shahaf Shuler wrote:
>Compilation error seen while compiling mlx5 in debug mode
>under RHEL 7.3:
>
>rte_ethdev.h:1670:7: error: type of bit-field 'state' is a GCC extension
>    [-Werror=pedantic]
>
>Address it by removing the unnecessary bit-field width limitation.
>
>Fixes: d52268a8b24b ("ethdev: expose device states")
>
>Signed-off-by: Shahaf Shuler <shahafs@mellanox.com>
Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>
>---
> lib/librte_ether/rte_ethdev.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
>index d07253874..2d1bc12aa 100644
>--- a/lib/librte_ether/rte_ethdev.h
>+++ b/lib/librte_ether/rte_ethdev.h
>@@ -1667,7 +1667,7 @@ struct rte_eth_dev {
> 	 * received packets before passing them to the driver for transmission.
> 	 */
> 	struct rte_eth_rxtx_callback *pre_tx_burst_cbs[RTE_MAX_QUEUES_PER_PORT];
>-	enum rte_eth_dev_state state:8; /**< Flag indicating the port state */
>+	enum rte_eth_dev_state state; /**< Flag indicating the port state */
> } __rte_cache_aligned;
>
> struct rte_eth_dev_sriov {
>-- 
>2.12.0
>

-- 
Gaëtan Rivet
6WIND