From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 5EC5A5942 for ; Thu, 13 Apr 2017 10:30:06 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id w64so105947054wma.0 for ; Thu, 13 Apr 2017 01:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=6lMrATO62gRtz/gmj6iNrzQqXEwC6JWB2KbFlj1/esM=; b=FFKbky8UO3E+oUgtMLNz79ARpJFFhCXrbgiy115qF5V+ifDZ7DKtKHXToN11xkmKGW X/ySYwmS8zY5J3SSl8aMYnPvtKueCnW29QJycOhJXVicQzfyyzJcWpJklXmOyO6pc2rs iqUrCAZCb4yh9EkKCL3ZhjGbMEgzw4+aMg/otx7OqvJ1I5YPjG3ueVcucdoa0Auhg509 IWP9GVCywhx1o6IHnXcNq4+v1FCFTQf+3jnQotA0fFF9lDJELgTGFWI9mP7FE9ybl1fP JvRmr9yD5xp7XYBzmqaPa3MTNLnu4JH5xtLamDRpQ0Mb8I8Hpc+ip6xdjW9cfDVthEcq RyOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=6lMrATO62gRtz/gmj6iNrzQqXEwC6JWB2KbFlj1/esM=; b=sRKTRxyF0wCywW5FKjWpAEg8ujIAwzoSgshFbMOsNr3sp5qtaMuSSlxrB0W5JT0y6t vUe1Xa48XZ67hnhzU1Cy99deEdnGYcf8PWize1am64bDsC5yZttkI5BGe3A+89AiEwCK OMd1/9+uPQpHkEV9WrzMles2zcOw+NFz0cW4f/QxBKsp2QXIKF85opzS/WiadLTC1aFt hm4f7oeFtFXMd52LBE8kT6dhX7LGq1EF50i1wYoE57V5Ymv3OOMkxLjpOPDBhGGDhgf1 GNSa5A60kFgLcRk3t7IzDlfCq+V7PoFSlIONFusHj3o40kDMMX8X5M4/nZJwRKq6SDmk ZTpg== X-Gm-Message-State: AN3rC/6y8wLPlZIj6V8OnsymygmLA5UgignU0ObyPt/Wn7Dj44Hl91kD Gp76mc/jj4SNdFJf X-Received: by 10.28.145.196 with SMTP id t187mr2201296wmd.108.1492072206140; Thu, 13 Apr 2017 01:30:06 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id x20sm3132253wme.0.2017.04.13.01.30.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Apr 2017 01:30:05 -0700 (PDT) Date: Thu, 13 Apr 2017 10:29:57 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Shahaf Shuler Cc: thomas.monjalon@6wind.com, dev@dpdk.org Message-ID: <20170413082957.GC13028@bidouze.vm.6wind.com> References: <20170413052927.82842-1-shahafs@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170413052927.82842-1-shahafs@mellanox.com> User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH] ethdev: fix compilation issue with strict flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 08:30:06 -0000 Yes, with the __rte_cache_aligned, the :8 should be useless anyway. On Thu, Apr 13, 2017 at 08:29:27AM +0300, Shahaf Shuler wrote: >Compilation error seen while compiling mlx5 in debug mode >under RHEL 7.3: > >rte_ethdev.h:1670:7: error: type of bit-field 'state' is a GCC extension > [-Werror=pedantic] > >Address it by removing the unnecessary bit-field width limitation. > >Fixes: d52268a8b24b ("ethdev: expose device states") > >Signed-off-by: Shahaf Shuler Acked-by: Gaetan Rivet >--- > lib/librte_ether/rte_ethdev.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h >index d07253874..2d1bc12aa 100644 >--- a/lib/librte_ether/rte_ethdev.h >+++ b/lib/librte_ether/rte_ethdev.h >@@ -1667,7 +1667,7 @@ struct rte_eth_dev { > * received packets before passing them to the driver for transmission. > */ > struct rte_eth_rxtx_callback *pre_tx_burst_cbs[RTE_MAX_QUEUES_PER_PORT]; >- enum rte_eth_dev_state state:8; /**< Flag indicating the port state */ >+ enum rte_eth_dev_state state; /**< Flag indicating the port state */ > } __rte_cache_aligned; > > struct rte_eth_dev_sriov { >-- >2.12.0 > -- Gaëtan Rivet 6WIND