From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id BE203F94 for ; Tue, 18 Apr 2017 13:55:49 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id u2so52734955wmu.0 for ; Tue, 18 Apr 2017 04:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PAfYlymKczMAMA+KrsOZB0HGeI4fjJF6/6RiIiW4IQo=; b=YLYd/VnghB+XMdDaUFoiPf2lyp5bv4UZ9hEYFlus58r5a4JNbN/FMenxYpYSwYSgFQ oqbGxFwD4AtWaaelUflwVkF2vOHeyfTLELqJR2rE84NXiOB0BlCap5UyHqnF8A9x/ZwH mnnbMay2fnl8ngrYllgOp3/bak8IauwdVLaBHtan4au49LOF3MRd1xPar7/0VBCpyfMG /hsBpVGWHLTyTwdZiSxDMCC3SjuOGi2XUbJuFFonwI89tZBMcqD06w0cuClMnZ98lHhc MwGlHAk1gvn8PySwkmvhr9wfgvEw7k9AsZtvg/NiE1/ptQTmDi+WaNOkUM5+GXcXd17l +TOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PAfYlymKczMAMA+KrsOZB0HGeI4fjJF6/6RiIiW4IQo=; b=PQrMdEIqxJi52dXUmvK5lTPvpQ6ipSxgo+j9g/XcmbP2DJ+F8aBhwGvDrpefWoKM74 0owpExZcKAAJn3IlNGIhEDa0OQ8WdCi61Po5ygwa4eN2s2cdvh+VDVPtWzvXtNSeqMNA lkCzo7Q2WaiTHV86prLF/t7j/pDtF4xTB8mmWhvB154/qtL1g+4spQE+HFIPgDyl+dUj IeRUiNbLo++q5tRVTaZ5gaXiNPFRpzFNJ+OkrUrj6i0LHSzxOD+fZU2Xu+N8rvGCrKfq 3Y3QVJTslNrH5SS3YOIfk4fLSAGaSmJIC+g8BfmqXgYWloF++559JQx0746V2WLxGjH/ O6tg== X-Gm-Message-State: AN3rC/5xWrgtH8h3qAsa4aVjcnh77FPJRLR1X0keo1o/8HtOy8h9dLZ0 bEN0xmO+8vw6YmOr X-Received: by 10.28.168.130 with SMTP id r124mr13203147wme.134.1492516549328; Tue, 18 Apr 2017 04:55:49 -0700 (PDT) Received: from glumotte.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 59sm18463193wrl.48.2017.04.18.04.55.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Apr 2017 04:55:49 -0700 (PDT) Date: Tue, 18 Apr 2017 13:56:16 +0200 From: Olivier MATZ To: "Tan, Jianfeng" Cc: dev@dpdk.org, david.marchand@6wind.com, bruce.richardson@intel.com, thomas.monjalon@6wind.com, keith.wiles@intel.com, stephen@networkplumber.org, "De Lara Guarch, Pablo" Message-ID: <20170418135616.5be389d6@glumotte.dev.6wind.com> In-Reply-To: <632c7fa5-153d-8a97-0810-a4ac8795046e@intel.com> References: <20170329155323.4760-1-olivier.matz@6wind.com> <20170404164040.24132-1-olivier.matz@6wind.com> <20170404164040.24132-5-olivier.matz@6wind.com> <88ff6283-4b3f-f3a7-0d44-9be8fe5441c1@intel.com> <20170418105047.266cd8a0@glumotte.dev.6wind.com> <632c7fa5-153d-8a97-0810-a4ac8795046e@intel.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 4/8] eal: change specific log levels at startup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 11:55:50 -0000 Hi Jianfeng, On Tue, 18 Apr 2017 19:15:51 +0800, "Tan, Jianfeng" wrote: > On 4/18/2017 4:50 PM, Olivier MATZ wrote: > > Hi Jianfeng, > > > > On Fri, 14 Apr 2017 13:33:49 +0800, "Tan, Jianfeng" wrote: > >> Hi Olivier, > >> > >> If I understand it correctly, this patch is to shift log level setting > >> earlier. But we did not remove the one in eal_parse_common_option(). So > >> we can see this parameter will be analyzed twice. Does it make sense to > >> remove analysis of log level in eal_parse_common_option()? > >> > > The patch does not change the way the log level is parsed: it was > > already parsed twice, because we want to know the log level as soon > > as possible. > > Oh, yes, it's not introduced in this patch. How do you think if we move > log parser out from eal_parse_common_option to avoid parsing log twice? Not sure it's so easy to do. The second pass can ignore the --log-level argument, but it has to be recognized, else we would have an error. I think it's ok like this. > > > > > But the patch introduces a bug, as seen by Ferruh: the default log > > level is not set properly when no --log-level parameter is passed. > > > > Before this one, there is another one on usage of regexec(), which I put > it here: http://dpdk.org/ml/archives/dev/2017-April/064031.html. Yes, I've seen it, I'll send a patch for this today. Thanks. Olivier