DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz@6wind.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: <dev@dpdk.org>, <thomas@monjalon.net>,
	<bruce.richardson@intel.com>, <john.miller@atomicrules.com>
Subject: Re: [dpdk-dev] [PATCH] mk: link ring mempool by default for app build
Date: Tue, 18 Apr 2017 14:04:08 +0200	[thread overview]
Message-ID: <20170418140408.69df3672@glumotte.dev.6wind.com> (raw)
In-Reply-To: <1492074127-24339-1-git-send-email-shreyansh.jain@nxp.com>

On Thu, 13 Apr 2017 14:32:07 +0530, Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Fixes: 9a8e9b57f544 ("mempool: move ring handler as a driver")

Acked-by: Olivier Matz <olivier.matz@6wind.com>

> ---
> Context:
>  From the discussion in [1], it was observed that application should
>  have a default pool already linked even in case of shared builds.
>  Ring is especially important because packet mbuf creation API refer to
>  ring_mp_mc as default handler.
>  
>  Documentation for this is pending.
> 
>  [1] http://dpdk.org/ml/archives/dev/2017-April/063819.html

Maybe this comment could go in the patch.

Thanks,
Olivier

  reply	other threads:[~2017-04-18 12:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-13  9:02 Shreyansh Jain
2017-04-18 12:04 ` Olivier MATZ [this message]
2017-04-18 12:25   ` Shreyansh Jain
2017-04-19 12:26     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170418140408.69df3672@glumotte.dev.6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.miller@atomicrules.com \
    --cc=shreyansh.jain@nxp.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).