From: Olivier Matz <olivier.matz@6wind.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, jianfeng.tan@intel.com, thomas@monjalon.net
Subject: [dpdk-dev] [PATCH 2/6] eal: move internal config initialization
Date: Tue, 18 Apr 2017 16:22:21 +0200 [thread overview]
Message-ID: <20170418142225.6308-2-olivier.matz@6wind.com> (raw)
In-Reply-To: <20170418142225.6308-1-olivier.matz@6wind.com>
It's better to initialize the internal config in rte_eal_init()
instead of eal_log_level_parse(), since this structure is not only
about logs.
Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
lib/librte_eal/bsdapp/eal/eal.c | 3 ++-
lib/librte_eal/linuxapp/eal/eal.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/librte_eal/bsdapp/eal/eal.c b/lib/librte_eal/bsdapp/eal/eal.c
index db154db9a..ed16c2e58 100644
--- a/lib/librte_eal/bsdapp/eal/eal.c
+++ b/lib/librte_eal/bsdapp/eal/eal.c
@@ -323,7 +323,6 @@ eal_log_level_parse(int argc, char **argv)
optind = 1;
optreset = 1;
- eal_reset_internal_config(&internal_config);
rte_log_set_global_level(internal_config.log_level);
while ((opt = getopt_long(argc, argvopt, eal_short_options,
@@ -520,6 +519,8 @@ rte_eal_init(int argc, char **argv)
thread_id = pthread_self();
+ eal_reset_internal_config(&internal_config);
+
/* set log level as early as possible */
eal_log_level_parse(argc, argv);
diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
index b2758799c..fbfbb94ba 100644
--- a/lib/librte_eal/linuxapp/eal/eal.c
+++ b/lib/librte_eal/linuxapp/eal/eal.c
@@ -492,7 +492,6 @@ eal_log_level_parse(int argc, char **argv)
argvopt = argv;
optind = 1;
- eal_reset_internal_config(&internal_config);
rte_log_set_global_level(internal_config.log_level);
while ((opt = getopt_long(argc, argvopt, eal_short_options,
@@ -777,6 +776,8 @@ rte_eal_init(int argc, char **argv)
thread_id = pthread_self();
+ eal_reset_internal_config(&internal_config);
+
/* set log level as early as possible */
eal_log_level_parse(argc, argv);
--
2.11.0
next prev parent reply other threads:[~2017-04-18 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 14:22 [dpdk-dev] [PATCH 1/6] eal: fix default log level Olivier Matz
2017-04-18 14:22 ` Olivier Matz [this message]
2017-04-18 14:22 ` [dpdk-dev] [PATCH 3/6] eal: remove log level from internal config Olivier Matz
2017-04-18 15:00 ` Ferruh Yigit
2017-04-18 15:26 ` Olivier MATZ
2017-04-18 15:28 ` Ferruh Yigit
2017-04-18 14:22 ` [dpdk-dev] [PATCH 4/6] eal: remove undue printf Olivier Matz
2017-04-18 14:22 ` [dpdk-dev] [PATCH 5/6] eal: fix log level regexp matching Olivier Matz
2017-04-18 14:22 ` [dpdk-dev] [PATCH 6/6] eal: fix dump of registered logs when disabled Olivier Matz
2017-04-18 15:29 ` [dpdk-dev] [PATCH 1/6] eal: fix default log level Ferruh Yigit
2017-04-19 23:31 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418142225.6308-2-olivier.matz@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jianfeng.tan@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).