From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5E2DC377A for ; Fri, 21 Apr 2017 04:31:02 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Apr 2017 19:31:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,228,1488873600"; d="scan'208";a="251718641" Received: from yliu-dev.sh.intel.com (HELO yliu-dev) ([10.239.67.162]) by fmsmga004.fm.intel.com with ESMTP; 20 Apr 2017 19:30:59 -0700 Date: Fri, 21 Apr 2017 10:27:47 +0800 From: Yuanhan Liu To: "Zhao1, Wei" Cc: "Ananyev, Konstantin" , "Mcnamara, John" , "dev@dpdk.org" , "Lu, Wenzhuo" , Thomas Monjalon , "Liu, Yu Y" Message-ID: <20170421022747.GA11512@yliu-dev.sh.intel.com> References: <1490866456-52241-1-git-send-email-wei.zhao1@intel.com> <1490866456-52241-2-git-send-email-wei.zhao1@intel.com> <2969664.trJitADFWx@xps13> <20170420060758.GA12462@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Apr 2017 02:31:03 -0000 On Thu, Apr 20, 2017 at 09:17:24AM +0000, Zhao1, Wei wrote: > > > > Please explain exactly the responsibility of this function, and how > > > > it is different from calling stop/configure/start. > > > > > > In this reset feature, reset function can do the calling > > > stop/configure/start process, but also It can also do some restore > > > work for the port, for example, it can restore the added parameters of > > vlan, mac_addrs, promisc_unicast_enabled falg and > > promisc_multicast_enabled flag. > > > Maybe , I should add this explanation in the patch comments or function > > comments? > > > > I'm curious why we have to do save & restore for a reset operation. > > Why some configures have to be saved and restored? Doesn't "reset" > > literally means reset everything? > > > > Users maybe do not want to do a second configuration operation to waste time after reset which lost all previous configuration. > But he still want these configuration valid after reset. > So, save & restore can help them to save this process time and effort. > > > Even though, how do you tell what kind of configures need be restored and > > what should not? Again, even though, will all PMDs supports restoring the > > same set of configurations? > > > > Yes, this is hard to say what may be need and what may be not for user. > Now, the kinds of supported is list in patch set comment. And only i40e NIC support this feature. Why it's the configurations listed in patch 2? Because they are requested by customers? Is that all could be saved? If not, are you going to save & restore all possible configurations? Assuming the configurations saved & restored may differ from different PMD drivers, how could you keep the consistency then? And judging that the application has no idea about the difference (yet it knows nothing about what kind of configurations will be saved), how could the application know that some configurations are not saved & restored by the driver that it has to do re-configuration by itself? > > While looking at your reset implementation for i40e, it looks more complex > > than necessary: just thinking we have to call "xxx_queue_setup" > > for all PMDs. > > > > I'm thinking a simple hardware reset might be enough? > > > > /* literally reset the hardware: reset everything */ > > rte_eth_reset(port) > > { > > eth_dev->ops->reset(); > > } > > > > You mean just do a reset and do not restore any configuration? > That may not meet the need for this feature from customer? Right, I'm just aware of the configuration might be done by PF (but not only by the application), that the VF port may be not aware of those configurations. So the save & restore is needed. I don't quite like how it is done in this patch set though. I also don't think the API is well named: as said, reset should literally reset everything. We may need think how to do it properly. Thomas, Konstantin, what do you guys think of it? --yliu