From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH] usertools: reduce devbind status output
Date: Wed, 26 Apr 2017 12:58:10 +0100 [thread overview]
Message-ID: <20170426115810.495-1-ferruh.yigit@intel.com> (raw)
Script displays status for all device types and output is much
longer than it used to be. This makes harder to read script output.
This patch reduces output to the script into a device group which can be
defined with new -t,--type parameter to script.
Supported types:
net
crypto
mempool
eventdev
If no device type provided status will print net devices by default.
Sample usage:
./usertools/dpdk-devbind.py -s -t mempool
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
usertools/dpdk-devbind.py | 30 +++++++++++++++++++++++-------
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index bb4d536..609f0ad 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -86,7 +86,8 @@ def usage():
Display usage information and quit
-s, --status:
- Print the current status of all known network and crypto devices.
+ Print the current status of all known devices in a device group.
+ Device group selected by --type (-t) argument.
For each device, it displays the PCI domain, bus, slot and function,
along with a text description of the device. Depending upon whether the
device is being used by a kernel driver, the igb_uio driver, or no
@@ -99,6 +100,11 @@ def usage():
status display will always occur after the other operations have taken
place.
+ -t, --type:
+ Select device group to print status.
+ Device group can be network, crypto, eventdev or mempool.
+ Type argument can be emitted, by default "network" group used.
+
-b driver, --bind=driver:
Select the driver to use or \"none\" to unbind the device
@@ -598,26 +604,34 @@ def show_status():
Displays to the user what devices are bound to the igb_uio driver, the
kernel driver or to no driver'''
- show_device_status(network_devices, "Network")
- show_device_status(crypto_devices, "Crypto")
- show_device_status(eventdev_devices, "Eventdev")
- show_device_status(mempool_devices, "Mempool")
+ if status_type == "crypto":
+ show_device_status(crypto_devices, "Crypto")
+ elif status_type == "event":
+ show_device_status(eventdev_devices, "Eventdev")
+ elif status_type == "mempool":
+ show_device_status(mempool_devices, "Mempool")
+ else:
+ show_device_status(network_devices, "Network")
def parse_args():
'''Parses the command-line arguments given by the user and takes the
appropriate action for each'''
global b_flag
global status_flag
+ global status_type
global force_flag
global args
if len(sys.argv) <= 1:
usage()
sys.exit(0)
+ # set default status device type
+ status_type = "net"
+
try:
- opts, args = getopt.getopt(sys.argv[1:], "b:us",
+ opts, args = getopt.getopt(sys.argv[1:], "b:ust:",
["help", "usage", "status", "force",
- "bind=", "unbind"])
+ "bind=", "unbind", "type="])
except getopt.GetoptError as error:
print(str(error))
print("Run '%s --usage' for further information" % sys.argv[0])
@@ -627,6 +641,8 @@ def parse_args():
if opt == "--help" or opt == "--usage":
usage()
sys.exit(0)
+ if opt == "--type" or opt == "-t":
+ status_type = arg
if opt == "--status" or opt == "-s":
status_flag = True
if opt == "--force":
--
2.9.3
next reply other threads:[~2017-04-26 11:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 11:58 Ferruh Yigit [this message]
2017-04-26 13:09 ` Thomas Monjalon
2017-04-27 17:55 ` [dpdk-dev] [PATCH v2] usertools: add status-dev argument to devbind Ferruh Yigit
2017-04-30 12:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426115810.495-1-ferruh.yigit@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).