From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C15C8688B for ; Wed, 26 Apr 2017 17:11:16 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B523F3DBD5; Wed, 26 Apr 2017 15:11:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B523F3DBD5 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=mst@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B523F3DBD5 Received: from redhat.com (ovpn-122-230.rdu2.redhat.com [10.10.122.230]) by smtp.corp.redhat.com (Postfix) with SMTP id B32819652D; Wed, 26 Apr 2017 15:11:11 +0000 (UTC) Date: Wed, 26 Apr 2017 18:11:10 +0300 From: "Michael S. Tsirkin" To: "Tan, Jianfeng" Cc: Yuanhan Liu , "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "thomas@monjalon.net" Message-ID: <20170426181041-mutt-send-email-mst@kernel.org> References: <1493182371-34295-1-git-send-email-jianfeng.tan@intel.com> <1493182371-34295-3-git-send-email-jianfeng.tan@intel.com> <20170426053235.GF11512@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 26 Apr 2017 15:11:15 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH 2/3] net/virtio: clean up LSC setting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Apr 2017 15:11:17 -0000 On Wed, Apr 26, 2017 at 05:44:05AM +0000, Tan, Jianfeng wrote: > > > > -----Original Message----- > > From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com] > > Sent: Wednesday, April 26, 2017 1:33 PM > > To: Tan, Jianfeng > > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; thomas@monjalon.net > > Subject: Re: [PATCH 2/3] net/virtio: clean up LSC setting > > > > On Wed, Apr 26, 2017 at 04:52:50AM +0000, Jianfeng Tan wrote: > > > Clean up LSC setting: > > > > Firstly, this patch does two things. There should be two patches. > > I just merged them into one to adapt to the name of "clean up" :-) > > > > > > - LSC flag is set in several places, but only the last one takes > > > effect; so we just keep the last one. > > > - As we already change to use capability list to detect MSI-X, remove > > > the redundant MSI-X detection in legacy devices. > > > > However, there is no capability list for legacy device. > > When I try legacy device on QEMU (disable-modern=true), I did detect MSI-X capability. So does virtio spec mean legacy devices do not have vendor-specific capability list? > > Thanks, > Jianfeng Yes, as far as I know legacy devices don't have vendor-specific capability lists. -- MST